mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2026-08-09 06:14:34 +02:00
Keshav VermaandGreg Kroah-Hartman
eb1645bf10
Rust Binder stats use BC_COUNT and BR_COUNT to size the command and
return counters, and use event string tables when printing debug
statistics.
The Binder protocol includes freeze-related commands and return codes,
but the Rust Binder statistics code was not updated to cover them. As a
result, those commands and return codes are not accounted for or printed
by the stats debug output.
Update the counts and event string tables so these commands and return
codes are included in the debug statistics output.
Fixes: eafedbc7c0 ("rust_binder: add Rust Binder driver")
Cc: stable <stable@kernel.org>
Acked-by: Carlos Llamas <cmllamas@google.com>
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
Signed-off-by: Keshav Verma <iganschel@gmail.com>
Link: https://patch.msgid.link/20260615211743.734-1-iganschel@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
90 lines
3.0 KiB
Rust
90 lines
3.0 KiB
Rust
// SPDX-License-Identifier: GPL-2.0
|
|
|
|
// Copyright (C) 2025 Google LLC.
|
|
|
|
//! Keep track of statistics for binder_logs.
|
|
|
|
use crate::defs::*;
|
|
use kernel::sync::atomic::{ordering::Relaxed, Atomic};
|
|
use kernel::{ioctl::_IOC_NR, seq_file::SeqFile, seq_print};
|
|
|
|
const BC_COUNT: usize = _IOC_NR(BC_FREEZE_NOTIFICATION_DONE) as usize + 1;
|
|
const BR_COUNT: usize = _IOC_NR(BR_CLEAR_FREEZE_NOTIFICATION_DONE) as usize + 1;
|
|
|
|
pub(crate) static GLOBAL_STATS: BinderStats = BinderStats::new();
|
|
|
|
pub(crate) struct BinderStats {
|
|
bc: [Atomic<u32>; BC_COUNT],
|
|
br: [Atomic<u32>; BR_COUNT],
|
|
}
|
|
|
|
impl BinderStats {
|
|
pub(crate) const fn new() -> Self {
|
|
#[expect(clippy::declare_interior_mutable_const)]
|
|
const ZERO: Atomic<u32> = Atomic::new(0);
|
|
|
|
Self {
|
|
bc: [ZERO; BC_COUNT],
|
|
br: [ZERO; BR_COUNT],
|
|
}
|
|
}
|
|
|
|
pub(crate) fn inc_bc(&self, bc: u32) {
|
|
let idx = _IOC_NR(bc) as usize;
|
|
if let Some(bc_ref) = self.bc.get(idx) {
|
|
bc_ref.fetch_add(1, Relaxed);
|
|
}
|
|
}
|
|
|
|
pub(crate) fn inc_br(&self, br: u32) {
|
|
let idx = _IOC_NR(br) as usize;
|
|
if let Some(br_ref) = self.br.get(idx) {
|
|
br_ref.fetch_add(1, Relaxed);
|
|
}
|
|
}
|
|
|
|
pub(crate) fn debug_print(&self, prefix: &str, m: &SeqFile) {
|
|
for (i, cnt) in self.bc.iter().enumerate() {
|
|
let cnt = cnt.load(Relaxed);
|
|
if cnt > 0 {
|
|
seq_print!(m, "{}{}: {}\n", prefix, command_string(i), cnt);
|
|
}
|
|
}
|
|
for (i, cnt) in self.br.iter().enumerate() {
|
|
let cnt = cnt.load(Relaxed);
|
|
if cnt > 0 {
|
|
seq_print!(m, "{}{}: {}\n", prefix, return_string(i), cnt);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
mod strings {
|
|
use core::str::from_utf8_unchecked;
|
|
use kernel::str::{CStr, CStrExt as _};
|
|
|
|
extern "C" {
|
|
static binder_command_strings: [*const u8; super::BC_COUNT];
|
|
static binder_return_strings: [*const u8; super::BR_COUNT];
|
|
}
|
|
|
|
pub(super) fn command_string(i: usize) -> &'static str {
|
|
// SAFETY: Accessing `binder_command_strings` is always safe.
|
|
let c_str_ptr = unsafe { binder_command_strings[i] };
|
|
// SAFETY: The `binder_command_strings` array only contains nul-terminated strings.
|
|
let bytes = unsafe { CStr::from_char_ptr(c_str_ptr) }.to_bytes();
|
|
// SAFETY: The `binder_command_strings` array only contains strings with ascii-chars.
|
|
unsafe { from_utf8_unchecked(bytes) }
|
|
}
|
|
|
|
pub(super) fn return_string(i: usize) -> &'static str {
|
|
// SAFETY: Accessing `binder_return_strings` is always safe.
|
|
let c_str_ptr = unsafe { binder_return_strings[i] };
|
|
// SAFETY: The `binder_command_strings` array only contains nul-terminated strings.
|
|
let bytes = unsafe { CStr::from_char_ptr(c_str_ptr) }.to_bytes();
|
|
// SAFETY: The `binder_command_strings` array only contains strings with ascii-chars.
|
|
unsafe { from_utf8_unchecked(bytes) }
|
|
}
|
|
}
|
|
use strings::{command_string, return_string};
|