mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2026-08-09 06:14:34 +02:00
Zhao DongdongandPhilipp Zabel
1a8c89f8c1
In sunxi_reset_init(), when ioremap() fails, the memory region obtained
via request_mem_region() is not released, leading to a resource leak.
Add an err_mem_region label to properly release the memory region before
freeing the data structure.
Fixes: 8f1ae77f46 ("reset: Add Allwinner SoCs Reset Controller Driver")
Cc: stable@vger.kernel.org
Signed-off-by: Zhao Dongdong <zhaodongdong@kylinos.cn>
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
86 lines
1.9 KiB
C
86 lines
1.9 KiB
C
// SPDX-License-Identifier: GPL-2.0-or-later
|
|
/*
|
|
* Allwinner SoCs Reset Controller driver
|
|
*
|
|
* Copyright 2013 Maxime Ripard
|
|
*
|
|
* Maxime Ripard <maxime.ripard@free-electrons.com>
|
|
*/
|
|
|
|
#include <linux/err.h>
|
|
#include <linux/io.h>
|
|
#include <linux/init.h>
|
|
#include <linux/of.h>
|
|
#include <linux/of_address.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/reset-controller.h>
|
|
#include <linux/reset/reset-simple.h>
|
|
#include <linux/reset/sunxi.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/spinlock.h>
|
|
#include <linux/types.h>
|
|
|
|
static int sunxi_reset_init(struct device_node *np)
|
|
{
|
|
struct reset_simple_data *data;
|
|
struct resource res;
|
|
resource_size_t size;
|
|
int ret;
|
|
|
|
data = kzalloc_obj(*data);
|
|
if (!data)
|
|
return -ENOMEM;
|
|
|
|
ret = of_address_to_resource(np, 0, &res);
|
|
if (ret)
|
|
goto err_alloc;
|
|
|
|
size = resource_size(&res);
|
|
if (!request_mem_region(res.start, size, np->name)) {
|
|
ret = -EBUSY;
|
|
goto err_alloc;
|
|
}
|
|
|
|
data->membase = ioremap(res.start, size);
|
|
if (!data->membase) {
|
|
ret = -ENOMEM;
|
|
goto err_mem_region;
|
|
}
|
|
|
|
spin_lock_init(&data->lock);
|
|
|
|
data->rcdev.owner = THIS_MODULE;
|
|
data->rcdev.nr_resets = size * 8;
|
|
data->rcdev.ops = &reset_simple_ops;
|
|
data->rcdev.of_node = np;
|
|
data->active_low = true;
|
|
|
|
return reset_controller_register(&data->rcdev);
|
|
|
|
err_mem_region:
|
|
release_mem_region(res.start, size);
|
|
err_alloc:
|
|
kfree(data);
|
|
return ret;
|
|
};
|
|
|
|
/*
|
|
* These are the reset controller we need to initialize early on in
|
|
* our system, before we can even think of using a regular device
|
|
* driver for it.
|
|
* The controllers that we can register through the regular device
|
|
* model are handled by the simple reset driver directly.
|
|
*/
|
|
static const struct of_device_id sunxi_early_reset_dt_ids[] __initconst = {
|
|
{ .compatible = "allwinner,sun6i-a31-ahb1-reset", },
|
|
{ /* sentinel */ },
|
|
};
|
|
|
|
void __init sun6i_reset_init(void)
|
|
{
|
|
struct device_node *np;
|
|
|
|
for_each_matching_node(np, sunxi_early_reset_dt_ids)
|
|
sunxi_reset_init(np);
|
|
}
|