averello/macvim-mirror
1
0
Fork 0
mirror of https://github.com/macvim-dev/macvim.git synced 2026-06-11 15:37:29 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix artifacts when entering full screen.

Browse Source 
This changes MMFullScreenWindow to release the fade in a completion
handler for the current transaction, so that the app flushes updates
while the screen is black. It also fixes up the fadeReservationTime math
and bumps the slack to a full second so that a slightly slow draw
doesn't cause artifacts (in practice, the fade will be released as soon
as the window draws — the reservation time is just a failsafe).
This commit is contained in:
Sidney San Martín
2017-03-31 13:28:59 -04:00
parent 98496b9aa2
commit 32e1fc9b2d
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/MacVim/MMFullScreenWindow.m
+7 -5
View File
@@ -110,8 +110,8 @@ enum {
// Each fade goes in and then out, so the fade hardware must be reserved accordingly and the
// actual fade time can't exceed half the allowable reservation time... plus some slack to
// prevent visual artifacts caused by defaulting on the fade hardware lease.
fadeTime = MIN(fadeTime, 0.45 * kCGMaxDisplayReservationInterval);
fadeReservationTime = 2.0 * fadeTime + 0.1;
fadeTime = MIN(fadeTime, 0.5 * (kCGMaxDisplayReservationInterval - 1));
fadeReservationTime = 2.0 * fadeTime + 1;
return self;
}
@@ -218,9 +218,11 @@ enum {
// fade back in
if (didBlend) {
CGDisplayFade(token, fadeTime, kCGDisplayBlendSolidColor,
kCGDisplayBlendNormal, .0, .0, .0, false);
CGReleaseDisplayFadeReservation(token);
[NSAnimationContext currentContext].completionHandler = ^{
CGDisplayFade(token, fadeTime, kCGDisplayBlendSolidColor,
kCGDisplayBlendNormal, .0, .0, .0, false);
CGReleaseDisplayFadeReservation(token);
};
}
state = InFullScreen;