averello/macvim-mirror
1
0
Fork 0
mirror of https://github.com/macvim-dev/macvim.git synced 2026-06-11 15:37:29 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix ODB Input Manager memory issue

Browse Source 
The Input Manager failed to retain two string objects which were
accessed after having been autoreleased.  This patch fixes the bug where
the "Edit in ..." menu entry was corrupted and related issues.

The version number of the Input Manager has been bumped to 1.2.
This commit is contained in:
Scott
2008-03-13 21:41:38 +01:00
committed by Bjorn Winckler
parent 90c663f76b
commit 8574b2152c
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/MacVim/edit-in-odb/Info.plist
+1 -1
View File
@@ -19,7 +19,7 @@
<key>CFBundleSignature</key>
<string>????</string>
<key>CFBundleVersion</key>
<string>1.1</string>
<string>1.2</string>
<key>NSPrincipalClass</key>
<string>EditInODBEditor</string>
</dict>
src/MacVim/edit-in-odb/src/Edit in ODBEditor.mm
+3 -3
View File
@@ -275,10 +275,10 @@ struct PBX_SelectionRange
@"<Unknown>", @"ODBEditorName",
nil];
[defaults registerDefaults:appDefaults];
[defaults registerDefaults:appDefaults];
ODBEditorBundleIdentifier = [defaults stringForKey:@"ODBEditorBundleIdentifier"] ?: @"";
ODBEditorName = [defaults stringForKey:@"ODBEditorName"] ?: @"<Unknown>";
ODBEditorBundleIdentifier = [[defaults stringForKey:@"ODBEditorBundleIdentifier"] retain] ?: @"";
ODBEditorName = [[defaults stringForKey:@"ODBEditorName"] retain] ?: @"<Unknown>";
if([defaults boolForKey:@"DisableEditInODBEditorMenuItem"] == NO
&& ![ODBEditorBundleIdentifier isEqualToString:@""]
&& ![ODBEditorBundleIdentifier isEqualToString:mainBundleIdentifier])