Files
nextcloud-server-mirror/apps/dav/lib/Migration/RemoveDeletedUsersCalendarSubscriptions.php
Git'Fellow 4920bd1725 refactor: add PHP 8.3 types to BC-safe class constants
PHP 8.3 allows class constants to declare a type. Adopt it where doing so
cannot break third-party apps.

Typing an inheritable constant is a hard BC break: a subclass that
redeclares it untyped fails to load with "Type of C::FOO must be
compatible with P::FOO of type string". Changes are therefore limited to
constants that cannot be redeclared by a subclass:

  - private const (not inherited)
  - final public/protected const
  - constants declared in a final class or an enum

Interface constants, trait constants, and public/protected constants in
non-final (including abstract) classes are left untyped, as is all of
lib/public (OCP) and lib/unstable (NCU).

One review-requested exception: the public OBJECT_PREFIX/OBJECT_SUFFIX
constants of the app-internal CalDAV import helpers (TextImporter,
XmlImporter) are typed as well; these classes are not public API and
have no subclasses.

Only string, int and array are used. float is avoided because it would
silently coerce an int literal and change === comparisons. No constant
name or value is modified: every changed line adds only the type token,
so runtime behaviour is unchanged.

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2026-08-11 13:52:52 +01:00

127 lines
3.0 KiB
PHP

<?php
declare(strict_types=1);
/**
* SPDX-FileCopyrightText: 2021 Nextcloud GmbH and Nextcloud contributors
* SPDX-License-Identifier: AGPL-3.0-or-later
*/
namespace OCA\DAV\Migration;
use OCP\DB\Exception;
use OCP\IDBConnection;
use OCP\IUserManager;
use OCP\Migration\IOutput;
use OCP\Migration\IRepairStep;
class RemoveDeletedUsersCalendarSubscriptions implements IRepairStep {
/** @var int */
private $progress = 0;
/** @var int[] */
private $orphanSubscriptionIds = [];
private const int SUBSCRIPTIONS_CHUNK_SIZE = 1000;
public function __construct(
private IDBConnection $connection,
private IUserManager $userManager,
) {
}
/**
* @inheritdoc
*/
#[\Override]
public function getName(): string {
return 'Clean up old calendar subscriptions from deleted users that were not cleaned-up';
}
/**
* @inheritdoc
*/
#[\Override]
public function run(IOutput $output) {
$nbSubscriptions = $this->countSubscriptions();
$output->startProgress($nbSubscriptions);
while ($this->progress < $nbSubscriptions) {
$this->checkSubscriptions();
$this->progress += self::SUBSCRIPTIONS_CHUNK_SIZE;
$output->advance(min(self::SUBSCRIPTIONS_CHUNK_SIZE, $nbSubscriptions));
}
$output->finishProgress();
$this->deleteOrphanSubscriptions();
$output->info(sprintf('%d calendar subscriptions without an user have been cleaned up', count($this->orphanSubscriptionIds)));
}
/**
* @throws Exception
*/
private function countSubscriptions(): int {
$qb = $this->connection->getQueryBuilder();
$query = $qb->select($qb->func()->count('*'))
->from('calendarsubscriptions');
$result = $query->executeQuery();
$count = $result->fetchOne();
$result->closeCursor();
if ($count !== false) {
$count = (int)$count;
} else {
$count = 0;
}
return $count;
}
/**
* @throws Exception
*/
private function checkSubscriptions(): void {
$qb = $this->connection->getQueryBuilder();
$query = $qb->selectDistinct(['id', 'principaluri'])
->from('calendarsubscriptions')
->setMaxResults(self::SUBSCRIPTIONS_CHUNK_SIZE)
->setFirstResult($this->progress);
$result = $query->executeQuery();
while ($row = $result->fetchAssociative()) {
$username = $this->getPrincipal($row['principaluri']);
if (!$this->userManager->userExists($username)) {
$this->orphanSubscriptionIds[] = (int)$row['id'];
}
}
$result->closeCursor();
}
/**
* @throws Exception
*/
private function deleteOrphanSubscriptions(): void {
foreach ($this->orphanSubscriptionIds as $orphanSubscriptionID) {
$this->deleteOrphanSubscription($orphanSubscriptionID);
}
}
/**
* @throws Exception
*/
private function deleteOrphanSubscription(int $orphanSubscriptionID): void {
$qb = $this->connection->getQueryBuilder();
$qb->delete('calendarsubscriptions')
->where($qb->expr()->eq('id', $qb->createNamedParameter($orphanSubscriptionID)))
->executeStatement();
}
private function getPrincipal(string $principalUri): string {
$uri = explode('/', $principalUri);
return array_pop($uri);
}
}