averello/sourcekit-lsp
1
0
Fork 0
mirror of https://github.com/apple/sourcekit-lsp.git synced 2026-03-02 18:23:24 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1941 from ahoppen/log-request-names

Browse Source 
Log the request methods when logging a request's reply
This commit is contained in:
Alex Hoppen
2025-01-24 14:12:54 -08:00
committed by GitHub
parent e9ea204ac2 63fa05091d
commit 1ba45f83dd
3 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Sources/LanguageServerProtocolExtensions/LocalConnection.swift
View File

@@ -138,6 +138,7 @@ package final class LocalConnection: Connection, Sendable {
logger.info(
"""
Received reply for request \(id, privacy: .public) from \(self.name, privacy: .public)
\(Request.method, privacy: .public)
\(response.forLogging)
"""
)
@@ -145,6 +146,7 @@ package final class LocalConnection: Connection, Sendable {
logger.error(
"""
Received error for request \(id, privacy: .public) from \(self.name, privacy: .public)
\(Request.method, privacy: .public)
\(error.forLogging)
"""
)

4
Sources/LanguageServerProtocolExtensions/QueueBasedMessageHandler.swift
View File

@@ -192,7 +192,7 @@ extension QueueBasedMessageHandler {
)
.makeSignposter()
let signpostID = signposter.makeSignpostID()
let state = signposter.beginInterval("Notification", id: signpostID, "\(type(of: notification))")
let state = signposter.beginInterval("Notification", id: signpostID, "\(type(of: notification).method)")
messageHandlingQueue.async(metadata: DependencyTracker(notification)) {
signposter.emitEvent("Start handling", id: signpostID)
await self.handle(notification: notification)
@@ -209,7 +209,7 @@ extension QueueBasedMessageHandler {
let signposter = Logger(subsystem: LoggingScope.subsystem, category: messageHandlingHelper.signpostLoggingCategory)
.makeSignposter()
let signpostID = signposter.makeSignpostID()
let state = signposter.beginInterval("Request", id: signpostID, "\(Request.self)")
let state = signposter.beginInterval("Request", id: signpostID, "\(Request.method)")
self.didReceive(request: request, id: id)

2
Sources/LanguageServerProtocolJSONRPC/JSONRPCConnection.swift
View File

@@ -708,6 +708,7 @@ public final class JSONRPCConnection: Connection {
logger.info(
"""
Received reply for request \(id, privacy: .public) from \(self.name, privacy: .public)
\(Request.method, privacy: .public)
\(response.forLogging)
"""
)
@@ -715,6 +716,7 @@ public final class JSONRPCConnection: Connection {
logger.error(
"""
Received error for request \(id, privacy: .public) from \(self.name, privacy: .public)
\(Request.method, privacy: .public)
\(error.forLogging)
"""
)