averello/sourcekit-lsp
1
0
Fork 0
mirror of https://github.com/apple/sourcekit-lsp.git synced 2026-03-02 18:23:24 +01:00
Code Issues Packages Projects Releases Wiki Activity

Update InlayHintsTests

Browse Source 
The annotations are now (correctly) displayed after the variable
identifiers rather than after the bound expressions.
This commit is contained in:
Fredrik Wieczerkowski
2021-06-15 16:45:44 +02:00
parent 7e376e0f8c
commit fdf3b448ec
1 changed files with 12 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

39
Tests/SourceKitLSPTests/InlayHintsTests.swift
View File

@@ -67,18 +67,15 @@ final class InlayHintsTests: XCTestCase {
let x = 4
var y = "test" + "123"
"""
// FIXME: These type hints should ideally be displayed after the variable name
// rather than after the expression. Once the implementation is updated (e.g.
// by using a new SourceKit request), these tests should be updated too.
let hints = performInlayHintsRequest(text: text)
XCTAssertEqual(hints, [
InlayHint(
position: Position(line: 0, utf16index: 9),
position: Position(line: 0, utf16index: 5),
category: .type,
label: "Int"
),
InlayHint(
position: Position(line: 1, utf16index: 22),
position: Position(line: 1, utf16index: 5),
category: .type,
label: "String"
),
@@ -102,12 +99,12 @@ final class InlayHintsTests: XCTestCase {
let hints = performInlayHintsRequest(text: text, range: range)
XCTAssertEqual(hints, [
InlayHint(
position: Position(line: 6, utf16index: 23),
position: Position(line: 6, utf16index: 10),
category: .type,
label: "Bool"
),
InlayHint(
position: Position(line: 7, utf16index: 43),
position: Position(line: 7, utf16index: 12),
category: .type,
label: "Int"
)
@@ -133,27 +130,27 @@ final class InlayHintsTests: XCTestCase {
let hints = performInlayHintsRequest(text: text)
XCTAssertEqual(hints, [
InlayHint(
position: Position(line: 1, utf16index: 24),
position: Position(line: 1, utf16index: 20),
category: .type,
label: "Int"
),
InlayHint(
position: Position(line: 2, utf16index: 33),
position: Position(line: 2, utf16index: 25),
category: .type,
label: "String"
),
InlayHint(
position: Position(line: 6, utf16index: 36),
position: Position(line: 6, utf16index: 20),
category: .type,
label: "String"
),
InlayHint(
position: Position(line: 7, utf16index: 33),
position: Position(line: 7, utf16index: 25),
category: .type,
label: "Int"
),
InlayHint(
position: Position(line: 11, utf16index: 31),
position: Position(line: 11, utf16index: 25),
category: .type,
label: "Double"
),
@@ -169,20 +166,8 @@ final class InlayHintsTests: XCTestCase {
}
"""
let hints = performInlayHintsRequest(text: text)
// FIXME: Explicitly type-annotated variable bindings shouldn't have
// an inlay hint. Once we move to the new SourceKit request (as detailed
// in the other comment above), we should receive the empty array here.
XCTAssertEqual(hints, [
InlayHint(
position: Position(line: 0, utf16index: 21),
category: .type,
label: "String"
),
InlayHint(
position: Position(line: 3, utf16index: 17),
category: .type,
label: "Int"
)
])
XCTAssertEqual(hints, [])
}
// TODO: Add test for closure parameters
}