averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-14 20:36:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

[TypeChecker] Downgrade noasync availability to warnings on @preconcurrency declarations

Browse Source 
This change helps to stage in new `async` overloads in Swift 6 language mode
if `@preconcurrency` declaration is not available from async contexts.
This commit is contained in:
Pavel Yaskevich
2025-01-17 14:01:34 -08:00
parent 6b2fb2e4b4
commit 00fe5632d7
2 changed files with 22 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/Sema/TypeCheckAvailability.cpp
View File

@@ -4147,6 +4147,8 @@ diagnoseDeclAsyncAvailability(const ValueDecl *D, SourceRange R,
auto diag = ctx.Diags.diagnose(diagLoc, diag::async_unavailable_decl, D,
attr->getMessage());
diag.warnUntilSwiftVersion(6);
diag.limitBehaviorWithPreconcurrency(DiagnosticBehavior::Warning,
D->preconcurrency());
if (!attr->getRename().empty()) {
fixItAvailableAttrRename(diag, R, D, attr->getRename(), call);

20
test/Concurrency/unavailable_from_async_swift6.swift Normal file
View File

@@ -0,0 +1,20 @@
// RUN: %target-typecheck-verify-swift -target %target-swift-5.1-abi-triple -swift-version 6
// REQUIRES: concurrency
// REQUIRES: asserts
struct API {
@available(*, noasync, message: "use complete() instead")
func wait() {}
@preconcurrency
@available(*, noasync, message: "use complete() instead")
func waitUntilComplete() {}
func complete() async {}
}
func test(v: API) async {
v.wait() // expected-error {{instance method 'wait' is unavailable from asynchronous contexts; use complete() instead}}
v.waitUntilComplete() // expected-warning {{instance method 'waitUntilComplete' is unavailable from asynchronous contexts; use complete() instead}}
}