AST: Quote attributes more consistently in DiagnosticsModuleDiffer.def

This commit is contained in:
Anthony Latsis
2025-04-07 13:54:32 +01:00
parent 2b9123906c
commit 1d6ed11e46
11 changed files with 69 additions and 69 deletions

View File

@@ -66,7 +66,7 @@ ERROR(optional_req_changed,APIDigesterBreakage,"%0 is %select{now|no longer}1 an
ERROR(no_longer_open,APIDigesterBreakage,"%0 is no longer open for subclassing", (StringRef))
ERROR(func_type_escaping_changed,APIDigesterBreakage,"%0 has %select{removed|added}2 @escaping in %1", (StringRef, StringRef, bool))
ERROR(func_type_escaping_changed,APIDigesterBreakage,"%0 has %select{removed|added}2 '@escaping' in %1", (StringRef, StringRef, bool))
ERROR(func_self_access_change,APIDigesterBreakage,"%0 has self access kind changing from %1 to %2", (StringRef, StringRef, StringRef))
@@ -78,7 +78,7 @@ ERROR(decl_new_witness_table_entry,APIDigesterBreakage,"%0 now requires%select{|
ERROR(class_member_moved_to_extension,APIDigesterBreakage,"Non-final class member %0 is moved to extension", (StringRef))
WARNING(new_decl_without_intro,APIDigesterBreakage,"%0 is a new API without @available attribute", (StringRef))
WARNING(new_decl_without_intro,APIDigesterBreakage,"%0 is a new API without '@available'", (StringRef))
ERROR(objc_name_change,APIDigesterBreakage,"%0 has ObjC name change from %1 to %2", (StringRef, StringRef, StringRef))

View File

@@ -60,10 +60,10 @@ Constructor UInt8.init(exactly:) has mangled name changing from 'Swift.UInt8.ini
Constructor UInt8.init(exactly:) has parameter 0 type change from Swift.Float80 to Swift.Float16
Constructor _ExpressibleByBuiltinFloatLiteral.init(_builtinFloatLiteral:) has mangled name changing from 'Swift._ExpressibleByBuiltinFloatLiteral.init(_builtinFloatLiteral: Builtin.FPIEEE80) -> A' to 'Swift._ExpressibleByBuiltinFloatLiteral.init(_builtinFloatLiteral: Builtin.FPIEEE64) -> A'
Constructor _ExpressibleByBuiltinFloatLiteral.init(_builtinFloatLiteral:) has parameter 0 type change from Builtin.FPIEEE80 to Builtin.FPIEEE64
Func __VaListBuilder.allocStorage(wordCount:) is a new API without @available attribute
Func __VaListBuilder.appendWords(_:) is a new API without @available attribute
Func __VaListBuilder.deallocStorage(wordCount:storage:) is a new API without @available attribute
Func __VaListBuilder.rawSizeAndAlignment(_:) is a new API without @available attribute
Func __VaListBuilder.allocStorage(wordCount:) is a new API without '@available'
Func __VaListBuilder.appendWords(_:) is a new API without '@available'
Func __VaListBuilder.deallocStorage(wordCount:storage:) is a new API without '@available'
Func __VaListBuilder.rawSizeAndAlignment(_:) is a new API without '@available'
Func _cos(_:) has been removed
Func _exp(_:) has been removed
Func _exp2(_:) has been removed
@@ -75,14 +75,14 @@ Func _rint(_:) has been removed
Func _sin(_:) has been removed
Struct Float80 has been removed
Struct __VaListBuilder.Header has been removed
Var __VaListBuilder.allocated is a new API without @available attribute
Var __VaListBuilder.allocated is a new API without '@available'
Var __VaListBuilder.allocated is added to a non-resilient type
Var __VaListBuilder.count is a new API without @available attribute
Var __VaListBuilder.count is a new API without '@available'
Var __VaListBuilder.count is added to a non-resilient type
Var __VaListBuilder.fpRegistersUsed has been removed
Var __VaListBuilder.gpRegistersUsed has been removed
Var __VaListBuilder.header has been removed
Var __VaListBuilder.requiredAlignmentInBytes is a new API without @available attribute
Var __VaListBuilder.requiredAlignmentInBytes is a new API without '@available'
Var __VaListBuilder.requiredAlignmentInBytes is added to a non-resilient type
Var __VaListBuilder.storage has declared type change from Swift.ContiguousArray<Swift.Int> to Swift.UnsafeMutablePointer<Swift.Int>?
Var __VaListBuilder.storage has mangled name changing from 'Swift.__VaListBuilder.storage : Swift.ContiguousArray<Swift.Int>' to 'Swift.__VaListBuilder.storage : Swift.Optional<Swift.UnsafeMutablePointer<Swift.Int>>'

View File

@@ -49,8 +49,8 @@ cake: Constructor S1.init(_:) has parameter 0 type change from Swift.Int to Swif
cake: Func C1.foo2(_:) has parameter 0 type change from Swift.Int to () -> ()
cake: Func C7.foo(_:_:) has removed default argument from parameter 0
cake: Func C7.foo(_:_:) has removed default argument from parameter 1
cake: Func EscapingFunctionType.addedEscaping(_:) has added @escaping in parameter 0
cake: Func EscapingFunctionType.removedEscaping(_:) has removed @escaping in parameter 0
cake: Func EscapingFunctionType.addedEscaping(_:) has added '@escaping' in parameter 0
cake: Func EscapingFunctionType.removedEscaping(_:) has removed '@escaping' in parameter 0
cake: Func Somestruct2.foo1(_:) has parameter 0 type change from cake.C3 to cake.C1
cake: Func Zoo.getCurrentAnimalInlinable() has return type change from [cake.Cat] to [cake.Dog]
cake: Func ownershipChange(_:_:) has parameter 0 changing from InOut to Default
@@ -59,41 +59,41 @@ cake: Func returnFunctionTypeOwnershipChange() has return type change from (cake
cake: Var Zoo.current has declared type change from cake.Cat to cake.Dog
/* Decl Attribute changes */
cake: Accessor GlobalLetChangedToVar.Modify() is a new API without @available attribute
cake: Accessor GlobalLetChangedToVar.Set() is a new API without @available attribute
cake: Accessor fixedLayoutStruct2.BecomeFixedBinaryOrder.Modify() is a new API without @available attribute
cake: Accessor fixedLayoutStruct2.BecomeFixedBinaryOrder.Set() is a new API without @available attribute
cake: AssociatedType RequirementChanges.addedTypeWithDefault is a new API without @available attribute
cake: AssociatedType RequirementChanges.addedTypeWithoutDefault is a new API without @available attribute
cake: Class C0 is a new API without @available attribute
cake: Class C8 is a new API without @available attribute
cake: Constructor AddingNewDesignatedInit.init(_:) is a new API without @available attribute
cake: Constructor C1.init(_:) is a new API without @available attribute
cake: Constructor ClassWithMissingDesignatedInits.init() is a new API without @available attribute
cake: Constructor SubclassWithMissingDesignatedInits.init() is a new API without @available attribute
cake: Accessor GlobalLetChangedToVar.Modify() is a new API without '@available'
cake: Accessor GlobalLetChangedToVar.Set() is a new API without '@available'
cake: Accessor fixedLayoutStruct2.BecomeFixedBinaryOrder.Modify() is a new API without '@available'
cake: Accessor fixedLayoutStruct2.BecomeFixedBinaryOrder.Set() is a new API without '@available'
cake: AssociatedType RequirementChanges.addedTypeWithDefault is a new API without '@available'
cake: AssociatedType RequirementChanges.addedTypeWithoutDefault is a new API without '@available'
cake: Class C0 is a new API without '@available'
cake: Class C8 is a new API without '@available'
cake: Constructor AddingNewDesignatedInit.init(_:) is a new API without '@available'
cake: Constructor C1.init(_:) is a new API without '@available'
cake: Constructor ClassWithMissingDesignatedInits.init() is a new API without '@available'
cake: Constructor SubclassWithMissingDesignatedInits.init() is a new API without '@available'
cake: Enum IceKind is now without @frozen
cake: EnumElement FrozenKind.AddedCase is a new API without @available attribute
cake: EnumElement FutureKind.FineToAdd is a new API without @available attribute
cake: EnumElement FrozenKind.AddedCase is a new API without '@available'
cake: EnumElement FutureKind.FineToAdd is a new API without '@available'
cake: Func C1.foo1() is now not static
cake: Func FinalFuncContainer.NewFinalFunc() is now with final
cake: Func FinalFuncContainer.NoLongerFinalFunc() is now without final
cake: Func Float.floatHigher() is a new API without @available attribute
cake: Func FutureKind.==(_:_:) is a new API without @available attribute
cake: Func FutureKind.hash(into:) is a new API without @available attribute
cake: Func Float.floatHigher() is a new API without '@available'
cake: Func FutureKind.==(_:_:) is a new API without '@available'
cake: Func FutureKind.hash(into:) is a new API without '@available'
cake: Func HasMutatingMethodClone.foo() has self access kind changing from Mutating to NonMutating
cake: Func RequirementChanges.addedFunc() is a new API without @available attribute
cake: Func RequirementChanges.addedFunc() is a new API without '@available'
cake: Func S1.foo1() has self access kind changing from NonMutating to Mutating
cake: Func S1.foo3() is now static
cake: Func _NoResilientClass.NoLongerFinalFunc() is now without final
cake: Func fixedLayoutStruct.OKChange() is a new API without @available attribute
cake: Protocol P4 is a new API without @available attribute
cake: Func fixedLayoutStruct.OKChange() is a new API without '@available'
cake: Protocol P4 is a new API without '@available'
cake: Struct C6 is now with @frozen
cake: Var C1.CIIns1 changes from weak to strong
cake: Var C1.CIIns2 changes from strong to weak
cake: Var FutureKind.hashValue is a new API without @available attribute
cake: Var RequirementChanges.addedVar is a new API without @available attribute
cake: Var fixedLayoutStruct.$__lazy_storage_$_lazy_d is a new API without @available attribute
cake: Var fixedLayoutStruct.c is a new API without @available attribute
cake: Var FutureKind.hashValue is a new API without '@available'
cake: Var RequirementChanges.addedVar is a new API without '@available'
cake: Var fixedLayoutStruct.$__lazy_storage_$_lazy_d is a new API without '@available'
cake: Var fixedLayoutStruct.c is a new API without '@available'
/* Fixed-layout Type Changes */
cake: EnumElement FrozenKind.AddedCase is added to a non-resilient type

View File

@@ -1,9 +1,9 @@
cake: Func FrozenKind.__derived_enum_equals(_:_:) has been removed
cake: Accessor GlobalLetChangedToVar.Get() is a new API without @available attribute
cake: Accessor GlobalVarChangedToLet.Get() is a new API without @available attribute
cake: Accessor GlobalVarChangedToLet.Modify() is a new API without @available attribute
cake: Accessor GlobalVarChangedToLet.Set() is a new API without @available attribute
cake: Func FrozenKind.==(_:_:) is a new API without @available attribute
cake: Accessor GlobalLetChangedToVar.Get() is a new API without '@available'
cake: Accessor GlobalVarChangedToLet.Get() is a new API without '@available'
cake: Accessor GlobalVarChangedToLet.Modify() is a new API without '@available'
cake: Accessor GlobalVarChangedToLet.Set() is a new API without '@available'
cake: Func FrozenKind.==(_:_:) is a new API without '@available'
cake: Var C1.CIIns1 is no longer a stored property
cake: Var C1.CIIns2 is no longer a stored property
cake: Var RemoveSetters.Value is no longer a stored property

View File

@@ -1 +1 @@
Enum Color is a new API without @available attribute
Enum Color is a new API without '@available'

View File

@@ -12,7 +12,7 @@
// RUN: echo "ABI breakage: func foo() has been removed" > %t/incomplete-allowlist.txt
// RUN: echo "ABI breakage: func foo() has been removed" > %t/complete-allowlist.txt
// RUN: echo "ABI breakage: func bar() is a new API without @available attribute" >> %t/complete-allowlist.txt
// RUN: echo "ABI breakage: func bar() is a new API without '@available'" >> %t/complete-allowlist.txt
// RUN: %target-swift-frontend -disable-objc-attr-requires-foundation-module -emit-module -o %t.mod1/Foo.swiftmodule %t.mod1/Foo.swift -parse-as-library -enable-library-evolution -emit-module-source-info -emit-module-source-info-path %t.mod1/Foo.swiftsourceinfo -emit-module-interface-path %t.mod1/Foo.swiftinterface -module-name Foo -swift-version 5

View File

@@ -9,5 +9,5 @@
// RUN: c-index-test -read-diagnostics %t/result.dia 2>&1 | %FileCheck %s -check-prefix CHECK-DIA
// Ensure the 'api-digester-breaking-change' category is included in the serialized diagnostics file.
// CHECK-DIA: warning: ABI breakage: enum Color is a new API without @available attribute [] [api-digester-breaking-change]
// CHECK-STDERR: warning: ABI breakage: enum Color is a new API without @available attribute
// CHECK-DIA: warning: ABI breakage: enum Color is a new API without '@available' [] [api-digester-breaking-change]
// CHECK-STDERR: warning: ABI breakage: enum Color is a new API without '@available'

View File

@@ -111,7 +111,7 @@ Func SerialExecutor.enqueue(_:) has been added as a protocol requirement
// while adding a new overload that accepts `Job` with new availability.
// The ABI checker seems to be confused by this case.
// rdar://106833284 (ABI checker confused with overload getting deprecated)
Func Executor.enqueue(_:) is a new API without @available attribute
Func Executor.enqueue(_:) is a new API without '@available'
// Adopt #isolation in TaskLocal.withValue APIs
Func TaskLocal.withValue(_:operation:file:line:) has been renamed to Func withValue(_:operation:isolation:file:line:)

View File

@@ -58,8 +58,8 @@
// Note: normally you'll need to add new entries to
// `stability-stdlib-abi-without-asserts.test`, not this file.
Func _COWChecksEnabled() is a new API without @available attribute
Func _swift_isImmutableCOWBuffer(_:) is a new API without @available attribute
Func _swift_setImmutableCOWBuffer(_:_:) is a new API without @available attribute
Func _COWChecksEnabled() is a new API without '@available'
Func _swift_isImmutableCOWBuffer(_:) is a new API without '@available'
Func _swift_setImmutableCOWBuffer(_:_:) is a new API without '@available'
// *** DO NOT DISABLE OR XFAIL THIS TEST. *** (See comment above.)

View File

@@ -58,13 +58,13 @@
// Note: normally you'll need to add new entries to
// `stability-stdlib-abi-without-asserts.test`, not this file.
Func _collectReferencesInsideObject(_:) is a new API without @available attribute
Func _loadDestroyTLSCounter() is a new API without @available attribute
Func _measureRuntimeFunctionCountersDiffs(objects:_:) is a new API without @available attribute
Protocol _RuntimeFunctionCountersStats is a new API without @available attribute
Struct _GlobalRuntimeFunctionCountersState is a new API without @available attribute
Struct _ObjectRuntimeFunctionCountersState is a new API without @available attribute
Struct _RuntimeFunctionCounters is a new API without @available attribute
Func _collectReferencesInsideObject(_:) is a new API without '@available'
Func _loadDestroyTLSCounter() is a new API without '@available'
Func _measureRuntimeFunctionCountersDiffs(objects:_:) is a new API without '@available'
Protocol _RuntimeFunctionCountersStats is a new API without '@available'
Struct _GlobalRuntimeFunctionCountersState is a new API without '@available'
Struct _ObjectRuntimeFunctionCountersState is a new API without '@available'
Struct _RuntimeFunctionCounters is a new API without '@available'
// *** DO NOT DISABLE OR XFAIL THIS TEST. *** (See comment above.)

View File

@@ -49,18 +49,18 @@
// *** DO NOT DISABLE OR XFAIL THIS TEST. *** (See comment above.)
Func _prespecialize() is a new API without @available attribute
Func _stdlib_isOSVersionAtLeastOrVariantVersionAtLeast(_:_:_:_:_:_:) is a new API without @available attribute
Func _diagnoseUnavailableCodeReached() is a new API without @available attribute
Func _prespecialize() is a new API without '@available'
Func _stdlib_isOSVersionAtLeastOrVariantVersionAtLeast(_:_:_:_:_:_:) is a new API without '@available'
Func _diagnoseUnavailableCodeReached() is a new API without '@available'
// These functions are not actually added to the ABI, but they had been a part of
// the ABI exposed by the runtime library, so this is not breakage.
// They are now referenced by @_extern(c) declarations in the standard library, but
// api-digester cannot match them with the baseline symbols in the baseline runtime
// library, which were not exposed by the baseline stdlib module.
Func _swift_retainCount(_:) is a new API without @available attribute
Func _swift_unownedRetainCount(_:) is a new API without @available attribute
Func _swift_weakRetainCount(_:) is a new API without @available attribute
Func _swift_retainCount(_:) is a new API without '@available'
Func _swift_unownedRetainCount(_:) is a new API without '@available'
Func _swift_weakRetainCount(_:) is a new API without '@available'
// And these were temporarily added as ABI in https://github.com/apple/swift/pull/69352,
// but then https://github.com/apple/swift/pull/71694 made them @_aeic before
// they shipped anywhere, but not before they got into the ABI baseline. Fun!
@@ -130,13 +130,13 @@ Func _SequenceBox._map(_:) is now without rethrows
Func UnsafeMutableRawBufferPointer.storeBytes(of:toByteOffset:as:) has been removed
Func UnsafeMutableRawPointer.storeBytes(of:toByteOffset:as:) has been removed
Func UnsafeMutableBufferPointer.assign(repeating:) has been removed
Func UnsafeMutableBufferPointer.update(repeating:) is a new API without @available attribute
Func UnsafeMutableBufferPointer.update(repeating:) is a new API without '@available'
Func UnsafeMutablePointer.assign(from:count:) has been removed
Func UnsafeMutablePointer.update(from:count:) is a new API without @available attribute
Func UnsafeMutablePointer.update(from:count:) is a new API without '@available'
Func UnsafeMutablePointer.assign(repeating:count:) has been removed
Func UnsafeMutablePointer.update(repeating:count:) is a new API without @available attribute
Func UnsafeMutablePointer.update(repeating:count:) is a new API without '@available'
Func UnsafeMutablePointer.moveAssign(from:count:) has been removed
Func UnsafeMutablePointer.moveUpdate(from:count:) is a new API without @available attribute
Func UnsafeMutablePointer.moveUpdate(from:count:) is a new API without '@available'
// These haven't actually been removed; they were renamed at the source level while
// retaining their old mangled name. The source break was accepted as part of se-0370.
@@ -146,7 +146,7 @@ Func UnsafeMutableBufferPointer.initialize(from:) has return type change from (
// This hasn't actually been removed; it was renamed at the source level while
// retaining its old mangled/silgen name. The old source-level name is preserved
// as an @_alwaysEmitIntoClient function. The source break was accepted as part of se-0405.
Constructor String.init(validatingCString:) is a new API without @available attribute
Constructor String.init(validatingCString:) is a new API without '@available'
Constructor String.init(validatingUTF8:) has been removed
// These haven't actually been removed; they are simply marked unavailable.
@@ -828,9 +828,9 @@ Struct CollectionOfOne is now with @_addressableForDependencies
Struct String.UTF8View is now with @_addressableForDependencies
Struct Substring.UTF8View is now with @_addressableForDependencies
Enum _SwiftifyInfo is a new API without @available attribute
Enum _SwiftifyExpr is a new API without @available attribute
Enum _DependenceType is a new API without @available attribute
Enum _SwiftifyInfo is a new API without '@available'
Enum _SwiftifyExpr is a new API without '@available'
Enum _DependenceType is a new API without '@available'
Protocol CodingKey has added inherited protocol SendableMetatype
Protocol Error has added inherited protocol SendableMetatype