Merge pull request #83040 from augusto2112/sub-remote-addr

[NFC][RemoteInspection] Subtracting remote addresses should return int
This commit is contained in:
Augusto Noronha
2025-07-24 14:32:27 -07:00
committed by GitHub
2 changed files with 5 additions and 5 deletions

View File

@@ -117,10 +117,10 @@ public:
return RemoteAddress(Data - rhs, getAddressSpace());
}
RemoteAddress operator-(const RemoteAddress &rhs) const {
if (AddressSpace != rhs.AddressSpace)
return RemoteAddress();
return RemoteAddress(Data - rhs.Data, getAddressSpace());
uint64_t operator-(const RemoteAddress &rhs) const {
assert(AddressSpace == rhs.AddressSpace &&
"Comparing remote addresses of different address spaces");
return Data - rhs.Data;
}
template <typename IntegerType>

View File

@@ -77,7 +77,7 @@ public:
RemoteRef<U> getRemoteRef(remote::RemoteAddress remoteAddr) const {
assert(containsRemoteAddress(remoteAddr, sizeof(U)));
auto localAddr = (uint64_t)(uintptr_t)Start.getLocalBuffer() +
(remoteAddr - Start.getRemoteAddress()).getRawAddress();
(remoteAddr - Start.getRemoteAddress());
return RemoteRef<U>(remoteAddr, (const U *)localAddr);
}