averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-14 20:36:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

[NFC] Migrate remnant Jira issue references to GitHub issues

Browse Source
This commit is contained in:
Anthony Latsis
2022-12-02 05:30:54 +03:00
parent cef0158a15
commit 4cb63c8a0f
24 changed files with 45 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
CMakeLists.txt
View File

@@ -1171,7 +1171,7 @@ endif()
# declares the swift-stdlib-* set of targets. These targets will then
# implicitly depend on any targets declared with IS_STDLIB.
#
# https://bugs.swift.org/browse/SR-5975
# https://github.com/apple/swift/issues/48534
if(SWIFT_BUILD_STDLIB)
add_subdirectory(stdlib)
else()
@@ -1211,7 +1211,7 @@ if(SWIFT_INCLUDE_TOOLS)
# Always include this after including stdlib/!
# Refer to the large comment above the add_subdirectory(stdlib) call.
# https://bugs.swift.org/browse/SR-5975
# https://github.com/apple/swift/issues/48534
add_subdirectory(tools)
# Localization targets are configured in a way that assume the swift

8
benchmark/single-source/BufferFill.swift
View File

@@ -55,7 +55,7 @@ public func bufferFillFromSliceTeardown() {
public func bufferFillFromSliceExecute(n: Int) {
// Measure performance when filling an UnsafeBuffer from a Slice
// of a Collection that supports `withContiguousStorageIfAvailable`
// See: https://bugs.swift.org/browse/SR-14491
// See: https://github.com/apple/swift/issues/56846
for _ in 0..<n {
let slice = Slice(base: a, bounds: a.indices)
@@ -87,7 +87,7 @@ public func rawBufferCopyBytesTeardown() {
public func rawBufferCopyBytesExecute(n: Int) {
// Measure performance when copying bytes into an UnsafeRawBuffer
// from a Collection that supports `withContiguousStorageIfAvailable`
// See: https://bugs.swift.org/browse/SR-14886
// See: https://github.com/apple/swift/issues/57233
for _ in 0..<n {
rb.copyBytes(from: ra)
@@ -112,7 +112,7 @@ public func rawBufferInitializeMemoryTeardown() {
public func rawBufferInitializeMemoryExecute(n: Int) {
// Measure performance when initializing an UnsafeRawBuffer
// from a Collection that supports `withContiguousStorageIfAvailable`
// See: https://bugs.swift.org/browse/SR-14982
// See: https://github.com/apple/swift/issues/57324
for _ in 0..<n {
var (iterator, initialized) = rb.initializeMemory(as: Int.self, from: a)
@@ -154,7 +154,7 @@ public func rawBufferCopyContentsTeardown() {
public func rawBufferCopyContentsExecute(n: Int) {
// Measure performance of copying bytes from an
// `UnsafeRawBufferPointer` to an `UnsafeMutableBufferPointer<UInt8>`.
// See: https://bugs.swift.org/browse/SR-9604
// See: https://github.com/apple/swift/issues/52050
for _ in 0..<n {
var (iterator, initialized) = b8.initialize(from: r8)

2
benchmark/single-source/DictionaryCopy.swift
View File

@@ -13,7 +13,7 @@
// This benchmark checks for quadratic behavior while copying elements in hash
// order between Dictionaries of decreasing capacity
//
// https://bugs.swift.org/browse/SR-3268
// https://github.com/apple/swift/issues/45856
import TestsUtils

3
cmake/modules/Libdispatch.cmake
View File

@@ -47,7 +47,8 @@ endif()
# Build any target libdispatch if needed.
foreach(sdk ${SWIFT_SDKS})
# Darwin targets have libdispatch available, do not build it.
# Wasm/WASI doesn't support libdispatch yet. See https://bugs.swift.org/browse/SR-12097 for more details.
# Wasm/WASI doesn't support libdispatch yet.
# See https://github.com/apple/swift/issues/54533 for more details.
if(NOT "${sdk}" IN_LIST SWIFT_DARWIN_PLATFORMS AND NOT "${sdk}" STREQUAL WASI)
list(APPEND DISPATCH_SDKS "${sdk}")
endif()

2
include/swift/ABI/Metadata.h
View File

@@ -173,7 +173,7 @@ using TypeContextDescriptor = TargetTypeContextDescriptor<InProcess>;
template<template <typename Runtime> class ObjCInteropKind, unsigned PointerSize>
using ExternalTypeContextDescriptor = TargetTypeContextDescriptor<External<ObjCInteropKind<RuntimeTarget<PointerSize>>>>;
// FIXME: https://bugs.swift.org/browse/SR-1155
// FIXME: https://github.com/apple/swift/issues/43763
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Winvalid-offsetof"

2
include/swift/AST/AutoDiff.h
View File

@@ -218,7 +218,7 @@ struct AutoDiffConfig {
return AutoDiffConfig(parameterIndices, resultIndices, signature);
}
// TODO(SR-13506): Use principled mangling for AD-generated symbols.
// TODO(https://github.com/apple/swift/issues/52204): Use principled mangling for AD-generated symbols.
std::string mangle() const {
std::string result = "src_";
interleave(

2
include/swift/AST/DiagnosticsFrontend.def
View File

@@ -399,7 +399,7 @@ WARNING(warning_module_shadowing_may_break_module_interface,none,
"public %0 %1 shadows module %2, which may cause failures when "
"importing %3 or its clients in some configurations; please rename "
"either the %0 %1 or the module %2, or see "
"https://bugs.swift.org/browse/SR-14195 for workarounds",
"https://github.com/apple/swift/issues/56573 for workarounds",
(DescriptiveDeclKind, FullyQualified<Type>,
/*shadowedModule=*/ModuleDecl *, /*interfaceModule*/ModuleDecl *))
REMARK(rebuilding_module_from_interface,none,

2
include/swift/AST/DiagnosticsSema.def
View File

@@ -3529,7 +3529,7 @@ ERROR(derivative_attr_nonfinal_class_init_unsupported,none,
"making %0 final", (Type))
ERROR(derivative_attr_unsupported_accessor_kind,none,
"cannot register derivative for %0", (/*accessorKind*/ DescriptiveDeclKind))
// TODO(SR-13096): Remove this temporary diagnostic.
// TODO(https://github.com/apple/swift/issues/55542): Remove this temporary diagnostic.
ERROR(derivative_attr_class_setter_unsupported,none,
"cannot yet register derivative for class property or subscript setters",
())

3
include/swift/SILOptimizer/Differentiation/Common.h
View File

@@ -56,8 +56,7 @@ raw_ostream &getADDebugStream();
/// %index_1 = integer_literal $Builtin.Word, 1
/// %elt1 = index_addr %elt0, %index_1 // element address
/// ...
// TODO(SR-12894): Find a better name and move this general utility to
// ArraySemantic.h.
// TODO(https://github.com/apple/swift/issues/55340): Find a better name and move this general utility to ArraySemantic.h.
ApplyInst *getAllocateUninitializedArrayIntrinsicElementAddress(SILValue v);
/// Given a value, finds its single `destructure_tuple` user if the value is

4
test/AutoDiff/compiler_crashers_fixed/issue-54935-differentiable-function-extract-subst-function-type.swift
View File

@@ -4,8 +4,8 @@
// SIL verification error regarding substituted function types and
// `differentiable_function_extract` instruction. Occurs only with `-O`.
// FIXME: Disabled due to flakiness on Linux (https://github.com/apple/swift/issues/55466), likely related to TF-1197.
// REQUIRES: SR13021
// FIXME(https://github.com/apple/swift/issues/55466): Disabled due to flakiness on Linux , likely related to TF-1197.
// XFAIL: *
import _Differentiation

4
test/AutoDiff/compiler_crashers_fixed/issue-55094-noderivative-parameter-type-mangling.swift
View File

@@ -4,8 +4,8 @@
// IRGenDebugInfo type reconstruction crash because `@noDerivative` parameters
// are not mangled
// FIXME: Disabled due to flakiness on Linux (https://github.com/apple/swift/issues/55466), likely related to TF-1197.
// REQUIRES: SR13021
// FIXME(https://github.com/apple/swift/issues/55466): Disabled due to flakiness on Linux, likely related to TF-1197.
// REQUIRES: issue_55466
import _Differentiation
func id(_ x: Float, _ y: Float) -> Float { x }

4
test/AutoDiff/compiler_crashers_fixed/issue-55177-optimize-partial-apply-convention-thin-only.swift
View File

@@ -6,8 +6,8 @@
// Do not rewrite `partial_apply` to `thin_to_thick_function` if the specialized
// callee is not `@convention(thin)`.
// FIXME: Disabled due to flakiness on Linux (https://github.com/apple/swift/issues/55466), likely related to TF-1197.
// REQUIRES: SR13021
// FIXME(https://github.com/apple/swift/issues/55466): Disabled due to flakiness on Linux, likely related to TF-1197.
// REQUIRES: issue_55466
import DifferentiationUnittest

4
test/AutoDiff/compiler_crashers_fixed/issue-55333-55334-vjp-emitter-definite-initialization.swift
View File

@@ -11,8 +11,8 @@
// Debug scope error for pullback struct `struct` instruction generated
// by `VJPEmitter`
// FIXME: Disabled due to flakiness on Linux (https://github.com/apple/swift/issues/55466), likely related to TF-1197.
// REQUIRES: SR13021
// FIXME(https://github.com/apple/swift/issues/55466): Disabled due to flakiness on Linux, likely related to TF-1197.
// XFAIL: *
import _Differentiation

5
test/AutoDiff/compiler_crashers_fixed/tf1232-autodiff-generated-declaration-mangling.swift
View File

@@ -1,6 +1,7 @@
// RUN: %target-build-swift -g %s
// FIXME: This test occasionally fails to link (https://github.com/apple/swift/issues/57125).
// REQUIRES: SR14775
// FIXME(https://github.com/apple/swift/issues/57125): This test occasionally fails to link.
// REQUIRES: issue_57125
// TF-1232: IRGenDebugInfo crash due to lack of proper mangling for
// AutoDiff-generated declarations: linear map structs and branching trace

3
test/ClangImporter/MixedSource/import-mixed-with-header.swift
View File

@@ -12,7 +12,8 @@
// RUN: rm -rf %t/mixed-target/
// RUN: %target-swift-frontend(mock-sdk: %clang-importer-sdk-nosource -I %t) -I %S/../Inputs/custom-modules -enable-objc-interop -typecheck %s -verify
// REQUIRES: SR7768
// FIXME: Disabled due to https://github.com/apple/swift/issues/50307.
// REQUIRES: issue_50307
import MixedWithHeader

4
test/Driver/loaded_module_trace_swiftinterface.swift
View File

@@ -1,5 +1,7 @@
// UNSUPPORTED: OS=windows-msvc
// REQUIRES: SR13034
// FIXME: Disabled due to https://github.com/apple/swift/issues/55480.
// REQUIRES: issue_55480
// 1) If there is no swiftmodule, use the swiftinterface
//

2
test/IDE/complete_in_closures.swift
View File

@@ -104,7 +104,7 @@ struct NestedStructWithClosureMember1 {
struct StructWithClosureMemberAndLocal {
var c = {
var x = 0
#^DELAYED_10?check=WITH_GLOBAL_DECLS_AND_LOCAL1;xfail=sr16012^#
#^DELAYED_10?check=WITH_GLOBAL_DECLS_AND_LOCAL1;xfail=https://github.com/apple/swift/issues/58273^#
}
}

5
test/IRGen/empty_array.sil
View File

@@ -8,9 +8,8 @@
// REQUIRES: CODEGENERATOR=X86
// REQUIRES: CODEGENERATOR=ARM
// FIXME: https://github.com/apple/swift/issues/46187 test is failing after
// being unintentionally disabled for a while.
// REQUIRES: SR3602
// FIXME(https://github.com/apple/swift/issues/46187): test is failing after being unintentionally disabled for a while.
// XFAIL: *
sil_stage canonical

4
test/Interop/Cxx/templates/swift-class-instantiation-in-namespace-module-interface.swift
View File

@@ -2,8 +2,8 @@
// RUN: %target-swiftxx-frontend -emit-module -o %t/SwiftClassTemplateInNamespaceModule.swiftmodule %S/Inputs/SwiftClassTemplateInNamespaceModule.swift -I %S/Inputs -enable-library-evolution -swift-version 5
// RUN: %target-swift-ide-test -print-module -module-to-print=SwiftClassTemplateInNamespaceModule -I %t/ -source-filename=x -enable-experimental-cxx-interop | %FileCheck %s
// The following bug needs to be resolved so decls in __ObjC don't disappear.
// REQUIRES: SR-14211
// FIXME(https://github.com/apple/swift/issues/56589): The following bug needs to be resolved so decls in __ObjC don't disappear.
// XFAIL: *
// CHECK: import ClassTemplateInNamespaceForSwiftModule
// CHECK: func receiveShip(_ i: inout Space.__CxxTemplateInstN5Space4ShipIbEE)

3
test/Interop/Cxx/templates/swift-class-instantiation-nested-type-module-interface.swift
View File

@@ -2,7 +2,8 @@
// RUN: %target-swiftxx-frontend -emit-module -o %t/SwiftClassTemplateNestedTypeModule.swiftmodule %S/Inputs/SwiftClassTemplateNestedTypeModule.swift -I %S/Inputs -enable-library-evolution -swift-version 5
// RUN: %target-swift-ide-test -print-module -module-to-print=SwiftClassTemplateNestedTypeModule -I %t/ -source-filename=x -enable-experimental-cxx-interop | %FileCheck %s
// REQUIRES: SR-13261
// FIXME: Disabled due to https://github.com/apple/swift/issues/55701.
// XFAIL: *
// CHECK: import ClassTemplateNestedTypeForSwiftModule
// CHECK: func receiveShipEngine(_ i: inout Space.__CxxTemplateInstN5Space4ShipIbEE)

6
test/ModuleInterface/module_shadowing.swift
View File

@@ -27,14 +27,14 @@
#if !SELF_SHADOW
import ShadowyHorror
// OTHER-DAG: ShadowyHorror.module_shadowing:{{[0-9]+:[0-9]+}}: warning: public class 'ShadowyHorror.module_shadowing' shadows module 'module_shadowing', which may cause failures when importing 'module_shadowing' or its clients in some configurations; please rename either the class 'ShadowyHorror.module_shadowing' or the module 'module_shadowing', or see https://bugs.swift.org/browse/SR-14195 for workarounds{{$}}
// OTHER-DAG: ShadowyHorror.module_shadowing:{{[0-9]+:[0-9]+}}: warning: public class 'ShadowyHorror.module_shadowing' shadows module 'module_shadowing', which may cause failures when importing 'module_shadowing' or its clients in some configurations; please rename either the class 'ShadowyHorror.module_shadowing' or the module 'module_shadowing', or see https://github.com/apple/swift/issues/56573 for workarounds{{$}}
@_implementationOnly import TestModule
#endif
public struct ShadowyHorror {
// OTHER-DAG: module_shadowing.swift:[[@LINE-1]]:15: warning: public struct 'module_shadowing.ShadowyHorror' shadows module 'ShadowyHorror', which may cause failures when importing 'module_shadowing' or its clients in some configurations; please rename either the struct 'module_shadowing.ShadowyHorror' or the module 'ShadowyHorror', or see https://bugs.swift.org/browse/SR-14195 for workarounds{{$}}
// SELF: module_shadowing.swift:[[@LINE-2]]:15: warning: public struct 'ShadowyHorror.ShadowyHorror' shadows module 'ShadowyHorror', which may cause failures when importing 'ShadowyHorror' or its clients in some configurations; please rename either the struct 'ShadowyHorror.ShadowyHorror' or the module 'ShadowyHorror', or see https://bugs.swift.org/browse/SR-14195 for workarounds{{$}}
// OTHER-DAG: module_shadowing.swift:[[@LINE-1]]:15: warning: public struct 'module_shadowing.ShadowyHorror' shadows module 'ShadowyHorror', which may cause failures when importing 'module_shadowing' or its clients in some configurations; please rename either the struct 'module_shadowing.ShadowyHorror' or the module 'ShadowyHorror', or see https://github.com/apple/swift/issues/56573 for workarounds{{$}}
// SELF: module_shadowing.swift:[[@LINE-2]]:15: warning: public struct 'ShadowyHorror.ShadowyHorror' shadows module 'ShadowyHorror', which may cause failures when importing 'ShadowyHorror' or its clients in some configurations; please rename either the struct 'ShadowyHorror.ShadowyHorror' or the module 'ShadowyHorror', or see https://github.com/apple/swift/issues/56573 for workarounds{{$}}
init() {}
public var property: ShadowyHorror { ShadowyHorror() }

2
test/SymbolGraph/Module/DocAttrExportedImport.swift
View File

@@ -24,7 +24,7 @@
// INTERNAL-DAG: "precise":"s:1B9StructOneV"
// FIXME: Symbols from `@_exported import` do not get emitted when using swift-symbolgraph-extract
// This is tracked by https://bugs.swift.org/browse/SR-15921.
// This is tracked by https://github.com/apple/swift-docc/issues/179.
// FILES-NOT: DocAttrExportedImport@A.symbols.json

2
userdocs/diagnostics/multiple-inheritance.md
View File

@@ -32,6 +32,6 @@ struct Ladle: ServingUtensil, Spoon { /* ... */ }
Swift protocols can declare interfaces that must be implemented by each conforming type (like abstract class members in other programming languages such as C# or Java), and they can also provide overridable default implementations for those requirements in protocol extensions.
When class inheritance and protocol conformances are used together, subclasses inherit protocol conformances from base classes, introducing additional complexity. For example, the default implementation of a protocol requirement not overridden in the conforming base class also cannot be overridden in any subclass ([SR-103](https://bugs.swift.org/browse/SR-103)).
When class inheritance and protocol conformances are used together, subclasses inherit protocol conformances from base classes, introducing additional complexity. For example, the default implementation of a protocol requirement not overridden in the conforming base class also cannot be overridden in any subclass ([#42725](https://github.com/apple/swift/issues/42725)).
To learn more about defining and adopting protocols, see the [Protocols](https://docs.swift.org/swift-book/LanguageGuide/Protocols.html) section in _The Swift Programming Language_. To learn more about class inheritance, see the [Inheritance](https://docs.swift.org/swift-book/LanguageGuide/Inheritance.html) section in _The Swift Programming Language_.

6
utils/build-script-impl
View File

@@ -407,7 +407,7 @@ function is_swift_lto_enabled() {
#
# This is part of refactoring more work to be done or controllable via
# `build-script` itself. For additional information, see:
# https://bugs.swift.org/browse/SR-237
# https://github.com/apple/swift/issues/42859
#
# To use this functionality, the script is invoked with:
# ONLY_EXECUTE=<action name>
@@ -1039,7 +1039,7 @@ fi
# FIXME: HOST_CC and CMAKE are set, and their presence is validated by,
# utils/build-script. These checks are redundant, but must remain until
# build-script-impl is merged completely with utils/build-script.
# For additional information, see: https://bugs.swift.org/browse/SR-237
# For additional information, see: https://github.com/apple/swift/issues/42859
if [ -z "${HOST_CC}" ] ; then
echo "Can't find clang. Please install clang-3.5 or a later version."
exit 1
@@ -1252,7 +1252,7 @@ PRODUCTS=(llvm)
# Get the value of a host-specific variable expected to have been passed by the
# `build-script`.
#
# This is a total hack, and is part of the SR-237 migration.
# This is a total hack, and is part of the https://github.com/apple/swift/issues/42859 migration.
function get_host_specific_variable() {
local host="$1"
local name="$2"