averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-14 20:36:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

Frontend: Migrate several options to no longer be ignored in swiftinterfaces.

Browse Source 
Frontend options should only be printed under `swift-module-flags-ignored:`
temporarily to prevent condfails for older development compilers that are still
in use (as a rule of thumb, swiftinterfaces should be compatible with compilers
that are up to 6 months old). None of the frontend flags that are currently
categorized as "ignorable" need to be ignorable anymore.
This commit is contained in:
Allan Shortlidge
2023-08-16 20:56:00 -07:00
parent 774ba28606
commit 5c762b1435
4 changed files with 10 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
include/swift/Option/Options.td
View File

@@ -532,7 +532,7 @@ def package_name : Separate<["-"], "package-name">,
Flags<[FrontendOption, ModuleInterfaceOptionIgnorablePrivate]>,
HelpText<"Name of the package the module belongs to">;
def export_as : Separate<["-"], "export-as">,
Flags<[FrontendOption, ModuleInterfaceOptionIgnorable]>,
Flags<[FrontendOption, ModuleInterfaceOption]>,
HelpText<"Module name to use when referenced in clients module interfaces">;
def emit_module : Flag<["-"], "emit-module">,
@@ -762,7 +762,7 @@ def disable_actor_data_race_checks :
HelpText<"Disable runtime checks for actor data races">;
def enable_bare_slash_regex : Flag<["-"], "enable-bare-slash-regex">,
Flags<[FrontendOption, ModuleInterfaceOptionIgnorable]>,
Flags<[FrontendOption, ModuleInterfaceOption]>,
HelpText<"Enable the use of forward slash regular-expression literal syntax">;
def warn_implicit_overrides :
@@ -794,11 +794,11 @@ def strict_concurrency : Joined<["-"], "strict-concurrency=">,
def enable_experimental_feature :
Separate<["-"], "enable-experimental-feature">,
Flags<[FrontendOption, ModuleInterfaceOptionIgnorable]>,
Flags<[FrontendOption, ModuleInterfaceOption]>,
HelpText<"Enable an experimental feature">;
def enable_upcoming_feature : Separate<["-"], "enable-upcoming-feature">,
Flags<[FrontendOption, ModuleInterfaceOptionIgnorable]>,
Flags<[FrontendOption, ModuleInterfaceOption]>,
HelpText<"Enable a feature that will be introduced in an upcoming language "
"version">;
@@ -1286,7 +1286,7 @@ def explain_module_dependency : Separate<["-"], "explain-module-dependency">,
HelpText<"Emit remark/notes describing why compilaiton may depend on a module with a given name.">;
def min_inlining_target_version : Separate<["-"], "target-min-inlining-version">,
Flags<[FrontendOption, ModuleInterfaceOptionIgnorable]>,
Flags<[FrontendOption, ModuleInterfaceOption]>,
HelpText<"Require inlinable code with no '@available' attribute to back-deploy "
"to this version of the '-target' OS">;
@@ -1405,12 +1405,12 @@ def working_directory_EQ : Joined<["-"], "working-directory=">,
Alias<working_directory>;
def user_module_version : Separate<["-"], "user-module-version">,
Flags<[FrontendOption, ModuleInterfaceOptionIgnorable, NewDriverOnlyOption]>,
Flags<[FrontendOption, ModuleInterfaceOption, NewDriverOnlyOption]>,
HelpText<"Module version specified from Swift module authors">,
MetaVarName<"<vers>">;
def allowable_client : Separate<["-"], "allowable-client">,
Flags<[FrontendOption, ModuleInterfaceOptionIgnorable, NewDriverOnlyOption]>,
Flags<[FrontendOption, ModuleInterfaceOption, NewDriverOnlyOption]>,
HelpText<"Module names that are allowed to import this module">,
MetaVarName<"<vers>">;
// VFS

2
test/ModuleInterface/allowable-client.swift
View File

@@ -7,7 +7,7 @@
// RUN: %FileCheck %s --check-prefix=INTERFACE-FLAG < %t/textual/Foo.swiftinterface
// INTERFACE-FLAG: swift-module-flags-ignorable:
// INTERFACE-FLAG: swift-module-flags:
// INTERFACE-FLAG: -allowable-client FooFriend1 -allowable-client FooFriend2 -allowable-client FooFriend3

2
test/ModuleInterface/option-filtering.swift
View File

@@ -5,7 +5,7 @@
//
// CHECK-SWIFTINTERFACE-NOT: -enable-experimental-feature LayoutStringValueWitnesses
// CHECK-SWIFTINTERFACE-NOT: -enable-experimental-feature LayoutStringValueWitnessesInstantiation
// CHECK-SWIFTINTERFACE: swift-module-flags-ignorable:
// CHECK-SWIFTINTERFACE: swift-module-flags:
// CHECK-SWIFTINTERFACE-SAME: -enable-experimental-feature MoveOnlyClasses
// CHECK-SWIFTINTERFACE-SAME: -enable-experimental-feature NoImplicitCopy

3
test/ModuleInterface/option-preservation.swift
View File

@@ -5,11 +5,10 @@
//
// CHECK-SWIFTINTERFACE: swift-module-flags:
// CHECK-SWIFTINTERFACE-SAME: -enable-library-evolution
// CHECK-SWIFTINTERFACE-SAME: -target-min-inlining-version 42
// CHECK-SWIFTINTERFACE-SAME: -Onone
// CHECK-SWIFTINTERFACE-SAME: -enforce-exclusivity=unchecked
// CHECK-SWIFTINTERFACE-SAME: -autolink-force-load
// CHECK-SWIFTINTERFACE: swift-module-flags-ignorable:
// CHECK-SWIFTINTERFACE-SAME: -target-min-inlining-version 42
// CHECK-SWIFTINTERFACE-SAME: -enable-bare-slash-regex
// Make sure flags show up when filelists are enabled