averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-14 20:36:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

Frontend: Reinstate suppression of warnings during interface type-checking.

Browse Source 
We're not ready to start emitting warnings when type-checking modules from
interface. It is causing performance regressions and spurious diagnostics to be
emitted.

Reverts a small part of https://github.com/swiftlang/swift/pull/80360.

Resolves rdar://148257136.
This commit is contained in:
Allan Shortlidge
2025-03-31 10:21:00 -07:00
parent 3b18849dcc
commit 645628f3e4
2 changed files with 6 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
lib/Frontend/ModuleInterfaceLoader.cpp
View File

@@ -1741,13 +1741,11 @@ void InterfaceSubContextDelegateImpl::inheritOptionsForBuildingInterface(
genericSubInvocation.setRuntimeResourcePath(SearchPathOpts.RuntimeResourcePath);
}
// Inhibit warnings from the genericSubInvocation since we are assuming the user
// is not in a position to address them. (Unless we're verifying, in which
// case they might.)
if (requestedAction != FrontendOptions::ActionType::Typecheck) {
genericSubInvocation.getDiagnosticOptions().SuppressWarnings = true;
GenericArgs.push_back("-suppress-warnings");
}
// Inhibit warnings from the genericSubInvocation since we are assuming the
// user is not in a position to address them.
genericSubInvocation.getDiagnosticOptions().SuppressWarnings = true;
GenericArgs.push_back("-suppress-warnings");
// Inherit the parent invocation's setting on whether to suppress remarks
if (suppressRemarks) {
genericSubInvocation.getDiagnosticOptions().SuppressRemarks = true;

2
test/ModuleInterface/has_storage_attr_bad.swiftinterface
View File

@@ -5,5 +5,5 @@
// REQUIRES: OS=macosx
extension Array {
@_hasStorage public var foo: Int { get set } // expected-warning {{'@_hasStorage' attribute cannot be applied to declaration in extension}}
@_hasStorage public var foo: Int { get set }
}