averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-14 20:36:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #79512 from DougGregor/unsafe-storage-checking-generic

Browse Source 
Fix declaration context for unsafe storage checking
This commit is contained in:
Doug Gregor
2025-02-20 02:21:30 -10:00
committed by GitHub
parent 052958eea9 c308cfd26a
commit 6e4f711a55
2 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/Sema/TypeCheckUnsafe.cpp
View File

@@ -443,7 +443,7 @@ void swift::checkUnsafeStorage(NominalTypeDecl *nominal) {
// Look for any unsafe storage in this nominal type.
SmallVector<UnsafeUse, 4> unsafeUses;
UnsafeStorageVisitor(ctx, unsafeUses).visit(nominal, nominal->getDeclContext());
UnsafeStorageVisitor(ctx, unsafeUses).visit(nominal, nominal);
// If we didn't find any unsafe storage, there's nothing to do.
if (unsafeUses.empty())

8
test/Unsafe/unsafe.swift
View File

@@ -191,3 +191,11 @@ class ClassWithUnsafeStorage {
var int: Int = 0
var array: [UnsafeSuper]? = nil // expected-note{{property 'array' involves unsafe type 'UnsafeSuper'}}
}
// expected-warning@+3{{generic struct 'GenericStructWithUnsafeThings' has storage involving unsafe types}}
// expected-note@+2{{add '@unsafe' if this type is also unsafe to use}}
// expected-note@+1{{add '@safe' if this type encapsulates the unsafe storage in a safe interface}}
struct GenericStructWithUnsafeThings<T> {
var property: T
var pointer: PointerType // expected-note{{property 'pointer' involves unsafe type 'PointerType'}}
}