averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-14 20:36:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

[CSOptimizer] Adjust scoreCandidateMatch to indicate when match cannot be decided

Browse Source 
It is not always possible to match candidate types against corresponding
parameter types for certain overloads i.e. when parameter is an associated type.

`scoreCandidateMatch` needs to be able to indicate that to the caller
to allow it to move to the next parameter (if any) without failing the
overload choice when the match cannot be established.
This commit is contained in:
Pavel Yaskevich
2024-10-08 21:25:37 +09:00
parent 6caf1ccbb2
commit 9b62c84a4f
1 changed files with 29 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
lib/Sema/CSOptimizer.cpp
View File

@@ -450,10 +450,16 @@ static Constraint *determineBestChoicesInContext(
// - Array-to-pointer conversion
// - Value to existential conversion
// - Exact match on top-level types
std::function<double(GenericSignature, Type, Type, MatchOptions)>
scoreCandidateMatch = [&](GenericSignature genericSig,
Type candidateType, Type paramType,
MatchOptions options) -> double {
//
// In situations when it's not possible to determine whether a candidate
// type matches a parameter type (i.e. when partially resolved generic
// types are matched) this function is going to produce \c std::nullopt
// instead of `0` that indicates "not a match".
std::function<std::optional<double>(GenericSignature, Type, Type,
MatchOptions)>
scoreCandidateMatch =
[&](GenericSignature genericSig, Type candidateType, Type paramType,
MatchOptions options) -> std::optional<double> {
auto areEqual = [&options](Type a, Type b) {
// Double<->CGFloat implicit conversion support for literals
// only since in this case the conversion might not result in
@@ -527,10 +533,12 @@ static Constraint *determineBestChoicesInContext(
// Check protocol requirement(s) if this parameter is a
// generic parameter type.
if (genericSig && paramType->is<GenericTypeParamType>()) {
// If candidate is not fully resolved, check conformances only
// and lower the score.
if (candidateType->hasTypeVariable()) {
if (genericSig && paramType->isTypeParameter()) {
// If candidate is not fully resolved or is matched against a
// dependent member type (i.e. `Self.T`), let's check conformances
// only and lower the score.
if (candidateType->hasTypeVariable() ||
paramType->is<DependentMemberType>()) {
auto protocolRequirements =
genericSig->getRequiredProtocols(paramType);
if (llvm::all_of(protocolRequirements, [&](ProtocolDecl *protocol) {
@@ -547,6 +555,10 @@ static Constraint *determineBestChoicesInContext(
return 0;
}
// Cannot match anything but generic type parameters here.
if (!paramType->is<GenericTypeParamType>())
return std::nullopt;
// If the candidate type is fully resolved, let's check all of
// the requirements that are associated with the corresponding
// parameter, if all of them are satisfied this candidate is
@@ -718,10 +730,15 @@ static Constraint *determineBestChoicesInContext(
if (favorExactMatchesOnly)
options |= MatchFlag::ExactOnly;
auto score = scoreCandidateMatch(genericSig, candidateType,
paramType, options);
if (score > 0) {
bestCandidateScore = std::max(bestCandidateScore, score);
auto candidateScore = scoreCandidateMatch(
genericSig, candidateType, paramType, options);
if (!candidateScore)
continue;
if (candidateScore > 0) {
bestCandidateScore =
std::max(bestCandidateScore, candidateScore.value());
continue;
}