averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-14 20:36:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

Serialization: Indicate application extension mode via XCC (#76285)

Browse Source 
This fixes the debugger's ability to perform expression evaluation when debugging an 
executable that was built with both under the following circumstances:

1. explicit module build
2. `-application-extension`

The fix is to include `-fapplication-extension` as an XCC field in the swiftmodule. 
This primes the debugger's ClangImporter with the correct flag needed to load the 
explicitly built pcm files generated at build time.
This commit is contained in:
Dave Lee
2024-09-06 15:19:34 -07:00
committed by GitHub
parent 5f851b664d
commit d04cfeb44d
2 changed files with 13 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
lib/Frontend/Frontend.cpp
View File

@@ -238,6 +238,9 @@ SerializationOptions CompilerInvocation::computeSerializationOptions(
serializationOpts.ExtraClangOptions.push_back("--target=" +
LangOpts.ClangTarget->str());
}
if (LangOpts.EnableAppExtensionRestrictions) {
serializationOpts.ExtraClangOptions.push_back("-fapplication-extension");
}
serializationOpts.PluginSearchOptions =
getSearchPathOptions().PluginSearchOpts;

10
test/Serialization/application-extension.swift Normal file
View File

@@ -0,0 +1,10 @@
// RUN: %empty-directory(%t)
// RUN: %target-swift-frontend -emit-module -module-name AppExtSafe -emit-module-path %t/AppExtSafe.swiftmodule -parse-as-library -serialize-debugging-options -application-extension %s
// Check the serialized flags paths.
// RUN: llvm-bcanalyzer -dump %t/AppExtSafe.swiftmodule > %t/AppExtSafe.swiftmodule.txt
// RUN: %FileCheck %s < %t/AppExtSafe.swiftmodule.txt
// CHECK-LABEL: <OPTIONS_BLOCK
// CHECK: <XCC abbrevid={{[0-9]+}}/> blob data = '-fapplication-extension'
// CHECK: </OPTIONS_BLOCK>