averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-14 20:36:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

Update benchmark test script to correctly verify the --min-samples=2 default command-line arg

Browse Source
This commit is contained in:
Tim Kientzle
2023-09-25 11:57:34 -07:00
parent 7052de9399
commit e3e72fc21c
1 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
benchmark/scripts/test_Benchmark_Driver.py
View File

@@ -329,7 +329,7 @@ class TestBenchmarkDriverRunningTests(unittest.TestCase):
def test_run_benchmark_with_multiple_samples(self):
self.driver.run("b1")
self.subprocess_mock.assert_called_with(
("/benchmarks/Benchmark_O-*", "b1")
("/benchmarks/Benchmark_O-*", "b1", "--min-samples=2")
)
self.driver.run("b2", num_samples=5)
self.subprocess_mock.assert_called_with(
@@ -339,19 +339,19 @@ class TestBenchmarkDriverRunningTests(unittest.TestCase):
def test_run_benchmark_with_specified_number_of_iterations(self):
self.driver.run("b", num_iters=1)
self.subprocess_mock.assert_called_with(
("/benchmarks/Benchmark_O-*", "b", "--num-iters=1")
("/benchmarks/Benchmark_O-*", "b", "--min-samples=2", "--num-iters=1")
)
def test_run_benchmark_for_specified_time(self):
self.driver.run("b", sample_time=0.5)
self.subprocess_mock.assert_called_with(
("/benchmarks/Benchmark_O-*", "b", "--sample-time=0.5")
("/benchmarks/Benchmark_O-*", "b", "--min-samples=2", "--sample-time=0.5")
)
def test_run_benchmark_in_verbose_mode(self):
self.driver.run("b", verbose=True)
self.subprocess_mock.assert_called_with(
("/benchmarks/Benchmark_O-*", "b", "--verbose")
("/benchmarks/Benchmark_O-*", "b", "--min-samples=2", "--verbose")
)
def test_run_batch(self):
@@ -363,7 +363,7 @@ class TestBenchmarkDriverRunningTests(unittest.TestCase):
self.driver.tests = ["b1", "bx"]
self.driver.run()
self.subprocess_mock.assert_called_with(
("/benchmarks/Benchmark_O-*", "1", "bx")
("/benchmarks/Benchmark_O-*", "1", "bx", "--min-samples=2")
)
def test_parse_results_from_running_benchmarks(self):
@@ -382,7 +382,7 @@ class TestBenchmarkDriverRunningTests(unittest.TestCase):
def test_measure_memory(self):
self.driver.run("b", measure_memory=True)
self.subprocess_mock.assert_called_with(
("/benchmarks/Benchmark_O-*", "b", "--memory")
("/benchmarks/Benchmark_O-*", "b", "--min-samples=2", "--memory")
)
def test_run_benchmark_independent_samples(self):
@@ -394,6 +394,7 @@ class TestBenchmarkDriverRunningTests(unittest.TestCase):
(
"/benchmarks/Benchmark_O-*",
"b1",
"--min-samples=2",
"--num-iters=1",
"--memory",
)