averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-14 20:36:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

Sema: Don't diagnose isolated deinit availability in skipped function bodies.

Browse Source 
As a follow-up fix for https://github.com/swiftlang/swift/pull/83545, avoid
incorrectly diagnosing isolated deinit availability during module emission
jobs, which skip type checking non-inlinable function bodies and therefore
don't build accurate availability scopes for those bodies. It's ok to skip
these diagnostics during module emission since they should still be emitted
during compilation jobs.

Resolves rdar://161178785.
This commit is contained in:
Allan Shortlidge
2025-09-23 10:10:47 -07:00
parent b250ef7be3
commit ec0f3e36f5
2 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
lib/Sema/TypeCheckAttr.cpp
View File

@@ -135,6 +135,12 @@ public:
}
if (!getActorIsolation(nominal).isMainActor() && destructor->hasBody()) {
// In module emission jobs, type checking the body of the destructor may
// be skipped which means availability in the body cannot be diagnosed
// accurately.
if (destructor->isBodySkipped())
return;
TypeChecker::checkAvailability(
destructor->getBodySourceRange(), C.getIsolatedDeinitAvailability(),
D->getDeclContext(),

5
test/Concurrency/deinit_isolation_availability.swift
View File

@@ -2,6 +2,11 @@
// RUN: %target-typecheck-verify-swift -swift-version 5 %s -strict-concurrency=complete -target %target-swift-6.1-abi-triple
// RUN: %target-typecheck-verify-swift -swift-version 5 %s -strict-concurrency=complete -target %target-swift-6.1-abi-triple -target-min-inlining-version min -verify-additional-prefix inlining-
// Test -emit-module configurations.
// RUN: %target-swift-frontend -emit-module -verify -swift-version 5 %s -strict-concurrency=complete -target %target-swift-5.1-abi-triple -experimental-skip-non-inlinable-function-bodies -verify-additional-prefix inlining-
// RUN: %target-swift-frontend -emit-module -verify -swift-version 5 %s -strict-concurrency=complete -target %target-swift-6.1-abi-triple -experimental-skip-non-inlinable-function-bodies -target-min-inlining-version min -verify-additional-prefix inlining-
// REQUIRES: concurrency
// REQUIRES: OS=macosx