averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

[mandatory-inlining] Fix up comments as requested by ArnoldS.

Browse Source
This commit is contained in:
Michael Gottesman
2019-01-27 12:40:07 -08:00
parent 6275b10a15
commit ec19f85b08
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
lib/SILOptimizer/Mandatory/MandatoryInlining.cpp
View File

@@ -90,9 +90,6 @@ static void fixupReferenceCounts(
auto errorBehavior =
ownership::ErrorBehaviorKind::ReturnFalseOnLeakAssertOtherwise;
// Ok, at this point we know that we have a direct SSA relationship in between
// our partial_apply and
// Add a copy of each non-address type capture argument to lifetime extend the
// captured argument over at least the inlined function and till the end of a
// box if we have an address. This deals with the possibility of the closure
@@ -183,8 +180,11 @@ static void fixupReferenceCounts(
break;
}
// If we have an owned value, we need to insert a copy here for lifetime
// extension purposes.
// If we have an owned value, we insert a copy here for two reasons:
//
// 1. To balance the consuming argument.
// 2. To lifetime extend the value over the call site in case our partial
// apply has another use that would destroy our value first.
case ParameterConvention::Direct_Owned: {
v = SILBuilderWithScope(pai).emitCopyValueOperation(loc, v);