averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity
187,431 Commits 623 Branches 2,949 Tags
constraintResolutionFix
Commit Graph

7859 Commits

Author SHA1 Message Date
Maxim Moiseev
9d8755511d fixing validation tests 2015-12-17 16:26:43 -08:00
Dmitri Gribenko
15a9649062 Repeated(repeating:length:) => repeatElement(_:count:) 2015-12-17 16:24:47 -08:00
Dmitri Gribenko
86f1258810 Repeat => Repeated 2015-12-17 16:24:11 -08:00
Mishal Shah
56275ecafc [SR-295] Disabled 029-swift-decl-walk test due to failure 2015-12-17 16:22:33 -08:00
Dmitri Gribenko
73ce9ae7e9 Collection.count => .length 
And other API changes that naturally fall out from this, like
Array(repeating:count:) => Array(repeating:length:).
 2015-12-17 15:55:29 -08:00
Doug Gregor
824088a07d Merge remote-tracking branch 'origin/master' into swift-3-api-guidelines 2015-12-17 15:50:24 -08:00
practicalswift
65e7ee6080 [SIL] Add test case for crash triggered in swift::performNameBinding(swift::SourceFile&, unsigned int) 
Stack trace:

```
sil-opt: /path/to/swift/lib/Sema/NameBinding.cpp:196: void (anonymous namespace)::NameBinder::addImport(SmallVectorImpl<std::pair<ImportedModule, ImportOptions> > &, swift::ImportDecl *): Assertion `topLevelModule && "top-level module missing"' failed.
8  sil-opt         0x0000000000a5ae29 swift::performNameBinding(swift::SourceFile&, unsigned int) + 6969
9  sil-opt         0x0000000000a63a37 swift::performTypeChecking(swift::SourceFile&, swift::TopLevelContext&, swift::OptionSet<swift::TypeCheckingFlags, unsigned int>, unsigned int) + 55
10 sil-opt         0x0000000000738af2 swift::CompilerInstance::performSema() + 2946
11 sil-opt         0x000000000072373c main + 1916
Stack dump:
0.	Program arguments: sil-opt -enable-sil-verify-all
```
 2015-12-17 23:15:35 +01:00
Dmitri Gribenko
e31aae83ae Remove 'REQUIRES: asserts' from fixed crash tests: they don't crash anymore in any configuration 2015-12-17 14:54:32 -07:00
Dmitri Gribenko
1d5c9b153b Annotate SIL crash tests for the --no-assertions build 2015-12-17 14:53:55 -07:00
Max Moiseev
9f0993449a fixing tests after merge 2015-12-17 13:36:26 -08:00
Dmitri Gribenko
488acb7d67 Annotate new tests for the --no-assertions build 2015-12-17 13:09:25 -07:00
Doug Gregor
f245f18a09 Merge remote-tracking branch 'origin/swift-3-api-guidelines' into swift-3-omit-needless-words 2015-12-17 11:35:58 -08:00
practicalswift
fb106c87f1 [SourceKit] Add test case for crash triggered in swift::Mangle::Mangler::getDeclTypeForMangling(swift::ValueDecl const*, llvm::ArrayRef<swift::GenericTypeParamType*>&, unsigned int&, llvm::ArrayRef<swift::Requirement>&, llvm::SmallVectorImpl<swift::Requirement>&) 
Stack trace:

```
found code completion token A at offset 143
4  swift-ide-test  0x0000000000b5efd9 swift::Mangle::Mangler::getDeclTypeForMangling(swift::ValueDecl const*, llvm::ArrayRef<swift::GenericTypeParamType*>&, unsigned int&, llvm::ArrayRef<swift::Requirement>&, llvm::SmallVectorImpl<swift::Requirement>&) + 665
5  swift-ide-test  0x0000000000b5ebc4 swift::Mangle::Mangler::mangleDeclType(swift::ValueDecl const*, swift::ResilienceExpansion, unsigned int) + 116
6  swift-ide-test  0x0000000000b5bda1 swift::Mangle::Mangler::mangleEntity(swift::ValueDecl const*, swift::ResilienceExpansion, unsigned int) + 417
7  swift-ide-test  0x0000000000b5b8d0 swift::Mangle::Mangler::mangleNominalType(swift::NominalTypeDecl const*, swift::ResilienceExpansion, swift::Mangle::Mangler::BindGenerics, swift::CanGenericSignature, swift::GenericParamList const*) + 256
8  swift-ide-test  0x0000000000b9a322 swift::ide::printDeclUSR(swift::ValueDecl const*, llvm::raw_ostream&) + 722
10 swift-ide-test  0x0000000000773808 copyAssociatedUSRs(llvm::BumpPtrAllocatorImpl<llvm::MallocAllocator, 4096ul, 4096ul>&, swift::Decl const*) + 104
11 swift-ide-test  0x0000000000773f88 swift::ide::CodeCompletionResultBuilder::takeResult() + 1624
15 swift-ide-test  0x0000000000b5619b swift::lookupVisibleDecls(swift::VisibleDeclConsumer&, swift::DeclContext const*, swift::LazyResolver*, bool, swift::SourceLoc) + 555
22 swift-ide-test  0x0000000000ae0b44 swift::Decl::walk(swift::ASTWalker&) + 20
23 swift-ide-test  0x0000000000b6a7ce swift::SourceFile::walk(swift::ASTWalker&) + 174
24 swift-ide-test  0x0000000000b699ff swift::ModuleDecl::walk(swift::ASTWalker&) + 79
25 swift-ide-test  0x0000000000b43b62 swift::DeclContext::walkContext(swift::ASTWalker&) + 146
26 swift-ide-test  0x000000000085ca3d swift::performDelayedParsing(swift::DeclContext*, swift::PersistentParserState&, swift::CodeCompletionCallbacksFactory*) + 61
27 swift-ide-test  0x000000000076b914 swift::CompilerInstance::performSema() + 3316
28 swift-ide-test  0x00000000007150b7 main + 33239
Stack dump:
0.	Program arguments: swift-ide-test -code-completion -code-completion-token=A -source-filename=<INPUT-FILE>
1.	While walking into decl 'a' at <INPUT-FILE>:2:1
```
 2015-12-17 20:11:35 +01:00
practicalswift
a95646680d [SIL] Add test case for crash triggered in swift::Parser::parseSILVTable() 
Stack trace:

```
sil-opt: /path/to/swift/lib/Parse/ParseSIL.cpp:790: llvm::PointerUnion<ValueDecl *, Module *> lookupTopDecl(swift::Parser &, swift::Identifier): Assertion `DeclLookup.isSuccess() && DeclLookup.Results.size() == 1' failed.
9  sil-opt         0x0000000000a24740 swift::Parser::parseSILVTable() + 640
10 sil-opt         0x00000000009f38d3 swift::Parser::parseTopLevel() + 707
11 sil-opt         0x00000000009eecbb swift::parseIntoSourceFile(swift::SourceFile&, unsigned int, bool*, swift::SILParserState*, swift::PersistentParserState*, swift::DelayedParsingCallbacks*) + 107
12 sil-opt         0x0000000000738ad6 swift::CompilerInstance::performSema() + 2918
13 sil-opt         0x000000000072373c main + 1916
Stack dump:
0.	Program arguments: sil-opt -enable-sil-verify-all
1.	With parser at source location: <stdin>:2:13
```
 2015-12-17 20:07:37 +01:00
Max Moiseev
3fe0c60d7f Merge remote-tracking branch 'origin/master' into swift-3-api-guidelines 2015-12-17 11:00:02 -08:00
Max Moiseev
a28a510407 Fixing tests 2015-12-17 10:24:40 -08:00
Jacob Bandes-Storch
ac95c1318f More error checking for member type lookup 2015-12-17 01:50:53 -08:00
Jacob Bandes-Storch
37207165f0 More error checking for subscript decls 2015-12-17 00:40:01 -08:00
Maxim Moiseev
fc65e676cd fixing validation tests 2015-12-16 17:21:57 -08:00
Maxim Moiseev
c4763ae686 _debugPrecondition => _debugRequire 2015-12-16 17:20:40 -08:00
Maxim Moiseev
e6468a0eca _precondition => _require 2015-12-16 17:19:01 -08:00
Maxim Moiseev
f2f50d6a9d precondition => require 2015-12-16 17:16:08 -08:00
Maxim Moiseev
6c50752aed UnsafePointer: initializeMemory and deinitializePointee 2015-12-16 17:11:57 -08:00
Maxim Moiseev
0e54467bfa Final bulk removal of Type suffix 2015-12-16 17:06:19 -08:00
Mark Lacey
931966ad42 Move a no-longer-crashing swift-ide-test over. 2015-12-16 16:49:44 -08:00
Maxim Moiseev
ca932fca5a CVarArgType => CVarArg 2015-12-16 15:52:01 -08:00
Dmitri Gribenko
3d0ad16094 Unsafe[Mutable]Pointer.memory => .pointee 2015-12-16 15:50:31 -08:00
Dmitri Gribenko
f1dbe205a3 UnsafeMutablePointer.dealloc(_:) => .deallocateCapacity(_:) 2015-12-16 15:47:58 -08:00
Dmitri Gribenko
1f70e25899 UnsafeMutablePointer.alloc(_:) => UnsafeMutablePointer(allocatingCapacity:) 2015-12-16 15:45:48 -08:00
Dmitri Gribenko
339c7a99dc Remove no-argument initializers from unsafe pointer types 
The preferred way to create a nil pointer is to use the 'nil' literal.

Affected types:
AutoreleasingUnsafeMutablePointer
OpaquePointer
UnsafeMutablePointer
UnsafePointer
 2015-12-16 14:59:50 -08:00
Max Moiseev
2cb497f9a6 XFAILing and IDE crasher due to missing free map 2015-12-16 14:37:36 -08:00
practicalswift
1875e57551 Add crash case (see #587) for fixed bug to crashers_fixed/ 2015-12-16 22:30:58 +01:00
Arsen Gasparyan
9f728c6dbd [stdlib] Make comparison operator choices consistent 2015-12-16 22:50:36 +03:00
Slava Pestov
d6ea5d8717 Sema: Chain all generic parameter lists 
Previously, methods on DeclContext for getting generic parameters
and signatures did not walk up from type contexts to function
contexts, or function contexts to function contexts.

Presumably this is because SIL doesn't completely support nested
generics yet, instead only handling these two special cases:

- non-generic local function inside generic function
- generic method inside generic type

For local functions nested inside generic functions, SIL expects
the closure to not have an interface type or generic signature,
even if the contextual type signature contains archetypes.
This should probably be revisited some day.

Recall that these cases are explicitly rejected by Sema diagnostics
because they lack SIL support:

- generic function inside generic function
- generic type inside generic function

After the previous patches in this series, it becomes possible to
construct types that are the same as before for the supported uses of
nested generics, while introducing a more self-consistent conceptual
model for the unsupported cases.

Some new tests show we generate diagnotics in various cases that
used to crash.

The conceptual model might still not be completely right, and of
course SIL, IRGen and runtime support is still missing.
 2015-12-16 11:32:56 -08:00
Mishal Shah
bced0a6881 Revert "[SourceKit] Add test case for crash triggered in swift::ArchetypeBuilder::PotentialArchetype::getRepresentative()" 2015-12-16 10:29:56 -08:00
Ben Langmuir
0136804892 Merge pull request #488 from practicalswift/sourcekit-004-swift-typebase-getmembersubstitutions 
[SourceKit] Add test case for crash triggered in swift::TypeBase::getMemberSubstitutions(…)
 2015-12-16 09:31:43 -08:00
practicalswift
83181f5c02 [SourceKit] Add test case for crash triggered in swift::TypeBase::getMemberSubstitutions(swift::DeclContext*) 
Stack trace:

```
found code completion token A at offset 143
swift-ide-test: /path/to/swift/lib/AST/Type.cpp:2492: TypeSubstitutionMap swift::TypeBase::getMemberSubstitutions(swift::DeclContext *): Assertion `baseTy && "Couldn't find appropriate context"' failed.
8  swift-ide-test  0x0000000000b957c0 swift::TypeBase::getMemberSubstitutions(swift::DeclContext*) + 432
9  swift-ide-test  0x0000000000b95abd swift::TypeBase::getTypeOfMember(swift::ModuleDecl*, swift::Type, swift::DeclContext*) + 61
10 swift-ide-test  0x000000000098363b swift::TypeChecker::resolveTypeInContext(swift::TypeDecl*, swift::DeclContext*, swift::OptionSet<swift::TypeResolutionFlags, unsigned int>, bool, swift::GenericTypeResolver*, llvm::function_ref<bool (swift::TypeCheckRequest)>*) + 1435
14 swift-ide-test  0x0000000000983f0e swift::TypeChecker::resolveIdentifierType(swift::DeclContext*, swift::IdentTypeRepr*, swift::OptionSet<swift::TypeResolutionFlags, unsigned int>, bool, swift::GenericTypeResolver*, llvm::function_ref<bool (swift::TypeCheckRequest)>*) + 158
16 swift-ide-test  0x0000000000984e54 swift::TypeChecker::resolveType(swift::TypeRepr*, swift::DeclContext*, swift::OptionSet<swift::TypeResolutionFlags, unsigned int>, swift::GenericTypeResolver*, llvm::function_ref<bool (swift::TypeCheckRequest)>*) + 164
19 swift-ide-test  0x0000000000ae41e5 swift::Expr::walk(swift::ASTWalker&) + 69
20 swift-ide-test  0x00000000008ccec8 swift::constraints::ConstraintSystem::generateConstraints(swift::Expr*) + 200
21 swift-ide-test  0x0000000000916120 swift::TypeChecker::solveForExpression(swift::Expr*&, swift::DeclContext*, swift::Type, swift::FreeTypeVariableBinding, swift::ExprTypeCheckListener*, swift::constraints::ConstraintSystem&, llvm::SmallVectorImpl<swift::constraints::Solution>&, swift::OptionSet<swift::TypeCheckExprFlags, unsigned int>) + 256
22 swift-ide-test  0x000000000091c6c9 swift::TypeChecker::typeCheckExpression(swift::Expr*&, swift::DeclContext*, swift::Type, swift::ContextualTypePurpose, swift::OptionSet<swift::TypeCheckExprFlags, unsigned int>, swift::ExprTypeCheckListener*) + 569
23 swift-ide-test  0x000000000091d7e0 swift::TypeChecker::typeCheckBinding(swift::Pattern*&, swift::Expr*&, swift::DeclContext*) + 112
24 swift-ide-test  0x000000000091d989 swift::TypeChecker::typeCheckPatternBinding(swift::PatternBindingDecl*, unsigned int) + 265
31 swift-ide-test  0x0000000000936237 swift::TypeChecker::typeCheckDecl(swift::Decl*, bool) + 151
34 swift-ide-test  0x000000000097f68a swift::TypeChecker::typeCheckClosureBody(swift::ClosureExpr*) + 218
35 swift-ide-test  0x00000000009b77ec swift::constraints::ConstraintSystem::applySolution(swift::constraints::Solution&, swift::Expr*, swift::Type, bool, bool, bool) + 812
36 swift-ide-test  0x000000000091c73b swift::TypeChecker::typeCheckExpression(swift::Expr*&, swift::DeclContext*, swift::Type, swift::ContextualTypePurpose, swift::OptionSet<swift::TypeCheckExprFlags, unsigned int>, swift::ExprTypeCheckListener*) + 683
38 swift-ide-test  0x000000000097f7d6 swift::TypeChecker::typeCheckTopLevelCodeDecl(swift::TopLevelCodeDecl*) + 134
39 swift-ide-test  0x00000000009039cd swift::performTypeChecking(swift::SourceFile&, swift::TopLevelContext&, swift::OptionSet<swift::TypeCheckingFlags, unsigned int>, unsigned int) + 1405
40 swift-ide-test  0x0000000000773be2 swift::CompilerInstance::performSema() + 2946
41 swift-ide-test  0x000000000071c7c3 main + 35027
Stack dump:
0.	Program arguments: swift-ide-test -code-completion -code-completion-token=A -source-filename=<INPUT-FILE>
1.	While type-checking expression at [<INPUT-FILE>:2:1 - line:2:39] RangeText="{class d<T where g:e{class B{var b=B p"
2.	While type-checking 'd' at <INPUT-FILE>:2:2
3.	While type-checking expression at [<INPUT-FILE>:2:36 - line:2:36] RangeText="B"
4.	While resolving type B at [<INPUT-FILE>:2:36 - line:2:36] RangeText="B"
```

Mark as fixed.

Move to fixed directory.
 2015-12-16 18:22:16 +01:00
practicalswift
979c466a41 [SourceKit] Add test case for crash triggered in swift::SpecializedProtocolConformance::getTypeWitnessSubstAndDecl(swift::AssociatedTypeDecl*, swift::LazyResolver*) const 
Stack trace:

```
found code completion token A at offset 148
swift-ide-test: /path/to/swift/lib/AST/Type.cpp:2187: TypeSubstitutionMap swift::GenericParamList::getSubstitutionMap(ArrayRef<swift::Substitution>) const: Assertion `Subs.empty() && "did not use all substitutions?!"' failed.
9  swift-ide-test  0x0000000000b86948 swift::SpecializedProtocolConformance::getTypeWitnessSubstAndDecl(swift::AssociatedTypeDecl*, swift::LazyResolver*) const + 248
10 swift-ide-test  0x0000000000b86632 swift::ProtocolConformance::getTypeWitnessSubstAndDecl(swift::AssociatedTypeDecl*, swift::LazyResolver*) const + 18
11 swift-ide-test  0x0000000000b86de6 swift::ProtocolConformance::getTypeWitness(swift::AssociatedTypeDecl*, swift::LazyResolver*) const + 6
14 swift-ide-test  0x0000000000b9630c swift::Type::transform(std::function<swift::Type (swift::Type)> const&) const + 44
15 swift-ide-test  0x0000000000b8f8af swift::Type::subst(swift::ModuleDecl*, llvm::DenseMap<swift::TypeBase*, swift::Type, llvm::DenseMapInfo<swift::TypeBase*>, llvm::detail::DenseMapPair<swift::TypeBase*, swift::Type> >&, swift::OptionSet<swift::SubstFlags, unsigned int>) const + 111
16 swift-ide-test  0x0000000000b6b907 swift::BoundGenericType::getSubstitutions(swift::ModuleDecl*, swift::LazyResolver*, swift::DeclContext*) + 1911
17 swift-ide-test  0x0000000000b8ef93 swift::TypeBase::gatherAllSubstitutions(swift::ModuleDecl*, llvm::SmallVectorImpl<swift::Substitution>&, swift::LazyResolver*, swift::DeclContext*) + 211
18 swift-ide-test  0x0000000000b6c31e swift::ModuleDecl::lookupConformance(swift::Type, swift::ProtocolDecl*, swift::LazyResolver*) + 1246
19 swift-ide-test  0x0000000000964450 swift::TypeChecker::conformsToProtocol(swift::Type, swift::ProtocolDecl*, swift::DeclContext*, swift::OptionSet<swift::ConformanceCheckFlags, unsigned int>, swift::ProtocolConformance**, swift::SourceLoc) + 96
20 swift-ide-test  0x00000000008e1b7b swift::constraints::ConstraintSystem::simplifyConformsToConstraint(swift::Type, swift::ProtocolDecl*, swift::constraints::ConstraintKind, swift::constraints::ConstraintLocatorBuilder, unsigned int) + 123
21 swift-ide-test  0x00000000008e4956 swift::constraints::ConstraintSystem::simplifyConformsToConstraint(swift::Type, swift::Type, swift::constraints::ConstraintKind, swift::constraints::ConstraintLocatorBuilder, unsigned int) + 118
22 swift-ide-test  0x00000000008e901e swift::constraints::ConstraintSystem::simplifyConstraint(swift::constraints::Constraint const&) + 142
23 swift-ide-test  0x00000000008ee2d9 swift::constraints::ConstraintSystem::simplify(bool) + 105
24 swift-ide-test  0x00000000008f16a0 swift::constraints::ConstraintSystem::solveRec(llvm::SmallVectorImpl<swift::constraints::Solution>&, swift::FreeTypeVariableBinding) + 48
25 swift-ide-test  0x00000000008f1569 swift::constraints::ConstraintSystem::solve(llvm::SmallVectorImpl<swift::constraints::Solution>&, swift::FreeTypeVariableBinding) + 73
26 swift-ide-test  0x00000000008f149b swift::constraints::ConstraintSystem::solveSingle(swift::FreeTypeVariableBinding) + 59
31 swift-ide-test  0x000000000096510b swift::TypeChecker::checkConformance(swift::NormalProtocolConformance*) + 2059
39 swift-ide-test  0x0000000000938837 swift::TypeChecker::typeCheckDecl(swift::Decl*, bool) + 151
40 swift-ide-test  0x0000000000905f8a swift::performTypeChecking(swift::SourceFile&, swift::TopLevelContext&, swift::OptionSet<swift::TypeCheckingFlags, unsigned int>, unsigned int) + 1434
41 swift-ide-test  0x0000000000774222 swift::CompilerInstance::performSema() + 2946
42 swift-ide-test  0x000000000071ccc3 main + 35011
Stack dump:
0.	Program arguments: swift-ide-test -code-completion -code-completion-token=A -source-filename=<INPUT-FILE>
1.	While type-checking 'A' at <INPUT-FILE>:2:1
```
 2015-12-16 18:06:52 +01:00
Ben Langmuir
fd64b0365d Merge pull request #596 from practicalswift/sourcekit-033-swift-identifier-isoperatorslow 
[SourceKit] Add test case for crash triggered in swift::Identifier::isOperatorSlow()
 2015-12-16 08:58:04 -08:00
Ben Langmuir
5f1fba07e9 Merge pull request #595 from practicalswift/sourcekit-030-swift-mangle-mangler-mangledecltype 
[SourceKit] Add test case for crash triggered in swift::Mangle::Mangler::mangleDeclType(…)
 2015-12-16 08:57:43 -08:00
Ben Langmuir
6987c4e0f2 Merge pull request #594 from practicalswift/sourcekit-032-swift-expr-propagatelvalueaccesskind 
[SourceKit] Add test case for crash triggered in swift::Expr::propagateLValueAccessKind(…)
 2015-12-16 08:57:30 -08:00
Ben Langmuir
30bba1b758 Merge pull request #593 from practicalswift/sourcekit-031-swift-mangle-mangler-manglenominaltype 
[SourceKit] Add test case for crash triggered in swift::Mangle::Mangler::mangleNominalType(…)
 2015-12-16 08:57:19 -08:00
Ben Langmuir
79938a2ef7 Merge pull request #592 from practicalswift/sourcekit-029-swift-decl-walk 
[SourceKit] Add test case for crash triggered in swift::Decl::walk(…)
 2015-12-16 08:57:08 -08:00
Ben Langmuir
6de093219f Merge pull request #591 from practicalswift/sourcekit-028-swift-typechecker-validategenericsignature 
[SourceKit] Add test case for crash triggered in swift::TypeChecker::validateGenericSignature(…)
 2015-12-16 08:56:58 -08:00
Ben Langmuir
9d2b799677 Merge pull request #590 from practicalswift/sourcekit-027-swift-typebase-getdesugaredtype 
[SourceKit] Add test case for crash triggered in swift::TypeBase::getDesugaredType()
 2015-12-16 08:56:02 -08:00
Ben Langmuir
111c75cf69 Merge pull request #589 from practicalswift/sourcekit-023-swift-archetypebuilder-addgenericparameter 
[SourceKit] Add test case for crash triggered in swift::ArchetypeBuilder::addGenericParameter(…)
 2015-12-16 08:55:50 -08:00
Ben Langmuir
3df5f9ea40 Merge pull request #588 from practicalswift/sourcekit-022-swift-typechecker-applygenericarguments 
[SourceKit] Add test case for crash triggered in swift::TypeChecker::applyGenericArguments(…)
 2015-12-16 08:55:39 -08:00
Ben Langmuir
bb633572bd Merge pull request #587 from practicalswift/sourcekit-024-swift-archetypebuilder-potentialarchetype-getrepresentative 
[SourceKit] Add test case for crash triggered in swift::ArchetypeBuilder::PotentialArchetype::getRepresentative()
 2015-12-16 08:55:28 -08:00
Ben Langmuir
173907117a Merge pull request #586 from practicalswift/sourcekit-025-swift-mangle-mangler-bindgenericparameters 
[SourceKit] Add test case for crash triggered in swift::Mangle::Mangler::bindGenericParameters(…)
 2015-12-16 08:55:14 -08:00
Ben Langmuir
2e5dc82716 Merge pull request #585 from practicalswift/sourcekit-026-swift-mangle-mangler-mangletype 
[SourceKit] Add test case for crash triggered in swift::Mangle::Mangler::mangleType(…)
 2015-12-16 08:54:59 -08:00