7 Commits

Author	SHA1	Message	Date
John McCall	7815892a76	Add unique typo corrections to the main diagnostic with a fix-it. ... Continue to emit notes for the candidates, but use different text. Note that we can emit a typo correction fix-it even if there are multiple candidates with the same name. Also, disable typo correction in the migrator, since the operation is quite expensive, the notes are never presented to the user, and the fix-its can interfere with the migrator's own edits. Our general guidance is that fix-its should be added on the main diagnostic only when the fix-it is highly likely to be correct. The exact threshold is debateable. Typo correction is certainly capable of making mistakes, but most of its edits are right, and when it's wrong it's usually obviously wrong. On balance, I think this is the right thing to do. For what it's worth, it's also what we do in Clang.	2018-04-07 16:01:39 -04:00
Dmitri Gribenko	486cab447d	tests: replace 'rm -rf %t && mkdir -p %t' with '%empty-directory(%t)' ... These changes were made using a script.	2017-06-04 11:08:39 -07:00
David Farler	b7d17b25ba	Rename -parse flag to -typecheck ... A parse-only option is needed for parse performance tracking and the current option also includes semantic analysis.	2016-11-28 10:50:55 -08:00
Dmitri Gribenko	55864d10cb	Tests: use 'mkdir -p'	2016-09-02 21:36:45 -07:00
Dmitri Gribenko	d175b3b66d	Migrate FileCheck to %FileCheck in tests	2016-08-10 23:52:02 -07:00
John McCall	3fc2291733	Add basic typo correction for unqualified lookup. ... There's a lot of room for better QoI / performance here.	2016-05-20 11:04:58 -07:00
Jordan Rose	4cdac3fc4c	Don't add variables declared in 'guard let' to a SourceFile's Decls. ... These variables really are local variables -- they have have a TopLevelCodeDecl as their DeclContext rather than the SourceFile. Treating them as global variables caused crashes in serialization. We need an overhaul of top-level variables in script files anyway (see rdar://problem/20992489&21628526), but this fixes the immediate issue. rdar://problem/21928533 Swift SVN r30519	2015-07-23 00:55:36 +00:00