Commit Graph

3 Commits

Author SHA1 Message Date
Slava Pestov
31ab93b82c Remove Swift 3-specific tests 2018-07-02 21:14:22 -07:00
Jordan Rose
2b1f7657d4 Also check for open static and 'open'-in-'final'-class
Like the change for `open let`, this is only a warning in Swift 4
mode, because it didn't actually cause any harm in practice. Neither a
Swift developer nor a compiler developer wants to rely on that going
forward, though!
2018-04-19 13:16:36 -07:00
Jordan Rose
6a080d8c5c Disallow 'open let'
...and add a verifier check to make sure we don't mix 'open' and
'final' in the future.

You could /write/ 'open let' in Swift 4.1, but you couldn't actually
override such a property (within the module or outside). To maintain
source compatibility, this is just going to emit a warning before
Swift 5 (instead of an error), since it wasn't harming anything in
practice.
2018-04-18 16:48:10 -07:00