5 Commits

Author	SHA1	Message	Date
Pavel Yaskevich	2b11ecbec9	[CSBindings] Limit BindingSet::isViable binding skipping to stdlib collection types ... This is follow-up to https://github.com/swiftlang/swift/pull/76487 It's reasonable to coalesce bindings of different kind if they don't allow implicit conversions like stdlib collection types do. Resolves: https://github.com/swiftlang/swift/issues/77003	2024-10-21 14:48:45 -07:00
Pavel Yaskevich	2c9d05991f	[CSBindings] Prevent BindingSet::isViable from dropping viable bindings ... I think the original idea was to elide `Array<$T>` if there is a binding a resolved generic arguments i.e. `Array<Float>`, but the check doesn't account for the fact that bindings could be of different kinds and there are some implicit conversions that could be missed if we remove the bindings. For example, given the following constraints: `Array<$T0> conv $T1` `$T1 conv Array<(String, Int)>` `$T0` can be a supertype of `Array<$T0>` and subtype of `Array<(String, Int)>`. The solver should accept both types as viable bindings because the `$T0` could be bound to `(key: String, value: Int)` and that would match `Array<(String, Int)>` conversion.	2024-09-16 09:54:12 -07:00
Holly Borla	0708e0efd4	Revert "Tests: Disable failing SwiftUI validation tests"	2022-11-15 09:10:23 -08:00
Allan Shortlidge	b2421aa463	Tests: Disable failing SwiftUI validation tests until rdar://102298208 is fixed.	2022-11-13 16:56:20 -08:00
Pavel Yaskevich	8ab37ca449	[Diagnostics] Diagnose type with mismatching generic arguments in ternary expr ... Fixes a missing diagnostic related to types with mismatched generic arguments in one of both ternary branches. Resolves: rdar://98862079	2022-10-27 15:56:50 -07:00