Commit Graph

4049 Commits

Author SHA1 Message Date
danra
21f21e395b isInvalid methods DRY 2016-03-24 16:32:02 +02:00
danra
5f5786a725 Remove extra spaces in empty-body ctors
Currently some empty-body ctors in the file have a space, some don't. Canonized it.
2016-03-24 16:27:13 +02:00
danra
87fcb1bbb3 operator!= DRY 2016-03-24 16:18:35 +02:00
danra
b494ff93d0 Remove superfluous semicolon in comment (NFC) 2016-03-24 13:34:56 +02:00
danra
4f209a4098 Make nodeToString brief comment clearer (NFC)
IIUC this transforms a node representation of a demangled name to the equivalent string representation. It creates the string itself, and doesn't get the string as a parameter to write into. To me "transform in" was confusing, I think the natural language to use is "transform to".
2016-03-24 12:36:06 +02:00
rjmccall
ea0d95ba5d Merge pull request #1808 from danra/patch-18
static_assert that ClusteredBitVector::ChunkType is unsigned instead of just commenting as much.
2016-03-24 00:28:07 -07:00
John McCall
abba7f0c8b Revert "Only use metadata patterns for generic types; perform other"
This reverts commit 41efb3d4d3.
LLDB has too many tendrils into our metadata.
2016-03-23 20:26:43 -07:00
Chris Lattner
c153c3ab7d Merge pull request #1810 from danra/patch-20
[gardening] Improved comments (NFC)
2016-03-23 17:41:36 -07:00
Chris Lattner
9070697cce Merge pull request #1813 from danra/patch-22
Remove redundant parentheses (NFC)
2016-03-23 17:39:48 -07:00
danra
0623e12452 Add missing commas to multi-line enums
Some of the multi-line enums in the file currently have trailing commas after the last defined value, some don't.
2016-03-24 02:14:17 +02:00
John McCall
41efb3d4d3 Only use metadata patterns for generic types; perform other
initialization in-place on demand.  Initialize parent metadata
references correctly on struct and enum metadata.

Also includes several minor improvements related to relative
pointers that I was using before deciding to simply switch the
parent reference to an absolute reference to get better access
patterns.
2016-03-23 17:04:04 -07:00
Michael Ilseman
47e73ad4f1 Merge branch 'master' of github.com:apple/swift into import-as-member 2016-03-23 17:01:47 -07:00
danra
891dea4f70 Fix comment typo (NFC) 2016-03-24 00:45:02 +02:00
danra
fec14bfb9f Remove redundant parentheses (NFC) 2016-03-23 23:58:08 +02:00
danra
3ba34602e2 move copy-append before move-append overload
This is consistent with the usual convention of having copy methods before move methods (which is also used in this file in previous methods).
2016-03-23 23:54:57 +02:00
danra
7988864ab1 [gardening] Improved comments (NFC) 2016-03-23 23:39:37 +02:00
danra
98776388d4 Compact getCapacityInBits implementation (NFC) 2016-03-23 22:50:34 +02:00
danra
8134bfd55d static_assert ChunkType is unsigned 2016-03-23 22:26:16 +02:00
Michael Ilseman
d7581d1b36 Merge commit 'a31edf53d0580efe47f4e9ef89dccc4429c056e8' into import-as-member 2016-03-23 13:05:57 -07:00
Dan Raviv
29d76f3b68 Canonize swift header files headers and footers
- Added missing ifdef guard in PointerIntEnum header
- Consistent naming convention for ifdef guards
- Consistent 'end namespace swift'
- Consistent single EOL at end of header files
2016-03-23 09:04:12 +02:00
Doug Gregor
593932741c Remove historical flags -enable-omit-needless-words/-enable-infer-default-arguments/-enable-swift-name-lookup-tables.
NFC; all of these options are always-on now and we no longer have a
way to turn them off.
2016-03-22 17:04:19 -07:00
Michael Gottesman
f79a741a7d Merge pull request #1779 from danra/patch-5
Minor comment fixes
2016-03-22 14:38:13 -07:00
Chris Lattner
74c7d4164c Merge pull request #1794 from danra/patch-16
[gardening] Minor comment fix
2016-03-22 14:18:38 -07:00
Chris Lattner
09fb7226d7 Merge pull request #1793 from danra/patch-15
Add missing comment after .h file #endif
2016-03-22 14:18:10 -07:00
Chris Lattner
0ac95f1ae0 Merge pull request #1784 from danra/patch-10
Added missing 'const' to iterator comp. operators
2016-03-22 14:14:22 -07:00
danra
f63f165b54 [gardening] Minor comment fix 2016-03-22 23:09:06 +02:00
Dan Raviv
24113705fe [gardening] Minor comment fixes 2016-03-22 23:06:33 +02:00
danra
5eed1f748b Add missing comment after .h file #endif 2016-03-22 22:59:57 +02:00
Michael Gottesman
b094e776b5 Merge pull request #1785 from danra/patch-11
[gardening] Add missing comments
2016-03-22 13:44:24 -07:00
danra
890ff9c9c8 [gardening] Fix comments style 2016-03-22 22:39:30 +02:00
danra
f1e68696c9 Add missing comment after .h file #endif 2016-03-22 22:37:30 +02:00
danra
8aa1260622 Improve template typenames consistency
Rename BlotMapVector's template typenames: MapTy -> MapT and VectorTy -> VectorT. This is consistent both with BlotMapVector's other template typename KeyT and ValueT, and with SmallBlotMapVector's MapT and VectorT template typenames.
2016-03-22 22:26:34 +02:00
danra
d6bb90253c [gardening] Add missing comments 2016-03-22 22:17:19 +02:00
danra
9b258949b3 Added missing 'const' to iterator comp. operators 2016-03-22 22:04:23 +02:00
Dmitri Gribenko
60925272b2 Merge pull request #1781 from danra/patch-7
Add missing comment after .h file #endif
2016-03-22 12:51:38 -07:00
danra
473e97504b [gardening] Add missing comments 2016-03-22 21:45:11 +02:00
danra
dac7347dfa Add missing comment after .h file #endif 2016-03-22 21:41:21 +02:00
Chris Willmore
4cc75187c6 [Sema] Flag -disable-infer-iuos: don't infer IUO type for untyped bindings
If this option is enabled, when generating potential bindings for a type
variable, don't propagate IUO type. Instead try the optional type and
the underlying type. This way, untyped bindings will not be given IUO
type when they are initialized with exprs of IUO type.
2016-03-21 17:33:29 -07:00
Michael Gottesman
0e2dc7a930 [arc] Once we have finished an iteration of ARC, clear the ImmutablePointerSetFactory.
Previously due to the way that ARC works, it was impossible to trigger any
memory safety issues. That being said the fact that the memory safety here is
non-obvious suggests that the right thing to do is just bite the bullet and
clear the ImmutablePointerSetFactory.
2016-03-10 18:48:03 -08:00
Max Moiseev
02006f20bc Merge remote-tracking branch 'origin/master' into swift-3-api-guidelines 2016-03-09 16:05:03 -08:00
Michael Ilseman
32faa62502 [Import as member] Lower case initialisms 2016-03-09 14:26:43 -08:00
Michael Gottesman
ef6ff01fd8 Use perfect forwarding on the Predicate passed into none_of/count_if.
This ensures that if one wishes to pass an std::moved, std::function into the
functions, one can do that.
2016-03-08 15:07:27 -08:00
Michael Gottesman
5f72810ad3 Add a range adaptor for std::count and update various trivial usages in the compiler to use this API instead. 2016-03-08 14:58:13 -08:00
Michael Gottesman
0612d886e9 Add a "hasEmptyIntersection" method to ImmutablePointerSet.
We do this by doing a traversal of our sorted lists in a similar manner as one
would when one is merging two such sets, i.e. one has two iterators and always
advances the iterator that has a value that is less than the other. If we ever
hit a situation where the two iterators equal, we must have a non-empty
intersection.

A unittest that exercises very basic functionality is provided as well.
2016-03-08 14:05:10 -08:00
Michael Gottesman
6f64082bc5 Clean up count_if/none in STLExtras.
Specifically this change:

1. Changed the input collection to be a const T & instead of T.
2. The return type of count_if is now properly the difference_type of the input range's iterators.
2016-03-08 14:00:24 -08:00
Michael Ilseman
1b83dee698 [Clang importer] Inferr import as member flags
Plumbing for -enable-infer-import-as-member options and flags.Tests
coming soon.
2016-03-06 23:54:56 -08:00
Michael Ilseman
d38f190acb [Clang importer] Basic import-as-member inference system
Introduces import-as-member (IAM) inferene system, to automatically
infer details that would otherwise have to be manually specified with
the swift_name attribute.

Basic functionality present, though there are some issues with
properties at the moment. No hooks, options, or tests yet, stay tuned.
2016-03-06 23:54:56 -08:00
Max Moiseev
cf4bafe9e3 Merge remote-tracking branch 'origin/master' into swift-3-api-guidelines 2016-03-03 13:22:03 -08:00
David Farler
e958f99acf Revert "Mangle declared interface type into NominalTypeDescriptor's Name"
This reverts commit 2262bd579a.

This information isn't necessary for field descriptor lookup,
after all. It's only the fields that need to have generic information,
which is already in the field descriptor.
2016-03-03 12:55:35 -08:00
David Farler
2262bd579a Mangle declared interface type into NominalTypeDescriptor's Name
Previously, the mangling didn't include generics, but these are
needed to key off of the new field descriptor metadata, as well
as to construct type references for the nominal type.
2016-03-03 12:14:38 -08:00