Commit Graph

31 Commits

Author SHA1 Message Date
Saleem Abdulrasool
ec3e0eab85 test: adjust test for ce6ae0b2a26b1ec2f770b2b9474cc4486d60c586
clang will no longer emit the `"frame-pointer"="none"` in IR to reduce
the IR traffic.  Adjust expectations accordingly.
2023-09-15 11:13:49 -07:00
Arnold Schwaighofer
65a08466fd Fix c_globals.swift test on arm64
This test sets -mno-omit-leaf-frame-pointer
2020-06-10 06:45:23 -07:00
Saleem Abdulrasool
14dd90953b test: repair the test after accidental merge without testing 2020-06-03 12:12:50 -07:00
Arnold Schwaighofer
11bc7d1e15 This test would fail on arm64(e) because we omit frame pointers there
rdar://63673682
2020-05-27 07:41:40 -07:00
John McCall
4f54c75dc8 Use Clang's logic for adding the default IR attributes to a function.
A lot of attributes are essentially default target configuration, and we should only differ when there's a good reason to.

For the attributes we were already setting:
- the ptrauth and target CPU/feature attributes are taken care of by Clang
- I've updated the optsize/minsize attributes to the apparent intent
- I've left the frame-pointer override in place for now

Fixes rdar://63289339, which was caused by Swift's ptrauth IR attributes getting out of sync with Clang's.
2020-05-21 02:24:20 -04:00
Kuba (Brecka) Mracek
c728d7a4d2 Fix failing IRGen arm64e tests (#30296) 2020-03-10 11:22:54 -07:00
Puyan Lotfi
aba0787c40 Fixing up IRGen tests that use attribute no-frame-pointer-elim.
Changes I made to swift (PR #26263) for llvm cfe r366645 have caused
these tests to fail because the string attributes have changes. This
patch fixes them to use the new frame pointer elision attributes.

# Conflicts:
#	test/IRGen/generic_metatypes.swift
2019-08-20 17:44:19 -07:00
Erik Eckstein
39bb14b094 change mangling prefix from $S to $s
This is the final ABI mangling prefix

rdar://problem/38471478
2018-09-19 13:55:11 -07:00
Saleem Abdulrasool
c0de9acdaa test: enable more IRGen tests on Windows
This set of tests also pass on Windows now.  These are mostly invocation
adjustments or renaming/reordering that is needed.
2018-06-07 10:45:35 -07:00
Erik Eckstein
cd3d50a5d9 ABI: Change the mangling prefix from _T0 to $S 2018-01-06 13:55:59 -08:00
Slava Pestov
94ce4c2ac3 SIL: Only give closures shared linkage if they're going to be serialized
Otherwise, we don't want them to be linkonce_odr at the LLVM level
to avoid unnecessary link-time overhead.
2017-03-31 20:26:27 -07:00
Erik Eckstein
c4a11f4c92 tests: remove the now unused option -new-mangling-for-tests 2017-03-22 11:28:43 -07:00
Arnold Schwaighofer
39fa2f0228 Use the swift calling convention for swift functions
Use the generic type lowering algorithm described in
"docs/CallingConvention.rst#physical-lowering" to map from IRGen's explosion
type to the type expected by the ABI.

Change IRGen to use the swift calling convention (swiftcc) for native swift
functions.

Use the 'swiftself' attribute on self parameters and for closures contexts.

Use the 'swifterror' parameter for swift error parameters.

Change functions in the runtime that are called as native swift functions to use
the swift calling convention.

rdar://19978563
2017-02-14 12:17:57 -08:00
Erik Eckstein
1d3724666f tests: convert about 400 tests to the new mangling by using the -new-mangling-for-tests option
When the new mangling is enabled permanently, the option can be removed from the RUN command lines again.
2017-01-24 15:27:45 -08:00
Saleem Abdulrasool
beae3de7b7 Adjust for SVN r256222
The inlinehint attribute requires the function to be marked with
inlinehint or PGO to be available now.
2017-01-03 14:31:41 -08:00
Dmitri Gribenko
d175b3b66d Migrate FileCheck to %FileCheck in tests 2016-08-10 23:52:02 -07:00
John McCall
843355c828 In an attempt to appease bots, check for these lines in an arbitrary order. 2016-05-19 08:52:36 -07:00
John McCall
79c83c7303 Teach IRGen to tell Clang to emit lazy definitions on demand.
Previously, we had hacks in place to eagerly emit everything in
the global ExternalDefinitions list.  These can now be removed,
at least at the IRGen layer.
2016-05-18 22:48:45 -07:00
Jordan Rose
bc83940301 Make pointer nullability explicit using Optional.
Implements SE-0055: https://github.com/apple/swift-evolution/blob/master/proposals/0055-optional-unsafe-pointers.md

- Add NULL as an extra inhabitant of Builtin.RawPointer (currently
  hardcoded to 0 rather than being target-dependent).
- Import non-object pointers as Optional/IUO when nullable/null_unspecified
  (like everything else).
- Change the type checker's *-to-pointer conversions to handle a layer of
  optional.
- Use 'AutoreleasingUnsafeMutablePointer<NSError?>?' as the type of error
  parameters exported to Objective-C.
- Drop NilLiteralConvertible conformance for all pointer types.
- Update the standard library and then all the tests.

I've decided to leave this commit only updating existing tests; any new
tests will come in the following commits. (That may mean some additional
implementation work to follow.)

The other major piece that's missing here is migration. I'm hoping we get
a lot of that with Swift 1.1's work for optional object references, but
I still need to investigate.
2016-04-11 20:06:38 -07:00
Manav Gabhawala
7928140f79 [SE-0046] Implements consistent function parameter labels by discarding extraneous parameter names and adding _ where necessary 2016-04-06 20:21:58 -04:00
Xin Tong
d3c6d1f6d7 Revert "Address @gribozavr comments to 273b1495834bcc650642aec523dd0504f8623cfa"
This reverts commit 062d14b422.

Revert "Fix a swift argument initialization bug - swift argument should be initialized"

This reverts commit 273b149583.

This breaks DebugAssert as well as REPL builds. Revert to appease the bots while i
look further.
2016-01-29 08:00:16 -08:00
Xin Tong
273b149583 Fix a swift argument initialization bug - swift argument should be initialized
after argc and argv are initialized. rdar://24250684

I reordered the CHECK statements in some tests to make them pass.

I tested this on Darwin and Linux.
2016-01-28 22:36:14 -08:00
Slava Pestov
7cf72989b7 Re-apply "Fix linkage of 'static inline' Clang-imported definitions"
This re-applies commit r31763 with a change to the predicate we
use for determining the linkage of a definition. It turns out we
could have definitions with a Clang body that were still public,
so instead of checking for a Clang body just check if the Clang
declaration is externally visible or not.

Swift SVN r31777
2015-09-08 22:12:06 +00:00
Dave Abrahams
8269d8130b Revert "Fix linkage of 'static inline' Clang-imported definitions"
This reverts commit r31763, as it was breaking the bots:

Swift SVN r31765
2015-09-08 16:31:35 +00:00
Slava Pestov
fc0a18be3f Fix linkage of 'static inline' Clang-imported definitions
If an external SIL function has a Clang-generated body, I think this
means we have a static function, and we want to use Shared linkage,
not Public.

Add a new flag to SILFunction for this and plumb it through to
appease assertions from SILVerifier.

Swift SVN r31763
2015-09-08 06:26:35 +00:00
Dmitri Hrybenko
1d2374e5ba Fix the IRGen/c_globals.swift test on Linux
Swift SVN r29682
2015-06-25 19:07:00 +00:00
Dmitri Hrybenko
39bdb54586 Fix the IRGen/c_globals.swift test for i386
Swift SVN r29681
2015-06-25 18:53:12 +00:00
Dmitri Hrybenko
92897ea2c9 IRGen: stop using the DisableFPElim target option
Use function attributes instead.  This is required for a newer LLVM
since it does not have the target option at all.

rdar://21480622

Swift SVN r29676
2015-06-25 18:24:37 +00:00
Jordan Rose
49e1a746e0 [IRGen] Bitcast SIL globals that don't have the right LLVM type.
This comes up when the SIL global actually refers to a static global defined
in C. In these cases Clang may have already emitted the global with a
different type---one appropriate for Clang, but not for Swift. By the time
we get to this part of the code, we should have already rejected anything not
layout-compatible, so just do the bitcast and be done with it.

Reviewed by John.

rdar://problem/21361469

Swift SVN r29471
2015-06-17 23:26:13 +00:00
Slava Pestov
e8b6b0a4ed Don't use println() in c_globals.swift test
Review feedback from Dmitri.

Swift SVN r27957
2015-04-30 02:59:06 +00:00
Slava Pestov
fafd0b83ee Attempt to properly handle static global variables
This is based on Jordan Rose's patch from rdar://problem/17597453.

Swift SVN r27821
2015-04-27 22:16:37 +00:00