4 Commits

Author	SHA1	Message	Date
Michael Gottesman	37d60a08bb	[move-only] Rename mark_must_check -> mark_unresolved_non_copyable_value. ... I was originally hoping to reuse mark_must_check for multiple types of checkers. In practice, this is not what happened... so giving it a name specifically to do with non copyable types makes more sense and makes the code clearer. Just a pure rename.	2023-08-30 22:29:30 -07:00
Michael Gottesman	87713349d4	[move-only] Ensure that copyable borrowing parameters of resilient type used by a function in the same module can be recognized by the checker ... I found this while looking at problems around library evolution for noncopyable types. Specifically: ``` +public func borrowVal(_ x: borrowing CopyableStruct) {} ``` causes an error since we do not recognize the load_borrow here: ``` +sil [ossa] @testSimpleBorrowParameter : $@convention(thin) (@in_guaranteed CopyableStruct) -> () { +bb0(%0 : @noImplicitCopy $*CopyableStruct): + %1 = load_borrow %0 : $*CopyableStruct // users: %7, %2 + %2 = copyable_to_moveonlywrapper [guaranteed] %1 : $CopyableStruct // user: %3 + %3 = copy_value %2 : $@moveOnly CopyableStruct // user: %4 + %4 = mark_must_check [no_consume_or_assign] %3 : $@moveOnly CopyableStruct // users: %6, %5 + debug_value %4 : $@moveOnly CopyableStruct, let, name "x", argno 1 // id: %5 + destroy_value %4 : $@moveOnly CopyableStruct // id: %6 + end_borrow %1 : $CopyableStruct // id: %7 + %8 = tuple () // user: %9 + return %8 : $() // id: %9 +} ``` rdar://112028837	2023-07-10 12:09:21 -07:00
Michael Gottesman	87829aaa32	[move-only] Rename CheckKind::NoCopy -> CheckKind::NoConsumeOrAssign. ... This reflects better the true meaning of this check which is that a value marked with this check cannot be consumed on its boundary at all (when performing let/var checking) and cannot be assigned over when performing var checking.	2023-02-10 13:46:19 -08:00
Michael Gottesman	0986bd019e	[no-implicit-copy] Make sure that we eliminate initial copy_value from [no_copy] cases like we do for moveonly. ... Just missed pattern matching the copyable_to_moveonlywrapper at the beginning of the initialization sequence. rdar://104935447	2023-02-02 13:58:25 -08:00