Commit Graph

4421 Commits

Author SHA1 Message Date
Artem Chikin
23452d5bad Merge pull request #36377 from artemcm/NewDriverDefault
Always build SwiftDriver and use it as default compiler driver
2021-04-27 09:53:06 -07:00
Artem Chikin
60a4af3dcc Add documentation about the compiler's standalone driver and its build procedure. 2021-04-26 12:17:56 -07:00
Ikko Ashimine
7a7d089933 docs: Fix typo in SIL.rst
implemenation -> implementation
2021-04-15 12:40:57 +09:00
Evan Wilde
014b1fe72c Fix the missing title underbar 2021-04-13 17:54:31 -07:00
Doug Gregor
e77a27e8ed [Concurrency] Introduce runtime detection of data races.
Through various means, it is possible for a synchronous actor-isolated
function to escape to another concurrency domain and be called from
outside the actor. The problem existed previously, but has become far
easier to trigger now that `@escaping` closures and local functions
can be actor-isolated.

Introduce runtime detection of such data races, where a synchronous
actor-isolated function ends up being called from the wrong executor.
Do this by emitting an executor check in actor-isolated synchronous
functions, where we query the executor in thread-local storage and
ensure that it is what we expect. If it isn't, the runtime complains.
The runtime's complaints can be controlled with the environment
variable `SWIFT_UNEXPECTED_EXECUTOR_LOG_LEVEL`:

  0 - disable checking
  1 - warn when a data race is detected
  2 - error and abort when a data race is detected

At an implementation level, this introduces a new concurrency runtime
entry point `_checkExpectedExecutor` that checks the given executor
(on which the function should always have been called) against the
executor on which is called (which is in thread-local storage). There
is a special carve-out here for `@MainActor` code, where we check
against the OS's notion of "main thread" as well, so that `@MainActor`
code can be called via (e.g.) the Dispatch library's
`DispatchQueue.main.async`.

The new SIL instruction `extract_executor` performs the lowering of an
actor down to its executor, which is implicit in the `hop_to_executor`
instruction. Extend the LowerHopToExecutor pass to perform said
lowering.
2021-04-12 15:19:51 -07:00
Joe Groff
0d602bfe04 Document version of introduction for new async-related manglings 2021-04-08 15:56:20 -07:00
John McCall
82c190af21 Merge pull request #36751 from rjmccall/two-word-executor
Change ExecutorRef and fix the actor runtime
2021-04-08 16:49:37 -04:00
John McCall
1370ec0413 Doc fix for the Builtin.Executor mangling 2021-04-08 12:57:12 -04:00
Richard Wei
fb66de6126 Unify mangling operators for async, @Sendable, @differentiable and @noDerivative.
Repurpose mangling operator `Y` as an umbrella operator that covers new attributes on function types. Free up operators `J`, `j`, and `k`.

```
async ::= 'Ya'                             // 'async' annotation on function types
sendable ::= 'Yb'                          // @Sendable on function types
throws ::= 'K'                             // 'throws' annotation on function types
differentiable ::= 'Yjf'                   // @differentiable(_forward) on function type
differentiable ::= 'Yjr'                   // @differentiable(reverse) on function type
differentiable ::= 'Yjd'                   // @differentiable on function type
differentiable ::= 'Yjl'                   // @differentiable(_linear) on function type
```

Resolves rdar://76299796.
2021-04-07 17:49:10 -07:00
Richard Wei
82886bf77a [AutoDiff] Fix mangling of '@noDerivative' in function types.
`@noDerivative` was not mangled in function types, and was resolved incorrectly when there's an ownership specifier. It is fixed by this patch with the following changes:

* Add `NoDerivative` demangle node represented by a `k` operator.
    ```
    list-type ::= type identifier? 'k'? 'z'? 'h'? 'n'? 'd'?  // type with optional label, '@noDerivative', inout convention, shared convention, owned convention, and variadic specifier
    ```
* Fix `NoDerivative`'s overflown offset in `ParameterTypeFlags` (`7` -> `6`).
* In type decoder and type resolver where attributed type nodes are processed, add support for nested attributed nodes, e.g. `inout @noDerivative T`.
* Add `TypeResolverContext::InoutFunctionInput` so that when we resolve an `inout @noDerivative T` parameter, the `@noDerivative T` checking logic won't get a `TypeResolverContext::None` set by the caller.

Resolves rdar://75916833.
2021-04-07 15:42:12 -07:00
Varun Gandhi
c110a42677 Merge pull request #36788 from varungandhi-apple/vg-note-LIT_FILTER
[docs] Note LIT_FILTER in Testing.md.
2021-04-07 08:51:58 -07:00
Varun Gandhi
7df40080af [docs] Note LIT_FILTER in Testing.md. 2021-04-06 16:23:39 -07:00
Nate Chandler
3243def046 Revert "[IRGen] Mangling for async, non-constant partial_apply thunks."
This reverts commit efaaee3656.
2021-04-06 15:51:33 -07:00
filip-sakel
04d2970f05 Update LibraryEvolution.rst for SE-0293. 2021-04-07 01:15:39 +03:00
Owen Voorhees
00a58c6c17 Fix man page typo 2021-04-04 20:12:01 -07:00
John McCall
4f6f8b3377 Rewrite hop_to_executor so that it takes a Builtin.Executor in IRGen
The comment in LowerHopToActor explains the design here.
We want SILGen to emit hops to actors, ignoring executors,
because it's easier to fully optimize in a world where deriving
an executor is a non-trivial operation.  But we also want something
prior to IRGen to lower the executor derivation because there are
useful static optimizations we can do, such as doing the derivation
exactly once on a dominance path and strength-reducing the derivation
(e.g. exploiting static knowledge that an actor is a default actor).

There are probably phase-ordering problems with doing this so late,
but hopefully they're restricted to situations like actors that
share an executor.  We'll want to optimize that eventually, but
in the meantime, this unblocks the executor work.
2021-03-30 20:08:41 -04:00
Richard Wei
d997526948 Fix function differentiability kind metadata and mangling. (#36601)
* Move differentiability kinds from target function type metadata to trailing objects so that we don't exhaust all remaining bits of function type metadata.
  * Differentiability kind is now stored in a tail-allocated word when function type flags say it's differentiable, located immediately after the normal function type metadata's contents (with proper alignment in between).
  * Add new runtime function `swift_getFunctionTypeMetadataDifferentiable` which handles differentiable function types.
* Fix mangling of different differentiability kinds in function types. Mangle it like `ConcurrentFunctionType` so that we can drop special cases for escaping functions.
    ```
    function-signature ::= params-type params-type async? sendable? throws? differentiable? // results and parameters
    ...
    differentiable ::= 'jf'                    // @differentiable(_forward) on function type
    differentiable ::= 'jr'                    // @differentiable(reverse) on function type
    differentiable ::= 'jd'                    // @differentiable on function type
    differentiable ::= 'jl'                    // @differentiable(_linear) on function type
    ```

Resolves rdar://75240064.
2021-03-30 09:59:06 -07:00
John McCall
0f152af85f Add a Builtin.Executor type to abstract executor references. 2021-03-28 04:31:49 -04:00
Varun Gandhi
a2cb5a8146 Merge pull request #35639 from varungandhi-apple/vg-doc-asm-obj-debugging
[docs] Document tips for debugging assembly & object code.
2021-03-22 18:36:58 -07:00
Varun Gandhi
7dcaf5ceb3 [docs] Mention useful debugging tools with short blurbs about usage.
Based on Dave Lee's suggestion in:
https://github.com/apple/swift/pull/35639#pullrequestreview-579556113
2021-03-22 14:59:39 -07:00
Hassan ElDesouky
27a11bd4a3 [Docs] Correct the link to the CODE_OWNERS.TXT 2021-03-22 17:12:08 +02:00
Robert Widmann
16f3387877 Merge pull request #36280 from apple/egorzhdan-patch-1
Docs: fix example in C++ interop manifesto
2021-03-20 12:12:41 -07:00
Doug Gregor
52096a640e SE-0302: Rename ConcurrentValue/@concurrent to Sendable/@Sendable. 2021-03-18 23:48:21 -07:00
Nate Chandler
7ef9cc633e [Gardening] Fixed sigil. 2021-03-15 13:36:56 -07:00
Arnold Schwaighofer
00f495f48c Mangling for suspend/await resume partial functions
We use the suffix 'TQ'index and 'TP'index.
2021-03-15 11:13:22 -07:00
Nate Chandler
efaaee3656 [IRGen] Mangling for async, non-constant partial_apply thunks.
The scheme uses 'Tw' followed by the index--the number of non-constant
async partial applies that have been thunked in the function.
2021-03-14 17:30:43 -07:00
Andrew Trick
6ed58c6380 Add debug_value [poison] flag.
If the '[poison]' flag is set, then all references within this debug
value will be overwritten with a sentinel at this point in the
program. This is used in debug builds when shortening non-trivial
value lifetimes to ensure the debugger cannot inspect invalid
memory. `debug_value` instructions with the poison flag are not
generated until OSSA islowered. They are not expected to be serialized
within the module, and the pipeline is not expected to do any
significant code motion after lowering.
2021-03-12 19:33:23 -08:00
Erik Eckstein
2b96a913aa docs: fix doc build error in SIL.rst 2021-03-07 09:56:28 +01:00
Meghana Gupta
6e0e4dcb88 Merge pull request #36174 from meg-gupta/fixcastoptimizer
Fix verifier error in CastOptimizer
2021-03-05 21:52:27 -08:00
Varun Gandhi
bd93de8e2b [docs] Document tips for debugging assembly & object code. 2021-03-05 14:15:52 -08:00
Andrew Trick
73cde15abe Merge pull request #36299 from atrick/poison-destroy
[NFC] Add a poison flag to SIL destroy_value.
2021-03-04 22:55:54 -08:00
Andrew Trick
e0a440c036 Add a poison flag to SIL destroy_value.
When the IRGen side is implemented, this will overwrite shadow debug
variables with a poison sentinel for all references within the value.
2021-03-04 17:26:18 -08:00
Meghana Gupta
e6da389a81 Add documentation for end_lifetime 2021-03-04 13:24:29 -08:00
eeckstein
c4f6fc32c5 Merge pull request #36253 from eeckstein/fix-assign-by-wrapper
SIL: some improvements/fixes around assign_by_wrapper
2021-03-04 20:07:14 +01:00
Meghana Gupta
bb375c398b Merge pull request #36263 from meg-gupta/fixparser
Fix SILParsing for forwarding ownership kind
2021-03-04 08:27:58 -08:00
Egor Zhdan
211ad11d62 Docs: fix example in C++ interop manifesto
This adds the missing return type to subscript in one of the examples in C++ interop manifesto.
2021-03-04 13:50:32 +03:00
Meghana Gupta
8f7978b183 Fix SILParsing for forwarding ownership kind 2021-03-03 16:58:23 -08:00
Erik Eckstein
9055e93af9 SIL: some improvements/fixes around assign_by_wrapper
* Refactoring: replace "Destination" and the ownership qualifier by a single "Mode".  This represents much better the mode how the instruction is to be lowered. NFC
* Make assign_by_wrapper printable and parseable.
* Fix lowering of the assign modes for indirect results of the init-closure: The indirect result was initialized and not assigned to. The fix is to insert a destroy_addr before calling the init closure. This fixes a memory lifetime error and/or a memory leak. Found by inspection.
* Fix an iterator-invalidation crash in RawSILInstLowering
* Add tests for lowering assign_by_wrapper.
2021-03-03 18:57:02 +01:00
Erik Eckstein
e064ff32f4 docs: Document the store_borrow instruction 2021-03-02 12:02:54 +01:00
Ikko Ashimine
bf2afe0b26 [docs] Fix typo in DebuggingTheCompiler.md
specfied -> specified
2021-02-27 17:33:24 +09:00
Holly Borla
648c5753df [SILGen] Teach SILGen to emit property wrapper generator functions that
take in a projected value.
2021-02-25 18:35:14 -08:00
Michael Gottesman
c1a9f6f3eb Merge pull request #36078 from gottesmm/silrst-improvements
[sil.rst] Just added some docs for begin_borrow, updated end_borrow syntax, adding more inline links.
2021-02-24 16:05:03 -08:00
Ben Rimmington
8ae1b768f1 [docs] Update SIL.rst (#36131) 2021-02-24 20:40:31 +00:00
Max Desiatov
6e0267f6b8 docs: Convert ARCOptimization.rst to markdown (#35993)
Currently docs are a mix of reStructuredText and Markdown and unifying them as Markdown would make more sense long term, as far as I understand. This converts `ARCOptmization.rst`, initially converted with [Pandoc](https://pandoc.org/) with manual cleanup after the fact.
2021-02-24 10:31:45 +00:00
swift-ci
6097742252 Merge pull request #36121 from rxwei/rename-in-to-of 2021-02-24 01:03:51 -08:00
Richard Wei
0b53a02544 [AutoDiff] Rename 'in:' to 'of:' in differential operators.
Rename the argument label `in:` in `gradient(at:in:)`, `pullback(at:in:)`, etc to `of:`, as suggested in the [pitch thread](https://forums.swift.org/t/differentiable-programming-for-gradient-based-machine-learning/42147).
2021-02-24 01:33:42 -05:00
Richard Wei
8bc6143a4c [AutoDiff] Rename 'move(along:)' to 'move(by:)'.
Rename `move(along:)` to `move(by:)` based on the proposal feedback. The main argument for the change is that tangent vectors specify both a direction and a magnitude, whereas `along:` does not indicate that `self` is being moved by the specified magnitude.
2021-02-23 21:45:01 -05:00
Max Desiatov
e7e28cc9bd docs: Convert ARCOptimization.rst to markdown 2021-02-23 22:25:50 +00:00
Doug Gregor
4716371110 Merge pull request #36061 from jckarter/foreign-async-flag-silgen
SILGen/ClangImporter: Handle async imports with a boolean error flag argument.
2021-02-23 14:19:33 -08:00
Erik Eckstein
65a6d9a22a MemoryLifetimeVerifier: support verifying enum memory locations.
This is kind of complicated, because an enum can be trivial for one case and not trivial for another case. We need to check at which parts of the function we can prove that the enum does (or could) have a trivial case. In such a branch, it's not required in SIL to destroy the enum location.

Also, document the rules and requirements for enum memory locations in SIL.rst.

rdar://73770085
2021-02-23 08:08:34 +01:00