averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity
181,000 Commits 623 Branches 2,949 Tags
link-libc++-on-macos
Commit Graph

2424 Commits

Author SHA1 Message Date
Slava Pestov
0bb323b75c Sema: Move buildAutoClosureExpr() from TypeChecker to ConstraintSystem 2019-11-19 14:02:21 -05:00
Slava Pestov
7c145fb7be Merge pull request #27951 from zoecarver/key-path-default-arg 
Fix KeyPath with default arg
 2019-11-19 00:04:51 -05:00
Doug Gregor
6096b43957 Merge pull request #28345 from DougGregor/cs-fewer-root-exprs 
[Constraint solver] Reduce reliance on the "root" expression further
 2019-11-18 18:50:59 -08:00
Doug Gregor
e06fb4bed3 [Constraint system] Capture "salvage" result in a self-contained data structure 
Rework the interface to ConstraintSystem::salvage() to (a) not require
an existing set of solutions, which it overwrites anyway, (b) not
depend on having a single expression as input, and (c) be clear with
its client about whether the operation has already emitted a
diagnostic vs. the client being expected to produce a diagnostic.
 2019-11-18 16:34:01 -08:00
Doug Gregor
85a5df09a2 Merge pull request #28292 from DougGregor/apply-fixes-without-root 
[Constraint system] Apply fixes without relying on a root expression.
 2019-11-18 15:06:19 -08:00
Bruno Rocha
4d85c8bcd1 Index optional is pattern 2019-11-18 13:09:39 -08:00
Doug Gregor
c63076e3a1 [Constraint system] Apply fixes without relying on a root expression. 
When applying the set of fixes introduced by a solution, don't rely on
a walk from the "root" expression of the constraint system to
attribute the fixes to expressions. Rather, collect the fixes and emit
diagnostics in source order of the expressions that pertain to.
 2019-11-15 20:33:57 -08:00
Doug Gregor
6273941034 [Constraint solver] Centralize solution-application logic somewhat. 
In anticipation of eliminating this solution-application logic, centralize
to application of solutions back to the constraint system for the purpose
of applying the solution to update ASTs.
 2019-11-15 20:33:57 -08:00
Holly Borla
ea1a46c84d [ConstraintFix] Rather than creating a coalesced fix right before 
diagnosing failures in applySolutionFixes, coalesce fixes and
diagnose failures in one method on ConstraintFix.

This eliminates the need for the `DefaultGenericArgument` fix (which
was renamed from `ExplicitlySpecifyGenericArguments`) to have an
array of missing parameters, which was only used when the fixes were
coalesced. Instead, the coalesced arguments are used to create the
`MissingGenericArgumentsFailure` diagnostic directly.
 2019-11-13 14:15:40 -08:00
zoecarver
853dfbefa0 Copy labels and conformances 2019-11-12 13:34:01 -08:00
zoecarver
27ffff100e Use range-based for-loop 2019-11-11 19:37:16 -08:00
Holly Borla
7f2d4c0a99 [CSApply] When applying constraint fixes for a solution, only coalesce 
fixes of the same kind.
 2019-11-11 10:08:25 -08:00
zoecarver
18f918b5dd Regenerate labels in CSApply instead of keeping two sizes 2019-11-10 20:19:34 -08:00
Robert Widmann
1000c9d19e Remove some ancillary TypeCheckers 2019-11-10 14:29:05 -08:00
Robert Widmann
ecb7b8c749 Make convertToType a utility 2019-11-10 13:39:34 -08:00
Robert Widmann
32e68468f4 Remove TypeChecker from parameter default checking 2019-11-10 13:34:43 -08:00
Robert Widmann
7bad9aacc3 Drop the TypeChecker out of ConstraintSystem 2019-11-10 13:26:47 -08:00
Robert Widmann
63896c1fc5 Make more high-level type checking endpoints utility 2019-11-10 13:03:46 -08:00
Robert Widmann
d21424b58b Make typeCheckExpression a utility 2019-11-10 12:40:09 -08:00
Robert Widmann
4bf902549f Merge pull request #28152 from hamishknight/decontextualize 
Make TypeChecker's Context and Diags fields private
 2019-11-09 15:00:47 -08:00
Doug Gregor
bc926f7eb7 [Constraint system] Drop the root expression from FailureDiagnostic. 
We're not using it for anything, now.
 2019-11-08 22:38:49 -08:00
Hamish Knight
643ef80486 Remove external uses of TypeChecker's Context field 2019-11-08 10:59:20 -08:00
Robert Widmann
41ab235797 [CS] Remove some TypeChecker uses 2019-11-07 12:41:37 -08:00
Hamish Knight
fb55c032f8 diagnoseUnownedImmediateDeallocation doesn't need a TypeChecker 2019-11-07 12:41:37 -08:00
Hamish Knight
cb0c9adc46 Use getXXXType over getXXXDecl in a bunch of places 2019-11-07 08:26:08 -08:00
Robert Widmann
e6dbfa393a Move Utilities back to TypeChecker 2019-11-06 15:20:46 -08:00
Robert Widmann
e5599ef25d Make coerceParameterListToType a utility 2019-11-06 15:08:59 -08:00
Robert Widmann
36987e0491 Drop references to the type checker in CSApply 2019-11-06 15:08:59 -08:00
Robert Widmann
59db7832b0 Make coerceToRValue a utility 2019-11-06 15:08:59 -08:00
Doug Gregor
1cd5152f86 Move ConstraintSystem::setExprTypes() over to Solution 
It belongs on Solutionn, which should contain all of the information
needed to perform the operation. Simplify the implementation slightly
while doing this, eliminating some dead code.
 2019-11-06 08:50:53 -08:00
Doug Gregor
39af1d0c55 [Constraint solver] Drop Expr* from finalization. 
We don't need to pass an expression into rewriter finalization; the update
of expression types can be handled per-expression.
 2019-11-06 08:39:47 -08:00
Robert Widmann
6c6035eca2 Drop TypeCheckers out of TypeCheckStmt 2019-11-05 22:52:28 -08:00
Robert Widmann
e804d6ed9a Make TypeChecker::getDefaultType a utility 2019-11-05 20:31:15 -08:00
Robert Widmann
392df03466 [NFC] Drop unnecessary TypeCheckers from Sema 2019-11-05 20:30:40 -08:00
Holly Borla
e840d52258 [Diagnostics] Allow fixes with the same locator to be coalesced before 
application rather than throwing away subsequent fixes.

The "primary fix" decides whether or not to coalesce fixes that have
the same locator.
 2019-11-05 09:15:13 -08:00
Robert Widmann
8a69f886ad Merge pull request #27955 from AnthonyLatsis/bracestmt_cleanup 
NFC: Solidify and tidy up the BraceStmt interface
 2019-10-31 13:48:40 -07:00
Robert Widmann
4996858c4d Re-implement isInvalid for ValueDecls 2019-10-30 15:09:14 -07:00
Robert Widmann
118f68b1be Make getProtocol and getLiteralProtocol static utilities 2019-10-30 12:55:42 -07:00
Robert Widmann
972e755e9b Give ConstraintSystem's outlet to the ASTContext 
Make it less tempting to ask for the type checker embedded into
ConstraintSystem by using the accessor to the ASTContext.
 2019-10-30 12:55:42 -07:00
Robert Widmann
da2b063af9 Make calls to lookupMember actually look static 2019-10-30 12:55:42 -07:00
Robert Widmann
bcf03aa019 Make getDeclTypeCheckingSemantics a utility 2019-10-30 12:55:10 -07:00
Hamish Knight
4fa8fb6c08 substituteInputSugarTypeForResult can be static 2019-10-30 07:56:32 -07:00
Anthony Latsis
6325915b4b NFC: Solidify and tidy up the BraceStmt interface 2019-10-30 16:43:59 +03:00
Robert Widmann
e7006a92b1 Clean up some trivially true condition clauses 
ProtocolConformanceRef::isConcrete checks the invalid bit for us.
 2019-10-29 16:56:22 -07:00
Robert Widmann
b849e51768 Use operator bool to claw back some readability 2019-10-29 16:56:21 -07:00
Robert Widmann
3e1a61f425 [NFC] Fold The Tri-State In Optional<ProtocolConformanceRef> 
ProtocolConformanceRef already has an invalid state.  Drop all of the
uses of Optional<ProtocolConformanceRef> and just use
ProtocolConformanceRef::forInvalid() to represent it.  Mechanically
translate all of the callers and callsites to use this new
representation.
 2019-10-29 16:55:56 -07:00
Hamish Knight
c95ef110d5 [CS] Make resolveLocatorToDecl simpler and more robust (#27836) 
[CS] Make resolveLocatorToDecl simpler and more robust
 2019-10-23 15:11:23 -07:00
Hamish Knight
19fe19e972 Address review feedback 2019-10-23 13:22:03 -07:00
Slava Pestov
362488b867 Sema: Fix substitutions of generic caller-side default arguments 
Using mapTypeIntoContext() is incorrect here, because we might not
be calling the default argument from the callee's context. Instead,
use the substitutions from the ConcreteDeclRef.

Fixes <rdar://problem/55739617>.
 2019-10-22 16:38:45 -04:00
Hamish Knight
a5e375a770 Cache resolved concrete decl refs in ExprRewriter 
This ensures we don't have to compute the substitutions
multiple times when, for example, rewriting an
apply of generic function.
 2019-10-22 12:36:59 -07:00