Slava Pestov
205d8e6640
Sema: Remove unnecessary operator new overload
2025-12-10 18:48:47 -05:00
Slava Pestov
ba7df4013e
Sema: Avoid copying BindingSets
...
They're stored inside the ConstraintGraphNode now, so returning a
`const BindingSet *` from within determineBestBindings() should
be safe.
2025-12-10 18:48:00 -05:00
Slava Pestov
d8cf185a13
Sema: Fix source location bookkeeping for 'reasonable time' diagnostic
...
We already had bookkeeping to track which statement in a multi-statement
closure we were looking at, but this was only used for the 'reasonable time'
diagnostic in the case that we hit the expression timer, which was almost
never hit, and is now off by default. The scope, memory, and trial limits
couldn't use this information, so they would always diagnose the entire
target being type checked.
Move it up from ExpressionTimer to ConstraintSystem, so that we get the
right source location there too. Also, factor out some code duplication
in BuilderTransform to ensure we get the same benefit for result builders
applied to function bodies too.
2025-12-06 20:31:08 -05:00
Hamish Knight
6dfff1ce9c
[CS] Remove getImplicitValueConversionLocator & ImplicitConversion
...
These are now unused.
2025-11-15 19:26:46 +00:00
Slava Pestov
819738c83e
AST: Rename mapTypeIntoContext() => mapTypeIntoEnvironment(), mapTypeOutOfContext() => mapTypeOutOfEnvironment()
2025-11-12 14:48:19 -05:00
Hamish Knight
3b57a7cd91
[CS] Clean up some property wrapper logic
...
These methods can be simplified a bunch since the returned decl is
always the input decl and we can refactor the lambdas to just return
the auxiliary variable and have the type computation in the caller.
2025-11-04 00:56:01 +00:00
Becca Royal-Gordon
393965090e
Merge pull request #34556 from beccadax/mod-squad-2
...
[SE-0491] Implement lookup and diagnostics for module selectors (MyMod::someName)
2025-10-28 16:00:26 -07:00
Hamish Knight
05e3d15955
[CS] Propagate CSApply failures in a few more places
...
We had some cases where we weren't propagating failures to apply the
solution, and as such weren't invalidating the resulting AST. Fix up
these cases.
2025-10-26 14:49:17 +00:00
Becca Royal-Gordon
60cc537f70
Improve module selector constraint solver diagnostics
2025-10-24 16:23:49 -07:00
Hamish Knight
f15fae4737
Merge pull request #84822 from hamishknight/just-a-phase
...
[CS] Remove `ConstraintSystemPhase`
2025-10-24 16:05:08 +01:00
Hamish Knight
bb877ce3c0
[CS] Remove ConstraintSystemPhase
2025-10-19 13:14:00 +01:00
Hamish Knight
77a59383f7
[CS] Penalize implicit pointer conversions to generic parameter types
...
We ought to consider outright banning these conversions if the
destination is a generic parameter type, but for now let's penalize
them such that we don't end up with ambiguities if you're doing an
implicit pointer conversion through an identity generic function.
rdar://161205293
2025-10-16 14:14:53 +01:00
Slava Pestov
8600cdcc2a
Sema: Remove ConstraintSystemPhase::{Diagnostics,Finalization}
2025-10-10 16:06:42 -04:00
Slava Pestov
a8d896ab8f
Sema: Don't reuse PreparedOverload from normal type checking in salvage()
...
We want to re-prepare our overloads, since now they will contain fixes.
2025-10-10 15:44:12 -04:00
Hamish Knight
9e4208b69b
[CS] Remove custom logic from simplifyTypeForCodeCompletion
...
We ought to be able to just use `simplifyType` with an additional
parameter to tell it to produce archetypes.
2025-10-04 12:56:52 +01:00
Allan Shortlidge
2467b931a7
ConstraintSystem: Move key path type utilities to AST.
2025-09-25 07:13:17 -07:00
Hamish Knight
3141b5a8cd
[AST] NFC: Introduce PrintOptions::forDebugging
2025-09-21 23:19:06 +01:00
Slava Pestov
9dea72579a
Sema: Record ASTNode type changes in PreparedOverload
...
Also, move some methods from ConstraintSystem.h to ConstraintSystem.cpp.
2025-09-18 14:54:16 -04:00
Slava Pestov
b181fcf0fd
Sema: Get prepared overloads working again with the Pre()/Post() split
2025-09-18 14:54:16 -04:00
Slava Pestov
c344d6b0eb
Sema: Rename getTypeOf{Member,}ReferenceImpl() to Pre() and factor out Post() versions
2025-09-18 11:31:59 -04:00
Slava Pestov
182c38470b
Sema: Remove replacementsPtr parameter from getTypeOfMemberReference()
2025-09-18 11:31:59 -04:00
Slava Pestov
a028eb36b7
Sema: Don't need to return new baseObjTy from getTypeOfMemberReferenceImpl()
2025-09-18 11:31:59 -04:00
Slava Pestov
d8ead6c5cc
Sema: Refactor getTypeOf{Member,}Reference() to take the OverloadChoice
2025-09-18 11:31:59 -04:00
Slava Pestov
2fde4a50e7
Sema: Split off getTypeOfMemberReferenceImpl() from getTypeOfMemberReference()
2025-09-18 11:06:32 -04:00
Slava Pestov
35a439de24
Sema: Remove replacements parameter from getMemberReferenceTypeFromOpenedType()
2025-09-18 11:06:31 -04:00
Slava Pestov
1efc9a6d0d
Sema: Split off getTypeOfReferenceImpl() from getTypeOfReference()
2025-09-18 11:06:31 -04:00
Hamish Knight
782a5b4332
[CS] Ensure we trap in getOverloadChoice if the overload is missing
...
Using `*` previously meant we'd invoke undefined behavior.
2025-09-17 16:11:53 +01:00
Slava Pestov
60246a2889
Sema: Further split up getTypeOfMemberTypeReference()
2025-09-09 18:58:10 -04:00
Slava Pestov
6dc2e7558d
Sema: Don't modify openedType in getMemberReferenceTypeFromOpenedType()
2025-09-09 18:58:09 -04:00
Hamish Knight
23560df5f4
[CS] Remove AllowUnresolvedTypeVariables
...
This has been unused for a while now.
2025-09-07 12:17:18 +01:00
Hamish Knight
0142d0b92e
[CS] Add debug message when hitting too complex limit
...
Add a message to the constraints debugging log when hitting one of the
complexity limits.
2025-09-01 13:33:47 +01:00
Hamish Knight
5b8dfc70ab
[CS] Emit fallback diagnostic if needed for IgnoreInvalidASTNode
...
If no other error has been emitted, make sure we emit a fallback
diagnostic rather than crashing in the ASTVerifier or SILGen.
2025-08-28 15:31:48 +01:00
Hamish Knight
9c898206e8
Merge pull request #83870 from hamishknight/overrun
...
[CS] Open generic requirements for types with unbound + placeholder types
2025-08-27 23:20:33 +01:00
Hamish Knight
2e0be5afd7
[CS] Open generic requirements for types with unbound + placeholder types
...
- Introduce a generic requirements opening function for type resolution,
which is used by the constraint system in cases where we need to
impose requirements on opened type variables.
- Refactor `replaceInferableTypesWithTypeVars` to use this function
when opening generic types that contain either placeholder or unbound
generic types.
Together these changes ensure that we don't drop generic requirements
when an unbound generic or placeholder type is used as a generic
argument.
2025-08-26 12:16:54 +01:00
Slava Pestov
1972c4845f
Sema: Cache result of getUnsatisfiedAvailabilityConstraint()
...
This query is expensive and we call it a lot.
2025-08-25 17:14:35 -04:00
Slava Pestov
a399c46db7
Sema: Pull preconcurrency adjustment out of getUnopenedTypeOfReference()
2025-08-15 14:39:14 -04:00
Anthony Latsis
fec049e5e4
Address llvm::PointerUnion::{is,get} deprecations
...
These were deprecated in
https://github.com/llvm/llvm-project/pull/122623 .
2025-07-29 18:37:48 +01:00
Hamish Knight
33b58d25d8
[CS] NFC: Factor out Solution::hasAppliedSelf
2025-07-18 10:54:17 +01:00
Hamish Knight
3244bffe71
[CS] Handle TVO_CanBindToPack in mergeEquivalenceClasses
...
Previously we could incorrectly propagate `TVO_CanBindToPack` to a
type variable that cannot bound to a pack type.
2025-07-14 12:44:23 +01:00
Slava Pestov
9a8f3baa06
Sema: Add room for a PreparedOverload to BindOverload constraint
2025-07-10 19:53:19 -04:00
Slava Pestov
83f95aeaed
Sema: Allocate PreparedOverload in solver arena
2025-07-10 19:53:19 -04:00
Slava Pestov
7916ed982f
Sema: Move DeclReferenceType to PreparedOverload.h
2025-07-10 19:53:19 -04:00
Slava Pestov
f7a552385c
Sema: PreparedOverload => PreparedOverloadBuilder
2025-07-10 19:53:18 -04:00
Slava Pestov
8527e88423
Sema: Extract prepareOverload() from resolveOverload()
2025-07-10 19:53:15 -04:00
Slava Pestov
751edee921
Sema: Rework PreparedOverload to store a list of changes
2025-07-09 15:00:10 -04:00
Slava Pestov
2a0b11a22e
Sema: Collect property wrappers in PreparedOverload
2025-07-09 15:00:03 -04:00
Slava Pestov
be6cf92982
Sema: Plumb PreparedOverload through to replaceInferableTypesWithTypeVars()
2025-07-09 15:00:03 -04:00
Slava Pestov
ab72407108
Sema: Collect opened pack expansion types in PreparedOverload
2025-07-09 15:00:02 -04:00
Slava Pestov
c5741e31ed
Sema: Stash the existential archetype in PreparedOverload
2025-07-09 15:00:02 -04:00
Slava Pestov
426c7a3fdf
Sema: Collect constraints in PreparedOverload
2025-07-09 15:00:02 -04:00
