Commit Graph

3 Commits

Author SHA1 Message Date
Argyrios Kyrtzidis
e7c55789c5 [ClangImporter] Fix issue with source order comparisons of clang source locations when using a bridging PCH
Clang importer was picking the beginning of the main FileID as include location of its modules, which is the same location that the clang PCH mechanism is using as import location.
Make sure to use a different location otherwise we'll have problems with source order comparisons of clang source locations not being deterministic.

rdar://29137319
2019-01-17 11:10:44 -08:00
Argyrios Kyrtzidis
1e457ae3e2 [test] Add 'objc_interop' requirement to test/IDE/clang-importing/complete_with_clang_comments.swift 2018-01-12 17:41:04 -08:00
Argyrios Kyrtzidis
1423af3a91 [ClangImporter] Make sure that headers from the bridging header are considered 'isBeforeInTranslationUnit' compared to headers imported from swift code
Previously headers from the bridging header and imported modules had the exact same top location so comparison with them
was not sound. This resulted in missing documentation comments from declarations and possible assertion hits while clang
was trying to determine the comment for a declaration, but I could not create a reduced test case that triggered an assertion hit.

rdar://34925466
2018-01-12 16:26:13 -08:00