Commit Graph

5 Commits

Author SHA1 Message Date
Owen Voorhees
166555c34f [Diagnostics] Better diagnostic for integer used as a boolean condition 2020-02-03 21:20:41 -08:00
Jordan Rose
5455274d4a Revert "[test] Disable ClangImporter/private_frameworks_modules.swift"
This reverts commit 749adec703. -Wno-
options currently aren't respected with -Xcc, so just use a blanket -w
instead.

rdar://37618912
2018-02-18 20:38:01 -08:00
Xi Ge
749adec703 [test] Disable ClangImporter/private_frameworks_modules.swift while investigating. rdar://37618912 (#14693) 2018-02-16 17:49:24 -08:00
Jordan Rose
87b26843f6 [test] Add -Xcc -Wno-private-module to a test about private modules
rdar://problem/37618912
2018-02-16 14:36:43 -08:00
Jordan Rose
af4d4e94c8 [ClangImporter] If a submodule named 'Private' is missing, ask Clang (#14673)
Previously the recommended pattern for having a "private" interface
for a public framework that was easy to strip out was to define an
explicit submodule named 'Private'. However, that makes it all too
easy to have dependencies from the public parts of the module on the
private parts, and other such problems. We're now recommending that
the private module map instead define a parallel module named with
"_Private" as a suffix. Clang already implemented this, but Swift
didn't get the same treatment.

This fix tries to avoid hardcoding too much; it notes that this kind
of remapping is limited to the name 'Private' as the second component
of a module hierarchy, but doesn't actually encode the mapping with the
"_Private" suffix.

rdar://problem/37553763
2018-02-16 10:01:12 -08:00