Commit Graph

9 Commits

Author SHA1 Message Date
Daniel Rodríguez Troitiño
00b35b7176 [windows] Mark crash-in-user-code as UNSUPPORTED in VS2017
The test is very flaky. It works and stops working randomly for no
apparent reason. To avoid future problems, and since VS2019 keeps
working without these problems, mark the tests as unsupported to avoid
the noise.

See also #34143 and #34625.
2020-11-09 17:35:06 -08:00
Daniel Rodríguez Troitiño
f8585d75d1 [windows] Partial revert #34143. Remove XFAIL.
The test started working in the last week, for unknown reasons.

Remove the XFAIL line, but keep the infra for detecting the MSVC version
for the tests. It might be useful later.

If the test starts failing again, and nobody has any idea why, the best
path forward might be marking it as UNSUPPORTED.
2020-11-07 15:57:12 -08:00
Daniel Rodríguez Troitiño
fcb51dc947 [windows] XFAIL crash-in-user-code test in MSVC 2017
See also #33383 where this problem is better explained.

MSVC doesn't seem to trigger the exception code when no frame pointers are generated. The only thing missing would be for interpreted code to have a more informative crash message.

Add a new LLVM Lit feature with the value of the VisualStudioVersion environment variable (it seems to not change even for minor versions, so it is an easy way to figure out the 2017/2019 difference, even if updates are applied).

Use the new feature in a XFAIL check in the test.
2020-09-30 14:58:45 -07:00
Saleem Abdulrasool
0de6e736ba test: repair Android builds
This test requires execution, which the android CI currently does not support.
Mark the test as executable to fix the CI.
2019-12-02 09:20:35 -08:00
Tapan Thaker
322ad482b6 [FrondEnd] Wrap RunInmediately() in a pretty stack trace indicating we are running user code 2019-11-30 12:33:28 -08:00
Mishal Shah
b8866006c3 Revert "[FrontEnd] Pretty stack trace indicating running user code" 2019-11-19 15:37:58 -08:00
Tapan Thaker
15eea66b9f Make the crash-in-user-code check agnostic for macOS, Linux and Windows
Co-Authored-By: Harlan Haskins <harlan@apple.com>
2019-11-18 20:00:59 -08:00
Tapan Thaker
0f3ed3fc98 Fix the crash-in-user-code test for macos and Linux 2019-11-18 18:09:16 -08:00
Tapan Thaker
f2f521f8bf [FrondEnd] Wrap RunInmediately() in a pretty stack trace indicating we are running user code 2019-11-15 07:29:29 -08:00