averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-14 20:36:38 +01:00
Code Issues Packages Projects Releases Wiki Activity
183,638 Commits 622 Branches 2,942 Tags
017be57e9b51a576b2bf0e642f5fb8a28b39dc95
Commit Graph

1299 Commits

Author SHA1 Message Date
Andrew Trick
161158806e LifetimeDependenceScopeFixup: handle returning dependent Optional 
Add support for returnValue phis (e.g. to return an Optional .some or .none).

Fixes rdar://149397018 (Wrapping non escapable in an Optional
(or any copy lifetime wrapper) is an escape)

(cherry picked from commit a1aaed9159)
 2025-04-21 22:57:06 -07:00
Meghana Gupta
2a314d0fab Handle a special case of borrowed from instruction in CopyToBorrowOptimization 2025-04-21 15:25:33 -07:00
Andrew Trick
8504b7f584 Merge pull request #80880 from atrick/62-read-accessor 
[6.2] LifetimeDependenceScopeFixup: _read accessor: extend temporaries
 2025-04-17 08:13:35 -07:00
Andrew Trick
ff7cc60923 Fix unidentified LifetimeDependence.Scope initialization. 
Fixes rdar://149226564 (Compiler crash with non-escapable storing another
non-escapable and having a deinit)

(cherry picked from commit 6f8605263d)
 2025-04-16 23:32:00 -07:00
Andrew Trick
a794a39a12 LifetimeDependenceScopeFixup: _read accessor: extend temporaries 
Add support for extending owned temporary values in addition to access scopes
and borrow scopes. Required for _read accessors in which the coroutine depends
on an owned value.

(cherry picked from commit 62454f42fd)
 2025-04-16 23:32:00 -07:00
Andrew Trick
2fbc9032f5 LocalVariableUtils: add store_borrow access tracking. 
We sometimes use LocalVariableUtils to analyze temporary storage in which the
store_borrow is not already enclosed by an access scope.

(cherry picked from commit 4e35d255ad)
 2025-04-16 23:31:53 -07:00
Andrew Trick
5269c0c8e7 [NFC] Add LifetimeDependenceUseDefWalker utility. 
Refactor VariableIntroducerUseDefWalker into a general
LifetimeDependenceUseDefWalker for use with LifetimeDependenceScopeFixup.

(cherry picked from commit b80bd16eea)
 2025-04-16 23:23:55 -07:00
Andrew Trick
cc949bdaa7 [NFC] minor cleanup 
(cherry picked from commit 43debc529f)
 2025-04-16 23:23:55 -07:00
Andrew Trick
32fc6ad623 Add InstructionRange.overlapsWithPath() utility. 
(cherry picked from commit 28daec01a7)
 2025-04-16 23:23:54 -07:00
Andrew Trick
e60e65538a SwiftCompilerSources: add IgnoredUseInst as incidental 
Fixes rdar://148540048 (Assigning span value to `_` results in an incorrect escape diagnostic)

(cherry picked from commit 2bdaa68e98)
 2025-04-16 23:23:54 -07:00
Andrew Trick
fa39b4172b Fix AddressOwnershipLiveRange to include the full range. 
This allows further extension of access scopes.

Fixes rdar://143992296 (Use of `RawSpan` in switch context causes compiler crash
in AddressOwnershipLiveRange)

(cherry picked from commit c9279d9899)
 2025-04-16 23:23:54 -07:00
Erik Eckstein
9f9942855a Guard the copy_block optimization with an experimental feature flag CopyBlockOptimization 2025-04-16 14:33:27 +02:00
Erik Eckstein
d8fddc9dcc Optimizer: remove redundant copy_block instructions 
Removes a `copy_block` if its only uses, beside ownership instructions, are callees of function calls
```
  %2 = copy_block %0
  %3 = begin_borrow [lexical] %2
  %4 = apply %3() : $@convention(block) @noescape () -> ()
  end_borrow %3
  destroy_value %2
```
->
```
  %4 = apply %0() : $@convention(block) @noescape () -> ()
```

rdar://118521396
 2025-04-16 14:33:26 +02:00
Erik Eckstein
a80a006ec6 SIL: make CopyBlockInst conform to UnaryInstruction 2025-04-16 14:33:26 +02:00
Andrew Trick
e01a167db1 LocalVariableUtils: add unit tests 
(cherry picked from commit ccb26bcd89)
 2025-04-11 00:29:02 -07:00
Andrew Trick
c9c0ef843c LocalVariableUtils: fix data flow propagation of escapes. 
This is only used for lifetime dependence diagnostics.

Fix a couple of obvious problems with data flow propagation that crept in during
"cleanup" because no unit tests existed.

(cherry picked from commit 37ecd0e9bd)
 2025-04-11 00:28:52 -07:00
Andrew Trick
bf6ed014dd Fix escape analysis: addressable parameters. 
An address-type parameter may escape via an indirect argument if the function's
result depends on the argument's address.

(cherry picked from commit 05a9acbb40)
 2025-04-08 14:09:54 -07:00
nate-chandler
88fb10ed3b Merge pull request #80589 from nate-chandler/cherrypick/release/6.2/rdar148744816 
6.2: [SIL] Fix bridged begin_apply results.
 2025-04-07 16:46:48 -07:00
Nate Chandler
b7ca5672c5 [SIL] Fix bridged begin_apply results. 
The `yield_once_2` adds an extra result at the end, the deallocation.
Fix the indexing for the token and yielded results.
 2025-04-07 07:36:43 -07:00
Erik Eckstein
75dc04a9ca Simplification: check for isolated conformances when simplifying metatype casts 
rdar://147417762
 2025-04-07 10:58:02 +02:00
Erik Eckstein
6987748517 SIL: add matchesActorIsolation 
Returns true if the conformance is not isolated or if its isolation matches the isolation `inFunction`.
 2025-04-07 10:58:02 +02:00
Erik Eckstein
f4955978d8 SIL: fix AllocStackInst.isLexical 
If wrongly returned false.
 2025-04-03 23:04:49 +02:00
Erik Eckstein
f8d6efd485 SimplifyAllocStack: bail if the address of the allocated existential escapes 
This is not a problem if the alloc_stack already contains the opened existential.
Fixes a miscompile
rdar://148253142
 2025-04-03 23:04:49 +02:00
Erik Eckstein
1100bf9bfb SimplifyAllocStack: rename a variable and update a comment 
NFC
 2025-04-03 06:58:00 +02:00
Erik Eckstein
ee18f8c168 Simplification: fix a crash in alloc_stack simplification 
Handle the case that a type dependent operand is a dynamic-self argument and not an open-existential instruction.

rdar://148258964
 2025-04-01 10:58:45 +02:00
Artem Chikin
66334f8f1b Merge pull request #79290 from artemcm/ConstProtoSIL 
[Compile Time Values] Implement a mandatory SIL pass to verify '@const' values
 2025-04-01 00:12:27 -07:00
Andrew Trick
81ca8fd3ec Enable NonEscapableType support on Windows. 
SwiftCompilerSources for Windows is now fully enabled, so there is no
longer any reason to gate these passes under an OS check.

commit d482ab73bc
Author: Hiroshi Yamauchi <hjyamauchi@gmail.com>
Date:   Fri Dec 13 09:24:44 2024 -0800

Update the pinned toolchain for Windows and enable SwiftCompilerSources for Win/ARM64
 2025-03-31 11:21:06 -07:00
Artem Chikin
281f84da0f [Compile Time Values] Rewrite the 'Diagnose Unknown Compile Time Values' diagnostic pass in Swift 2025-03-28 10:30:07 -07:00
Artem Chikin
72a420919a [Compile Time Values] Add mandatory optimization pipeline driver for '@const' globals 2025-03-27 14:33:38 -07:00
Artem Chikin
d484ec7c1f [Compile Time Values] Implement a mandatory SIL pass to verify '@const' values 2025-03-27 14:33:35 -07:00
Doug Gregor
e0b52cd20e [SIL] Extend checked-cast instructions with "prohibit isolated conformances" flag 
When performing a dynamic cast to an existential type that satisfies
(Metatype)Sendable, it is unsafe to allow isolated conformances of any
kind to satisfy protocol requirements for the existential. Identify
these cases and mark the corresponding cast instructions with a new flag,
`[prohibit_isolated_conformances]` that will be used to indicate to the
runtime that isolated conformances need to be rejected.
 2025-03-26 22:31:47 -07:00
Andrew Trick
97b249bd11 Merge pull request #80263 from atrick/markdep-addr 
SIL: add mark_dependence_addr
 2025-03-26 10:33:42 -07:00
Erik Eckstein
8b2d27007f DiagnoseInfiniteRecursion: re-implement the pass in swift and fix a bug 
Fixes a false alarm in case of recursive calls with different type parameters.
For example:

```
protocol P {
  associatedtype E: P
}

func noRecursionMismatchingTypeArgs1<T: P>(_ t: T.Type) {
  if T.self == Int.self {
    return
  }
  noRecursionMismatchingTypeArgs1(T.E.self)
}
```
 2025-03-26 09:14:38 +01:00
Erik Eckstein
ac55dae26c AST: add the possibility to compare SubstitutionMaps 2025-03-26 08:45:38 +01:00
Erik Eckstein
85a6df30d6 SIL: add lookup(method:) in VTable and WitnessTable 2025-03-26 08:45:23 +01:00
Erik Eckstein
1844c14c44 SIL: add var ClassMethodInst.member 2025-03-26 08:45:07 +01:00
Erik Eckstein
67556cfbf4 SIL: add some Function APIs 
* `var wasDeserializedCanonical`
* `var genericSignature`
* `func mapTypeIntoContext`
* `var forwardingSubstitutionMap`
 2025-03-26 08:45:07 +01:00
Erik Eckstein
59ad8b6623 Optimizer: add var Context.currentModuleContext 2025-03-26 08:43:55 +01:00
Erik Eckstein
1ce545ba3d SIL: add some DeclRef APIs 
* `var decl`
* `func ==`
* `func calleesAreStaticallyKnowable`
 2025-03-26 08:43:55 +01:00
Erik Eckstein
b39a6cdd22 AST: add var GenericSignature.genericParameters 2025-03-26 07:30:11 +01:00
Erik Eckstein
42bba8f484 AST: add some Declaration APIs 
* `var Declaration.parentModule`
* `var AbstractFunctionDecl.isOverridden`
 2025-03-26 07:30:11 +01:00
Erik Eckstein
e1af31bc19 AST: add var Conformance.rootConformance 2025-03-26 07:30:10 +01:00
Erik Eckstein
d523e303c3 SIL/AST: move some SIL.Type APIs to the TypeProperties protocol which makes them also available for AST.Type and AST.CanonicalType 2025-03-26 07:30:10 +01:00
Erik Eckstein
380ea889bc SIL: fix self-argument APIs in Function 
`var selfArgument` should return an optional, i.e. nil if the function doesn't have a self argument.
 2025-03-26 07:30:10 +01:00
Andrew Trick
69b6b1d309 LifetimeDependenceDefUseWalker: handle addressable dependencies 2025-03-25 23:02:45 -07:00
Andrew Trick
d9dd93560d Support mark_dependence_addr in SIL passes. 2025-03-25 23:02:45 -07:00
Andrew Trick
e7000e4668 SIL: Add mark_dependence_addr 2025-03-25 23:02:42 -07:00
Kuba (Brecka) Mracek
41ae31647a Merge pull request #76045 from kubamracek/mergeable-traps 
Add -Xfrontend -mergeable-traps as a way to emit mergeable traps
 2025-03-25 07:13:18 -07:00
eeckstein
02fc68badf Merge pull request #80237 from eeckstein/fix-alias-of-end-apply 
AliasAnalysis: fix effect of `end_apply` / `abort_apply` for read-only coroutines
 2025-03-24 21:08:40 +01:00
Kuba Mracek
ed5e89a501 Also respect -mergeable-traps when merging cond_fails in SILOptimizer 2025-03-24 09:04:44 -07:00