Commit Graph

3 Commits

Author SHA1 Message Date
Michael Gottesman
ac51ce3fc7 [polymorphic-builtins] Enable test during optimize builds.
The confusion here was around a test that was testing the behavior when one
/does not/ guard a polymorphic builtin with a _isConcrete. Specifically, without
_isConcrete, one gets weird behavior where in debug we crash, but in release we
may not due to further inlining/specialization. With _isConcrete, we never
crashand get the appropriate behavior.

This commit works by changing the current run of the polymorphic builtin test to
force -Onone and adds an extra -O run that way we validate both behaviors.
2020-04-09 14:44:45 -07:00
Michael Gottesman
c3be255008 [polymorphic-builtin] Disable experimental builtin test when optimization is enabled for now.
I am going to loop back around later and I want to unblock the package bots.
2019-09-23 17:54:16 -07:00
Michael Gottesman
b9046c6d03 [polymorphic-builtin] Rather than asserting in IRGen if we see a builtin that was not specialized, turn the builtin into a trap.
I forgot about this part of the design when I was working on this. To ensure
that the whole design works as expected, I included a small end-to-end test
using an experimental design for simd that uses polymorphic builtins that test
this functionally.

NOTE: The experimental design is only intended to exercise the code functionally.

rdar://48248417
2019-09-23 13:51:01 -07:00