Commit Graph

32761 Commits

Author SHA1 Message Date
David Ungar
614f1cd0ff Fixed test 2019-06-05 15:16:04 -07:00
David Ungar
fc4cc211f7 Fixed test 2019-06-05 14:47:09 -07:00
David Ungar
3f3f51c7b9 new pattern code 2019-06-04 14:36:52 -07:00
David Ungar
ad77af1b87 Catch top-level dependency for use under pattern.
var x = 3
_ = x
2019-06-03 21:13:25 -07:00
David Ungar
663760e3b7 ASTOOScope ontology 2019-05-28 10:48:22 -07:00
Mike Ash
ef069a367a Merge pull request #25017 from mikeash/fix-crash-without-backtrace-optimized2
[Test] Use --allow-empty in crash_without_backtrace_optimized.swift.
2019-05-28 11:45:10 -04:00
Sho Ikeda
2019a97e55 Merge pull request #25066 from ikesyo/use-isempty-over-count
[gardening] Use `Collection.isEmpty` over `Collection.count`
2019-05-29 00:24:48 +09:00
Arnold Schwaighofer
4cb6c71adf Merge pull request #25064 from aschwaighofer/local_functions_not_implicit_dynamic
Don't add implicit dynamic to local functions.
2019-05-28 06:59:21 -07:00
Michael Gottesman
39dbf54e19 [cast-opt] Update checked_cast_addr_br objc -> swift bridged cast optimization for ownership.
These fix assertions that we hit by even performing the optimization, some
making sure the test doesn't hit those is sufficient.
2019-05-26 18:30:21 -07:00
Sho Ikeda
a35c9f0c60 [gardening] Use Collection.isEmpty over Collection.count 2019-05-26 09:35:20 +09:00
swift-ci
b088acb66e Merge pull request #24767 from ikesyo/remove-unnecessary-breaks 2019-05-25 16:15:06 -07:00
Arnold Schwaighofer
0ebdce93e7 Don't add implicit dynamic to local functions. 2019-05-25 14:39:25 -07:00
Michael Gottesman
a0421124f0 Merge pull request #25041 from gottesmm/pr-d02a03999626f1d50a4bf0996dadb34e72d9f355
[cast-opt] Fix miscompile when we tried to optimize take_on_success t…
2019-05-24 20:48:10 -07:00
Xi Ge
92719d6f30 swift-api-digester: mark if a type declaration is pulled from an external module
To incorporate extensions to types from other modules, the tool sometimes needs
to pull type declaration from external modules even though these modules
are not under checking. We need a flag to explicitly mark such case.
2019-05-24 16:02:40 -07:00
Xi Ge
6e0d771747 Merge pull request #25039 from nkcsgexi/intro-json-file
api-digester: keep track of the introduced platforms and language versions for all APIs
2019-05-24 12:09:07 -07:00
Michael Gottesman
ad676857ea [cast-opt] Fix miscompile when we tried to optimize take_on_success that resulted in invalid IR being emitted.
The specific problem here is that we are setting the insertion point of a
SILBuilder and not unsetting it. I fixed the problem by creating a separate
builder so the original builder stays put.

I originally came across this in my work on moving ownership stripping after the
diagnostic passes. This patch fixes it without my other changes to ease
cherry-picking to 5.1.

I also added more test coverage by expanding the test case to also handle
copy_on_success and take_always.

rdar://51093557
2019-05-24 09:58:24 -07:00
Rintaro Ishizaki
6c0806419f Merge pull request #25008 from owenv/improved_#else_if_diagnostic
[Parse] Improve diagnostic and add fixit to correct '#else if' to '#elseif'
2019-05-24 09:38:12 -07:00
Argyrios Kyrtzidis
b1b6ce6916 Merge pull request #25033 from akyrtzi/sourcekitd-expose-indent-switch-option
[sourcekitd] Expose the indentation option for extra indentation of switch case
2019-05-23 20:48:00 -07:00
Owen Voorhees
901d947478 Improve diagnostic and add fixit to correct '#else if' to 'elseif'
Resolves SR-10581
2019-05-23 19:34:21 -07:00
Xi Ge
7b445c3c98 api-digester: keep track of the introduced platforms and language versions for all APIs
These fields will be used to diagnose the missing of available
attributes for newly added APIs.

rdar://51089418
2019-05-23 17:23:30 -07:00
Arnold Schwaighofer
b127aac1ce Merge pull request #24781 from aschwaighofer/fix_some_type_dynamic_replacement
Fix dynamic replacement of some type when used with associated types
2019-05-23 16:36:32 -07:00
Argyrios Kyrtzidis
1dcb1e083a [sourcekitd] Expose the indentation option for extra indentation of switch case
rdar://51079623
2019-05-23 16:21:30 -07:00
Slava Pestov
1441ad1ac5 Disable objc_class_resilience_stubs.swift on macOS 10.9 and 10.10 2019-05-23 16:45:18 -04:00
Mike Ash
20b24c54b5 [Test] Use --allow-empty in crash_without_backtrace[_optimized].swift. 2019-05-23 14:50:08 -04:00
Arnold Schwaighofer
84a68e11e0 Merge pull request #25014 from aschwaighofer/fix_combine_dynamic_function_ref
SILCombine: We are not guaranteed to get a function_ref instruction here
2019-05-23 11:41:46 -07:00
Michael Gottesman
195672a201 Disable crash_without_backtrace.swift.
rdar://51076215
2019-05-23 11:39:55 -07:00
Arnold Schwaighofer
44e4e1404d Merge pull request #25010 from aschwaighofer/implicit_dynamic_fixes
Don't use implicit dynamic on declarations if they are transparent or…
2019-05-23 10:01:16 -07:00
swift-ci
e80b965e79 Merge pull request #24996 from apple/update-parseableinterface-tests 2019-05-23 09:51:42 -07:00
Arnold Schwaighofer
4985e0f818 SILCombine: We are not guaranteed to get a function_ref instruction here
Also fix an issue in that cast optimizer and objc bridging thunks that
are marked dynamic.

Same test case tests both issues.

rdar://51068786
2019-05-23 08:39:31 -07:00
Michael Gottesman
9cb7ab1896 Merge pull request #25007 from gottesmm/pr-d77fff3d54f2b70d825402ebfd766d3891da9b0b
[diagnose-unreachable] Ignore/eliminate end_borrows after noreturn fu…
2019-05-23 08:38:33 -07:00
Mike Ash
95e90fa8bf [Test] Fix crash_without_backtrace_optimized.swift.
Insert a fputs before the crash to keep FileCheck happy.
2019-05-23 11:35:55 -04:00
Arnold Schwaighofer
b82d2f222a Temporarily disable test Reflection/box_descriptors.sil on linux 2019-05-23 08:26:55 -07:00
Arnold Schwaighofer
b3363af9c1 Don't use implicit dynamic on declarations if they are transparent or inlinable,
or have the silgen_name attribute

The first two are contratictory and the last is a current implementation
limitation.

rdar://51031462
2019-05-23 07:09:48 -07:00
Mishal Shah
8daa0348ed Fix type in Inputs path 2019-05-23 00:20:24 -07:00
Joe Groff
076e0c0280 Merge pull request #24994 from jckarter/SR-10264-test
Add regression test for SR-10264
2019-05-22 20:44:23 -07:00
Michael Gottesman
372046cc04 [diagnose-unreachable] Ignore/eliminate end_borrows after noreturn functions.
This seems to happen more often when we strip ownership after diagnose
unreachable.
2019-05-22 20:06:18 -07:00
Xi Ge
2d22a375f7 Merge pull request #24986 from nkcsgexi/object-literal-syntax
SourceKit/SyntaxMap: properly handle object literal syntax for highlighting
2019-05-22 19:29:17 -07:00
David Smith
2dcd82239b Merge pull request #24874 from Catfish-Man/bulk-tests
Test foreign strings on invalid content more thoroughly
2019-05-22 16:28:23 -07:00
Mishal Shah
4bb3fc9daa [Tests] Update the ParseableInterface tests to use make-old.py due to nondeterministic timestamp issue with touch 2019-05-22 15:38:49 -07:00
Joe Groff
7d54810b92 Revert "[SourceKit] Fail requests when an error occurs" 2019-05-22 15:18:28 -07:00
Joe Groff
3c0732ab14 Add regression test for SR-10264 2019-05-22 15:14:03 -07:00
Xi Ge
d3a192f3c5 SourceKit/SyntaxMap: properly handle object literal syntax for highlighting
We should use parser to figure out the end position of object literal expression instead
of scanning through token stream, which crashes sourcekitd when the syntax is invalid.

Fixing: rdar://48390913
2019-05-22 14:29:57 -07:00
Argyrios Kyrtzidis
729a9558e8 Merge pull request #24124 from DavidGoldman/master
[SourceKit] Fail requests when an error occurs
2019-05-22 10:49:42 -07:00
Andrew Trick
bdf7b2ade6 Merge pull request #24947 from atrick/fix-dynamic-exclusivity
Fix exclusivity diagnostics to be aware of [dynamically_replaceable].
2019-05-22 10:36:01 -07:00
Rintaro Ishizaki
a79fadcdce Merge pull request #24969 from rintaro/ide-completion-poundfile-rdar47169238
[CodeCompletion] '#file', '#line', et al. after '#'
2019-05-22 10:12:55 -07:00
Mike Ash
31200ddcf0 Merge pull request #24864 from mikeash/backtrace-target-run-fix
[Test] Fix backtrace tests to use %target-run.
2019-05-22 13:08:58 -04:00
Mike Ash
930e0b9860 Merge pull request #24950 from mikeash/objc-getclass-disable-conditionally
[Test] Add availability to the GenericMangled test in objc_getClass.swift
2019-05-22 10:38:18 -04:00
Slava Pestov
9b4f05d619 Merge pull request #24964 from slavapestov/more-test-stable-abi-tweaks
Split up a couple more tests into stable and pre-stable ABI deployment target versions
2019-05-21 22:22:29 -04:00
Joe Groff
3a1771c143 Merge pull request #24944 from jckarter/keypath-jit-workaround
IRGen: Work around JIT bug with GOT equivalents.
2019-05-21 19:16:34 -07:00
Mishal Shah
b21774b8bb [Tests] Update the ParseableInterface tests to use make-old.py due to nondeterministic timestamp issue with touch 2019-05-21 17:36:58 -07:00