Commit Graph

11 Commits

Author SHA1 Message Date
Bob Wilson
1e3317be78 [Test] Conditionalize KVOKeyPaths tests that only work with Swift 5.1
Some of the tests in KVOKeyPaths.swift check problems that were not fixed
until Swift 5.1 so they are not expected to pass when running with the
5.0 libraries.

rdar://problem/50173830
2019-05-16 12:57:25 -07:00
Lily Vulcano
bdb4686375 Take 2 of “[SDK] Fix multiple issues with Swift KVO”
This reproposes @lilyball’s fixes in https://github.com/apple/swift/pull/20103 while adding her fix to ensure observations are removed before observed objects in 32-bit testing.
2019-02-01 14:07:44 -08:00
Lily Vulcano
ac7a93963c Revert "Merge pull request #20103 from lilyball/fix_kvo"
This reverts commit 7c514196fc, reversing
changes made to 2d7c31b24c.

This patch will be reproposed with fixes.
2019-02-01 10:55:06 -08:00
Arnold Schwaighofer
d3eb822044 test/stdlib/KVOKeyPaths.swift fails i386 and blocks PR testing (#22294)
SR-9838
rdar://47735786
2019-02-01 08:54:12 -08:00
Lily Vulcano
1087adb943 The error is right: these should be @objc. 2019-01-30 13:35:05 -08:00
Lily Ballard
5811a04e8f Add some tests for KeyPath issues
Test to make sure the `String -> KeyPath` table used for the
`NSKeyValueObservingCustomization` callbacks isn't screwed up by
observing another object's property with the same name from within the
callbacks.

Test `NSSortDescriptor.keyPath` to ensure it's also not screwed up by
creating sort descriptors for the same property on different objects.
2019-01-30 12:41:14 -08:00
Slava Pestov
38fdb6b7ff Update various tests to not use Swift 3 code
Completely mechanical changes:

- Explicit @objc in a few places
- Some imported APIs changed
- For the mix-and-match tests, just test version 4/5 instead of 3/4
2018-10-26 20:15:01 -04:00
Mike Ash
537e0e3183 [SDK] Rename _NSKeyValueObservation to NSKeyValueObservation in source code.
Keep the _NSKeyValueObservation in the runtime name, since we need to avoid colliding with the name used in the pre-ABI-stable libraries.

rdar://problem/44914709
2018-10-02 10:36:08 -04:00
Mike Ash
798edb9d0e [Runtime][Stdlib][Overlays] Rename various Objective-C classes and methods that would conflict when loading old Swift libraries into a process alongside ABI-stable libraries.
rdar://problem/35768222
2018-09-13 16:55:10 -04:00
Slava Pestov
5d2752f7d2 Run tests with -swift-version 4 by default
Some test now fail, so add an explicit -swift-version 3.
2018-06-19 23:24:19 -07:00
Mishal Shah
c5ff1f2cac Update master to build with Xcode 9 beta 1, OS X 10.13, iOS 11, tvOS 11, and watchOS 4 SDKs. 2017-06-14 16:20:35 -07:00