25cdc981c7
Merge pull request #14977 from ikesyo/gardening-use-empty
...
[gardening] Use `empty()` over `size() == 0`
2018-03-07 09:34:26 +09:00
743d3a5f44
Merge pull request #14980 from nathawes/rdar37905156-rename-init-gives-empty-categorised-edit-ranges
...
[refactoring] Avoid producing empty string/comment categorized edit ranges when renaming init. Also disallow renaming inits with no arguments.
2018-03-06 15:40:22 -08:00
91ec9982a8
[refactoring] Avoid producing empty categorised edit ranges when renaming init. Also disallow renaming inits with no arguments.
2018-03-05 18:38:35 -08:00
2f47af6c7c
refactoring: don't assume every pattern binding has an initializer. rdar://38062772
2018-03-05 16:14:09 -08:00
26d650292f
[gardening] Use empty() over size() == 0
2018-03-05 14:43:13 +09:00
a9819b6e60
Renaming FrontendInputs -> FrontendInputsAndOutputs
...
Fix comment in ArtsToFrontendOptionsConverter re getOutputFilenamesFromCommandLineOrFilelist
2018-01-30 18:54:38 -08:00
cf36346021
refactoring: when RangeInfo is of kind PartOfExpression, we should use the dedicated field to get the parent expression. rdar://36755861 ( #14088 )
2018-01-23 12:53:50 -08:00
a73b767bf6
refactoring: add a defensive check against null type. rdar://36305791 ( #14014 )
2018-01-18 17:28:54 -08:00
7f0f8830cd
Split AccessorDecl out from FuncDecl. NFC.
...
This has three principal advantages:
- It gives some additional type-safety when working
with known accessors.
- It makes it significantly easier to test whether a declaration
is an accessor and encourages the use of a common idiom.
- It saves a small amount of memory in both FuncDecl and its
serialized form.
2018-01-12 14:20:27 -05:00
7945b7db53
refactoring: Add a defensive check for empty nodes list. ( #13765 )
...
This defensive check ensures convert-to-string-interpolation
refactoring doesn't continue when the selected AST nodes are empty.
We shouldn't need this check since the range info kind already implies its validity.
Tentatively fixing: rdar://35492432
2018-01-08 10:55:32 -08:00
b2d122c4a7
[IDE] Refactoring: Expand a ternary operator into an if statement and vice-versa ( #12554 )
2017-12-21 12:40:30 -08:00
28b206008f
FrontendInputs data structure redo.
...
- Outlaw duplicate input files, fix driver, fix tests, and add test.
- Reflect that no buffer is present without a (possibly pseudo) named file.
- Reflect fact that every input has a (possible pseudo) name.
- Break up CompilerInstance::setup.
Don't bail on dups.
2017-12-05 17:28:03 -08:00
c326ec46c7
[Refactoring] Fix subscript rename
...
Adds support for renaming subscripts with external names, e.g.
subscript(x y: Int), and introduces a noncollapsible parameter name range for
subscript parameters, since these shouldn't be collapsed with an argument label
of the same name as function parameter names are.
2017-11-28 19:45:29 -08:00
13eb7606ce
IDE: Use the is<> template instead of TypeBase::getKind()
2017-11-13 22:10:41 -08:00
746bfc6d59
[Refactoring] Add refactoring action to move type members to extension ( #12795 )
...
This implements SR-6297.
2017-11-09 11:08:34 -08:00
a57199cf68
[refactoring] Implement "Convert to Trailing Closure" refactoring action
2017-10-16 00:42:05 -07:00
8cd677eb1f
[Refactoring] SR-6051 Expansion of switch statement missing cases ( #12281 )
2017-10-13 09:37:58 -07:00
47ee930a50
git-clang-format'ed
2017-10-08 23:56:03 -07:00
c1821755de
NFC: First step (refactoring) towards speeding up compilation by having multiple primary files: Creates new class, FrontendInputs, to encapsulate InputFilenames, InputBuffers, and PrimaryInput, which were formerly in FrontendOptions. Add new instance variable, Inputs, to FrontendOptions in order to hold FrontendInputs.
...
Encapsulate uses of the variables in FrontendInputs with intention-describing functions. Move some code that sets these variables into FrontendInputs and FrontendOptions classes.
Create new FrontendInputs class to encapsulate InputFilenames, InputBuffers and PrimaryInput, which were formerly in Frontend.
Includes one change in SwiftEditor.cpp to resolve a merge conflict.
2017-10-08 10:20:37 -07:00
1bec63d911
[IDE] Remove convenience function added to SourceEditConsumer
2017-09-28 10:21:00 -07:00
c7b9307348
[Refactoring] CursorInfoResolver now properly handles cursor placement in OptionalTryExpr and ForceTryExpr, NFC ( #12123 )
2017-09-26 14:29:10 -07:00
e6eb7df33a
Refactoring tool: Ensure we don't need to check applicability again when performing automated code change. NFC ( #12111 )
2017-09-25 17:21:32 -07:00
6fcb8308ff
[IDE] Refactoring: conversion from “force try” to error handled version ( #12063 )
...
* [IDE] Refactoring: conversion from “force try” do error handled version
* Removed unnecessary empty line
* Changed name of the refactor
* Review fixes
* Fixed recognizing try_! location by CursorResolver
* Review fixes
2017-09-24 09:05:32 -04:00
4e4f5ae6cf
IDE: add a utility stream class to SourceEditorConsumer. NFC ( #12069 )
2017-09-22 16:37:05 -07:00
80698a04b0
[IDE] SR-5745 Refactoring: converting strings concatenation expression to strings interpolation ( #11944 )
2017-09-19 13:37:42 -07:00
57454eb8c9
SR-5739 Add refactoring action to collapse nested if ( #11851 )
2017-09-18 16:16:01 -07:00
2ba1ca2d8f
IDE: simplify some code. NFC ( #11935 )
...
* IDE: simplify some code. NFC
* add assert.
2017-09-14 18:19:48 -07:00
5626c72718
Refactoring tool: Avoid re-tokenizing when collecting the available refactorings in a given source range. NFC ( #11857 )
2017-09-11 15:45:26 -07:00
0437214b40
Refactoring: avoid re-tokenizing during syntactic renames. NFC
2017-09-11 10:25:44 -07:00
3b800aa11f
[gardening] Remove unused lambda capture(s). NFCI.
2017-09-10 21:44:38 -07:00
53585a5e70
Refactoring: Implement a refactoring action to simplify long number literal format. SR-5746
...
For instance, converting from "100000" to "100_000", and "1000.0001" to
"1_000.000_1".
2017-08-31 14:25:48 -07:00
17f749d1f3
Refactoring: Simplify a switch case statement. NFC
2017-08-31 14:25:48 -07:00
f8b7db4e76
Excise the terms "blacklist" and "whitelist" from Swift source. ( #11687 )
...
The etymology of these terms isn't about race, but "black" = "blocked"
and "white" = "allowed" isn't really a good look these days. In most
cases we weren't using these terms particularly precisely anyway, so
the rephrasing is actually an improvement.
2017-08-30 09:28:00 -07:00
7f29b362d6
SourceKitd: Rename SemaToken to ResolvedCursorInfo. NFC ( #11680 )
2017-08-29 15:34:15 -07:00
5f30eac288
Excise "Accessibility" from the compiler (1/3)
...
"Accessibility" has a different meaning for app developers, so we've
already deliberately excised it from our diagnostics in favor of terms
like "access control" and "access level". Do the same in the compiler
now that we aren't constantly pulling things into the release branch.
This commit changes the names of methods, fields, a few local
variables, and even a swift-ide-test flag. The full list is below.
accessibilityForDiagnostics -> accessLevelForDiagnostics
checkAccessibility -> checkAccess
checkGenericParamAccessibility -> checkGenericParamAccess
checkTypeAccessibility -> checkTypeAccess
checkWitnessAccessibility -> checkWitnessAccessibility
computeAccessibility -> computeAccessLevel
computeDefaultAccessibility -> computeDefaultAccessLevel
fixItAccessibility -> fixItAccess
getAccessibilityString -> getAccessLevelString
getAccessibilityStrictly -> getAccessLevelStrictly
getAccessibilityUID -> getAccessLevelUID
getActualAccessibility -> getActualAccessLevel
getDefaultAccessibility -> getDefaultAccessLevel
getMaxAccessibility -> getMaxAccessLevel
getOverridableAccessibility -> getOverridableAccessLevel
getRawStableAccessibility -> getRawStableAccessLevel
getSetterAccessibility -> getSetterFormalAccess
hasAccessibility -> hasAccess
hasDefaultAccessibility -> hasDefaultAccessLevel
inferAccessibility -> inferAccessLevel
inferDefaultAccessibility -> inferDefaultAccessLevel
inferSetterAccessibility -> inferSetterAccessLevel
overwriteAccessibility -> overwriteAccess
overwriteSetterAccessibility -> overwriteSetterAccess
printAccessibility -> printAccess
requiredAccessibilityForDiagnostics -> requiredAccessForDiagnostics
resolveAccessibility -> resolveAccessControl
setAccessibility -> setAccess
setSetterAccessibility -> setSetterAccess
setDefaultAndMaxAccessibility -> setDefaultAndMaxAccess
validateAccessibility -> validateAccessControl
Accessibility -> AccessLevel
AccessibilityFilter -> AccessFilter
IgnoreAccessibility -> IgnoreAccessControl
NL_IgnoreAccessibility -> NL_IgnoreAccessControl
PrintAccessibility -> PrintAccess
PrintInternalAccessibilityKeyword -> PrintInternalAccessKeyword
SetterAccessibility -> SetterAccessLevel
setterAccessibility -> setterAccess
storedPropertyAccessibility -> storedPropertyAccess
-print-accessibility -> -print-access
2017-08-28 11:11:57 -07:00
60a91bb736
[refactoring] Upstreaming the implementation for Swift local refactoring ( #11568 )
...
[refactoring] Upstreaming the implementation for Swift local refactoring
2017-08-22 16:50:16 -07:00
Sho Ikeda
Nathan Hawes
Xi Ge
David Ungar
John McCall
Roman Roibu
Slava Pestov
Alex Hoppen
Rintaro Ishizaki
Kacper Harasim
Will T. Ellis
Davide Italiano
Jordan Rose
Argyrios Kyrtzidis