Commit Graph

44 Commits

Author SHA1 Message Date
Slava Pestov df633ffcbf AST: Fix shouldLookupMembers() for invalid extensions and nominals
If there are no braces, the start and end location of the range is
the same token. When performing a lookup at this token's location,
don't consider it to be "inside" the braces.

NFC for now, but this problem causes some tests to fail once we
enable cycle diagnostics.
2019-04-22 21:51:42 -04:00
Jordan Rose 0ba6c495ba Add @_implementationOnly
This is an attribute that gets put on an import in library FooKit to
keep it from being a requirement to import FooKit. It's not checked at
all, meaning that in this form it is up to the author of FooKit to
make sure nothing in its API or ABI depends on the implementation-only
dependency. There's also no debugging support here (debugging FooKit
/should/ import the implementation-only dependency if it's present).

The goal is to get to a point where it /can/ be checked, i.e. FooKit
developers are prevented from writing code that would rely on FooKit's
implementation-only dependency being present when compiling clients of
FooKit. But right now it's not.

rdar://problem/48985979
2019-03-28 15:57:53 -07:00
Jordan Rose 9ed3fe061d Change ModuleDecl::getImportedModules to take an option set
...in preparation for me adding a third kind of import, making the
existing "All" kind a problem. NFC, except that I did rewrite the
ClangModuleUnit implementation of getImportedModules to be simpler!
2019-03-28 14:44:41 -07:00
David Ungar 7b099c5906 Remove legacy cross-check. 2019-03-02 08:44:46 -08:00
David Ungar 937600cd9f Fix typo 2019-03-01 09:15:02 -08:00
David Ungar 82a842fd23 Rename addPrivateImports 2019-02-28 14:29:34 -08:00
David Ungar 543c826004 Rename ResultFinderForSelfsConformances 2019-02-28 14:25:54 -08:00
David Ungar 85d6012242 Renamed “DCAnd” to “ContextAnd” 2019-02-28 12:39:11 -08:00
David Ungar 8f67ef602d Add comment and renamed lookUpTopLevelNames… 2019-02-27 17:44:21 -08:00
David Ungar d5983dab73 Minor prettying. 2019-02-27 17:20:12 -08:00
David Ungar 3c32a41425 Introduce runIfNotDoneYet 2019-02-27 10:15:14 -08:00
David Ungar 81c0299c1c Incorperate Doug’s comments & factor a bit more. 2019-02-26 23:35:22 -08:00
David Ungar 1f914fbe58 Pull out top-level recording. 2019-02-24 23:52:28 -07:00
David Ungar ee6acae3c1 Remove bool returns 2019-02-24 23:34:50 -07:00
David Ungar 7c003aae8a Simply retuirn of put asside 2019-02-24 22:59:44 -07:00
David Ungar 66a9cace32 void return from addGeneric… 2019-02-24 22:54:39 -07:00
David Ungar 3641e35721 Pass individual arguments. 2019-02-24 22:38:37 -07:00
David Ungar 0a817a9ba6 Pass flag for addGenericParameters 2019-02-24 21:59:16 -07:00
David Ungar bd5bff6516 Renaming 2019-02-24 16:45:34 -07:00
David Ungar 4c36440ac5 More recursification 2019-02-24 13:31:31 -07:00
David Ungar 6393c8dd05 Partial recurisivication of decl-based name lookup. 2019-02-23 21:45:41 -07:00
David Ungar e3e597dce9 Recursify operator lookup. 2019-02-23 20:54:06 -07:00
David Ungar 26247b4378 Recursify ASTScope-based lookup 2019-02-23 20:39:12 -07:00
David Ungar 3a16af081f Revise ASTScope-bsed lookup 2019-02-23 19:44:27 -07:00
David Ungar 2e0bfb7bb6 Factor out lookInModuleScope 2019-02-23 14:32:52 -07:00
David Ungar 68be30816f Renaming 2019-02-23 14:28:14 -07:00
David Ungar c6044bfc07 RecordDependendcyOnTopLeveName BEFORE debugger client. 2019-02-23 11:42:52 -07:00
David Ungar 6093a7fa90 Rename setIndexOfFIrstOuterResultIfNotSetAlready to recordCompilationOfAScope 2019-02-23 11:42:18 -07:00
David Ungar 6982e66ddf Refactor filterForDiscriminator and call of addLocalVariableResults. 2019-02-22 12:41:03 -07:00
David Ungar 2f099186f9 Tighten up the code. 2019-02-21 11:39:34 -07:00
David Ungar 12d6038e21 isafication 2019-02-20 20:44:05 -07:00
David Ungar 1391c3fbf1 Rm a flag. 2019-02-20 20:33:42 -07:00
David Ungar 7648ecee6c Rm unneeded instvar 2019-02-20 20:22:15 -07:00
David Ungar 19b780171f Minor rearrangement. 2019-02-20 20:15:19 -07:00
David Ungar d45ab0b309 Regularize nextDC, priorDC 2019-02-20 19:43:29 -07:00
David Ungar 6635f39f15 Break up confusing compound. 2019-02-20 17:37:52 -07:00
David Ungar 64ff7909d3 Factor isFinishedWithLookupNowThatIsAboutToLookForOuterResults 2019-02-20 17:05:22 -07:00
David Ungar 3a744d17fb Rm LookupInOneDeclContextResult::isDone 2019-02-20 16:44:24 -07:00
David Ungar c9576ca068 Move LegacyUnqualifiedLookup out of header 2019-02-20 16:16:16 -07:00
David Ungar 306cfd8a4f Constification 2019-02-20 15:32:49 -07:00
David Ungar fdf8326fcc rm unused enum 2019-02-20 15:19:50 -07:00
David Ungar 5d49b3bb3d Minor cleanumps 2019-02-20 14:41:23 -07:00
David Ungar cd48cd6eb3 Format 2019-02-20 14:35:52 -07:00
David Ungar 1595efe5e2 Split the file, unfmt 2019-02-20 14:34:11 -07:00