Commit Graph

311 Commits

Author SHA1 Message Date
Konrad `ktoso` Malawski
b9e1b9cbc2 [Distributed] Fix dist property being implicitly async after refactor (#61995) 2022-11-10 19:23:47 +09:00
Allan Shortlidge
b3403ff9fc Sema: Improve derived conformance diagnostics for actors.
Previously, actor declarations were identified by the diagnostics as classes.
2022-11-08 19:33:32 -08:00
Konrad `ktoso` Malawski
ae23892276 Merge branch 'main' into wip-prevent-async-overloads-dist 2022-09-20 20:31:04 +09:00
Hamish Knight
b12015c343 [SIL] Introduce the increment_profiler_counter instruction
This is a dedicated instruction for incrementing a
profiler counter, which lowers to the
`llvm.instrprof.increment` intrinsic. This
replaces the builtin instruction that was
previously used, and ensures that its arguments
are statically known. This ensures that SIL
optimization passes do not invalidate the
instruction, fixing some code coverage cases in
`-O`.

rdar://39146527
2022-09-07 17:55:13 +01:00
Hamish Knight
ab7b691cca [Profiler] Fix distributed deinit crash when emitting coverage
We need to emit the profiler increment in the
`deinitBodyBB` if we're within a distributed
actor.
2022-09-01 20:29:50 +01:00
Holly Borla
8713d78704 [PrintOptions] Print explicit 'any' in SIL. 2022-08-18 01:15:12 -04:00
Duo Wang
21154d56f7 fix missing test codesign 2022-08-04 10:36:13 -07:00
Mishal Shah
a436f98fff Merge pull request #60286 from wd-doylle/fix/test_codesign
[test] fix missing codesign in test files
2022-08-01 13:14:53 -07:00
Konrad `ktoso` Malawski
96462980fe improve error reporting 2022-07-29 10:44:38 +09:00
Konrad `ktoso` Malawski
fbc829fbbd [Distributed] Don't hang, but throw when target accessor not found 2022-07-29 09:33:38 +09:00
Duo Wang
72e0ac2819 [tests] fix missing codesign in test files 2022-07-28 13:59:44 -07:00
Pavel Yaskevich
ae0c942089 [Distributed] NFC: Re-enable two test-cases that used to fail on arm64e 2022-07-21 14:33:06 -07:00
Konrad `ktoso` Malawski
ac32323fbe Disable test while we fix it; the SIL assertions are too detailed 2022-07-21 20:45:17 +09:00
Konrad `ktoso` Malawski
027c4a69c9 [Distributed] Prevent remote distributed actor from running deinit body 2022-07-14 17:56:03 +09:00
Konrad `ktoso` Malawski
db64d5a961 [Distributed] Disable test while we investigate arm64e issue 2022-07-07 12:58:12 +09:00
Konrad `ktoso` Malawski
6b8642cdf2 [Distributed] Prevent overloading on async in distributed methods, for wire compat 2022-07-05 18:49:42 +09:00
Konrad `ktoso` Malawski
728c007fb9 [Distributed] Implement witnesses for sync or non-throw dist reqs
[Distributed] generic and inner test; without one edge case

[Distributed] fix distributed_thunk test; unsure about those extra hops, could remove later

[Distributed] Remove type pretending in getSILFunctionType; it is not needed

It seems our constant replacement in the earlier phases is enough, and
we don't need this trick at all.

[Distributed] Use thunk when calling cross-actor on DA protocols
2022-07-04 19:02:11 +09:00
swift-ci
9aa2de4137 Merge pull request #41083 from kavon/inconvenienced-actors
[SE-327] Remove need for `convenience` for delegating initializers of an actor.
2022-06-30 14:56:32 -07:00
Konrad `ktoso` Malawski
ef525424f6 Merge pull request #59700 from xedin/distributed-computed-properties-via-accessor-thunk
[Distributed] Implement distributed computed properties via special accessor
2022-06-30 16:04:36 +09:00
Pavel Yaskevich
3006e92d56 [Distributed] NFC: XFAIL a couple of incorrect attr use tests 2022-06-29 14:49:10 -07:00
Pavel Yaskevich
84fa2322d3 [Distributed] Synthesize 'distributed thunk' accessor for distributed computed properties 2022-06-29 14:49:10 -07:00
Konrad `ktoso` Malawski
febfef97d4 [Distributed] Skeleton implementation of distributed computed properties 2022-06-29 14:49:04 -07:00
Kavon Farvardin
41134ea8a0 Remove the need for convenience on actor inits to delegate.
This is possible because actors do not support inheritance. There
is one specific exception to that rule, which is that an actor
can inherit from `NSObject` just to support ObjC interop.

This means an actor is effectively a final class.

resolves rdar://87568153
2022-06-27 16:01:08 -07:00
Konrad `ktoso` Malawski
fa077c1390 [Distributed] distributed func checks now work in protocols & dont crash 2022-06-27 17:17:45 +09:00
Konrad `ktoso` Malawski
22b20afce6 [Distributed] make witness be the distributed thunk 2022-06-27 17:08:55 +09:00
Konrad `ktoso` Malawski
6a2778645f Revert "Merge pull request #59481 from xedin/distributed-computed-properties"
This reverts commit 8125a85a8f, reversing
changes made to 728971c5b7.
2022-06-25 08:49:00 +09:00
Konrad `ktoso` Malawski
bfb69d7ef0 [Distributed] Unlock test which was ASAN failures in the past (2)
This was very very likely solved by our ID/ActorSystem property ordering, this would have indeed triggered ASAN.

Resolves rdar://92277271
2022-06-23 10:18:10 +09:00
Konrad `ktoso` Malawski
5b899e5fac Merge pull request #59627 from apple/wip-asan-ok
[Distributed] Unlock test which was ASAN failures in the past
2022-06-23 10:17:03 +09:00
Konrad `ktoso` Malawski
1c58ee654d [Distributed] Unlock test which was ASAN failures in the past 2022-06-22 09:30:59 +09:00
Konrad `ktoso` Malawski
53168355f0 [Distributed] Explicitly ban a class extending AnyActor as well 2022-06-22 09:21:55 +09:00
Pavel Yaskevich
fa2e64c1fd [Distributed] Sema: Add a new distributed-thunk attribute
The attribute comes handy during solution application to
determine whether the call is using a distributed thunk.
2022-06-17 12:35:54 -07:00
Konrad `ktoso` Malawski
0caf03d63f [Distributed] adjust test to pass with less accurate diagnostics; while we work on getting them back 2022-06-17 12:35:54 -07:00
Pavel Yaskevich
cae01486c6 [CSApply] Distributed: Inject distributed thunk when necessary
Replace distributed member references with distributed thunks
when access happens outside of distributed actor context. This
significantly simplifies distributed compute properties implementation.
2022-06-17 12:35:48 -07:00
Konrad `ktoso` Malawski
5a5b7c007c towards distributed getters 2022-06-17 12:12:16 -07:00
Konrad `ktoso` Malawski
079bbcf517 wip 2022-06-17 12:12:16 -07:00
Doug Gregor
774a94f69d Make sure we can dig out the (distributed) actor from an archetype.
Fixes #59356 / rdar://94976378.
2022-06-14 10:57:29 -07:00
Konrad `ktoso` Malawski
8e6d72190c [Distributed] Further witness checking cleanup and tests 2022-06-14 14:12:39 +09:00
Konrad `ktoso` Malawski
911b42f597 workaround for #59356 while still implementing the witness feature 2022-06-10 21:17:37 +09:00
Konrad `ktoso` Malawski
bd052eedd7 improve FIXME to link to issue 2022-06-10 13:41:37 +09:00
Konrad `ktoso` Malawski
7792a3127b [Distributed] Implement missing case in permitting witnesses 2022-06-10 12:46:33 +09:00
Konrad `ktoso` Malawski
402501da93 [Distributed] Also prevent mutating remoteCall impls 2022-05-31 15:09:50 +09:00
Konrad `ktoso` Malawski
2b0b38968a [Distributed] onReturn ad-hoc req must not be mutating 2022-05-31 11:53:10 +09:00
Doug Gregor
6390fcb1c9 Merge pull request #59086 from DougGregor/se-0338-sendable 2022-05-25 19:30:20 -07:00
Ben Barham
efc9469444 Merge pull request #58975 from bnbarham/make-features-consistent
[Tests] Make OS features consistent
2022-05-25 16:02:43 -07:00
Doug Gregor
a8e16297a9 Sendable checking for overrides.
When an override means crossing an actor boundary, check Sendability of
parameters and results.
2022-05-25 15:17:47 -07:00
Luciano Almeida
d95cd97703 [Sema] Improving implicit closure capture diagnostic wording 2022-05-24 20:49:45 -03:00
Ben Barham
c163e0fe5e [Tests] Make OS features consistent
lit.py currently allows any substring of `target_triple` to be used as a
feature in REQUIRES/UNSUPPORTED/XFAIL. This results in various forms of
the OS spread across the tests and is also somewhat confusing since they
aren't actually listed in the available features.

Modify all OS-related features to use the `OS=` version that Swift adds
instead. We can later remove `config.target_triple` so that these don't
the non-OS versions don't work in the first place.
2022-05-20 19:51:23 -07:00
Karoy Lorentey
ba525375c6 [wrangler] Unconditionally disable test/Distributed/Runtime/distributed_actor_init_local for now 2022-05-18 17:58:45 -07:00
Konrad `ktoso` Malawski
bec6a94c61 [Distributed] disable local_init test for 32bit platforms 2022-05-12 08:01:22 +09:00
Konrad `ktoso` Malawski
2a89cea262 [Distributed] restore id synthesis in DerivedConformance infra for multi module cases 2022-05-09 18:34:08 +09:00