Commit Graph

755 Commits

Author SHA1 Message Date
Chris Lattner 96dea07bdd Merge pull request #1848 from danra/patch-42
Use auto instead of repeating explicit class names
2016-03-24 22:38:54 -07:00
Chris Lattner a4a0118e38 Merge pull request #1855 from danra/patch-43
Use auto instead of repeating explicit class names
2016-03-24 22:37:40 -07:00
Chris Lattner 2753606c3e Merge pull request #1843 from danra/patch-38
Remove redundant else
2016-03-24 22:37:26 -07:00
Chris Lattner 4d64953776 Merge pull request #1862 from danra/patch-44
Fix includes order
2016-03-24 22:27:17 -07:00
Ted Kremenek 93e518c167 Merge pull request #1839 from danra/patch-34
isInvalid methods DRY
2016-03-24 22:09:21 -07:00
swift-ci ecf1e10e5a Merge pull request #1844 from danra/patch-39
Merge pull request #${ghprbPullId} from ${ghprbPullAuthorLogin}/${ghprbSourceBranch} requested by ${ghprbTriggerAuthorLogin}
2016-03-24 17:33:26 -07:00
danra 653b282682 Fix includes order 2016-03-25 00:49:03 +02:00
Dan Raviv 9942cfc6a2 Add missing word in DiverseListImpl comment 2016-03-25 00:42:59 +02:00
John McCall 0ffb7278bc Only use metadata patterns for generic types; perform other
initialization in-place on demand.  Initialize parent metadata
references correctly on struct and enum metadata.

Also includes several minor improvements related to relative
pointers that I was using before deciding to simply switch the
parent reference to an absolute reference to get better access
patterns.

Includes a fix since the earlier commit to make enum metadata
writable if they have an unfilled payload size.  This didn't show
up on Darwin because "constant" is currently unenforced there in
global data containing relocations.

This patch requires an associated LLDB change which is being
submitted in parallel.
2016-03-24 15:10:31 -07:00
danra 21b0c52ad6 Use auto instead of repeating explicit class names 2016-03-24 20:09:06 +02:00
danra b41ccbd58a Add missing period in end of DiverseStack comment (NFC) 2016-03-24 19:41:42 +02:00
Dmitri Gribenko 7907b4b0de Merge pull request #1828 from danra/patch-25
Make nodeToString brief comment clearer (NFC)
2016-03-24 10:24:41 -07:00
danra 9ff4ee43a5 Use auto instead of repeating explicit class names 2016-03-24 18:18:51 +02:00
danra 25bda30cfd Fix DiverseListImpl comment grammar 2016-03-24 18:12:32 +02:00
danra 9cb3e763cd operator!= DRY 2016-03-24 18:07:59 +02:00
danra 2b1d4a763d Remove redundant else 2016-03-24 18:05:06 +02:00
danra 21f21e395b isInvalid methods DRY 2016-03-24 16:32:02 +02:00
danra b494ff93d0 Remove superfluous semicolon in comment (NFC) 2016-03-24 13:34:56 +02:00
danra 4f209a4098 Make nodeToString brief comment clearer (NFC)
IIUC this transforms a node representation of a demangled name to the equivalent string representation. It creates the string itself, and doesn't get the string as a parameter to write into. To me "transform in" was confusing, I think the natural language to use is "transform to".
2016-03-24 12:36:06 +02:00
rjmccall ea0d95ba5d Merge pull request #1808 from danra/patch-18
static_assert that ClusteredBitVector::ChunkType is unsigned instead of just commenting as much.
2016-03-24 00:28:07 -07:00
John McCall abba7f0c8b Revert "Only use metadata patterns for generic types; perform other"
This reverts commit 41efb3d4d3.
LLDB has too many tendrils into our metadata.
2016-03-23 20:26:43 -07:00
Chris Lattner c153c3ab7d Merge pull request #1810 from danra/patch-20
[gardening] Improved comments (NFC)
2016-03-23 17:41:36 -07:00
Chris Lattner 9070697cce Merge pull request #1813 from danra/patch-22
Remove redundant parentheses (NFC)
2016-03-23 17:39:48 -07:00
danra 0623e12452 Add missing commas to multi-line enums
Some of the multi-line enums in the file currently have trailing commas after the last defined value, some don't.
2016-03-24 02:14:17 +02:00
John McCall 41efb3d4d3 Only use metadata patterns for generic types; perform other
initialization in-place on demand.  Initialize parent metadata
references correctly on struct and enum metadata.

Also includes several minor improvements related to relative
pointers that I was using before deciding to simply switch the
parent reference to an absolute reference to get better access
patterns.
2016-03-23 17:04:04 -07:00
danra 891dea4f70 Fix comment typo (NFC) 2016-03-24 00:45:02 +02:00
danra fec14bfb9f Remove redundant parentheses (NFC) 2016-03-23 23:58:08 +02:00
danra 7988864ab1 [gardening] Improved comments (NFC) 2016-03-23 23:39:37 +02:00
danra 98776388d4 Compact getCapacityInBits implementation (NFC) 2016-03-23 22:50:34 +02:00
danra 8134bfd55d static_assert ChunkType is unsigned 2016-03-23 22:26:16 +02:00
Doug Gregor 593932741c Remove historical flags -enable-omit-needless-words/-enable-infer-default-arguments/-enable-swift-name-lookup-tables.
NFC; all of these options are always-on now and we no longer have a
way to turn them off.
2016-03-22 17:04:19 -07:00
Michael Gottesman f79a741a7d Merge pull request #1779 from danra/patch-5
Minor comment fixes
2016-03-22 14:38:13 -07:00
Chris Lattner 74c7d4164c Merge pull request #1794 from danra/patch-16
[gardening] Minor comment fix
2016-03-22 14:18:38 -07:00
Chris Lattner 09fb7226d7 Merge pull request #1793 from danra/patch-15
Add missing comment after .h file #endif
2016-03-22 14:18:10 -07:00
Chris Lattner 0ac95f1ae0 Merge pull request #1784 from danra/patch-10
Added missing 'const' to iterator comp. operators
2016-03-22 14:14:22 -07:00
danra f63f165b54 [gardening] Minor comment fix 2016-03-22 23:09:06 +02:00
Dan Raviv 24113705fe [gardening] Minor comment fixes 2016-03-22 23:06:33 +02:00
danra 5eed1f748b Add missing comment after .h file #endif 2016-03-22 22:59:57 +02:00
Michael Gottesman b094e776b5 Merge pull request #1785 from danra/patch-11
[gardening] Add missing comments
2016-03-22 13:44:24 -07:00
danra 890ff9c9c8 [gardening] Fix comments style 2016-03-22 22:39:30 +02:00
danra f1e68696c9 Add missing comment after .h file #endif 2016-03-22 22:37:30 +02:00
danra d6bb90253c [gardening] Add missing comments 2016-03-22 22:17:19 +02:00
danra 9b258949b3 Added missing 'const' to iterator comp. operators 2016-03-22 22:04:23 +02:00
Dmitri Gribenko 60925272b2 Merge pull request #1781 from danra/patch-7
Add missing comment after .h file #endif
2016-03-22 12:51:38 -07:00
danra 473e97504b [gardening] Add missing comments 2016-03-22 21:45:11 +02:00
danra dac7347dfa Add missing comment after .h file #endif 2016-03-22 21:41:21 +02:00
Chris Willmore 4cc75187c6 [Sema] Flag -disable-infer-iuos: don't infer IUO type for untyped bindings
If this option is enabled, when generating potential bindings for a type
variable, don't propagate IUO type. Instead try the optional type and
the underlying type. This way, untyped bindings will not be given IUO
type when they are initialized with exprs of IUO type.
2016-03-21 17:33:29 -07:00
Michael Gottesman 0e2dc7a930 [arc] Once we have finished an iteration of ARC, clear the ImmutablePointerSetFactory.
Previously due to the way that ARC works, it was impossible to trigger any
memory safety issues. That being said the fact that the memory safety here is
non-obvious suggests that the right thing to do is just bite the bullet and
clear the ImmutablePointerSetFactory.
2016-03-10 18:48:03 -08:00
Max Moiseev 02006f20bc Merge remote-tracking branch 'origin/master' into swift-3-api-guidelines 2016-03-09 16:05:03 -08:00
Michael Gottesman ef6ff01fd8 Use perfect forwarding on the Predicate passed into none_of/count_if.
This ensures that if one wishes to pass an std::moved, std::function into the
functions, one can do that.
2016-03-08 15:07:27 -08:00