Commit Graph

331 Commits

Author SHA1 Message Date
Pavel Yaskevich
b8358b26fe [Mangling] Add mangling for distributed method accessors
`Distributed Method Accessor` is a global helper function
to get access to particular `distributed method` on an actor
from outside the process.
2021-12-17 10:52:55 -08:00
Alastair Houghton
8e56ff7da0 Merge pull request #39922 from al45tair/problem/84615816
[Tests][Demangling] Reduce maximum recursion depth for NodePrinter.
2021-11-18 16:21:50 +00:00
Mike Ash
3000580367 [Test] Only run objc-getClass.cpp against freshly built runtimes.
This tests fixes that aren't available on older runtimes used for back deployment testing.

rdar://84995894
2021-11-04 09:44:06 -04:00
Karoy Lorentey
47956908b7 [Concurrency] SwiftStdlib 5.5 ⟹ SwiftStdlib 5.1 (usages)
The concurrency runtime now deploys back to macOS 10.15, iOS 13.0, watchOS 6.0, tvOS 13.0, which corresponds to the 5.1 release of the stdlib.

Adjust macro usages accordingly.
2021-10-28 14:36:36 -07:00
Alastair Houghton
50c55ce4d9 [Tests][Demangling] Reduce maximum recursion depth for NodePrinter.
At MaxDepth 1024, NodePrinter will blow the stack on a debug build.
Reduce it to 768.

rdar://84615816
2021-10-26 17:12:14 +01:00
Doug Gregor
142973b653 Use a non-conflicting mangling for distributed thunks.
Distributed thunks were using the same mangling as direct method
reference thunks (i.e., for "super" calls). Although not technically
conflicting so long as actors never gain inheritance, it's confusing
and could cause problems in the future. So, introduce a distinct
mangling for distributed thunks and plumb them through the demangling
and remangler.
2021-10-15 23:15:43 -07:00
Alastair Houghton
5c00c7e0fa Merge pull request #39506 from al45tair/problem/82870372
[Remangler] Fix remangling in static bound generic function context
2021-10-02 09:26:24 +01:00
Kuba Mracek
d0e05003f5 For individual runtime records for types/protocols/conformances, add and use new mangling suffixes 2021-09-29 13:14:58 -07:00
Alastair Houghton
1ac9159a81 [Remangler] Fix remangling of items in static bound generic function context
If you had a type alias (for instance) with its context set to a static
bound generic function, the generic arguments were remangled in the wrong
place because Node::Kind::Static wasn't handled properly in a couple of
functions.  Fix that.

rdar://82870372
2021-09-29 14:27:31 +01:00
Alastair Houghton
af13791f5f [Tests][Demangling] Remove the sed.
I can't see why it's going wrong on Windows, and I don't want to turn the test
off just for Windows.  Without the "sed", if the line numbers in the remangler
files change, this test will fail, which is a bit irritating but I suspect
we'll live.

rdar://79725187
2021-09-09 16:02:41 +01:00
Alastair Houghton
bd31af0902 [Demangling] Use basic syntax regex for sed.
Sed on our Windows builders appears to not support extended regex syntax.
Attempt fix by using basic syntax instead.  Also, add a '-e'.

rdar://79725187
2021-09-09 14:09:56 +01:00
Alastair Houghton
59cfe356d5 [Demangling] Improve DEMANGLE_ASSERT, enable some disabled tests.
Defining DEMANGLE_ASSERT as assert() is simple but messes up the file/line
information from assert().  Make a dedicated assertion failure function and use
that instead to fix.

Also enable some tests that were disabled because they triggered abort()
calls in the remanglers.

rdar://79725187
2021-09-07 14:08:29 +01:00
Alastair Houghton
9013083046 [Demangler] Display error codes in various places.
Also fixed a test that broke with the previous commit.

rdar://79725187
2021-09-06 17:49:55 +01:00
Alastair Houghton
cc869b90b1 [Demangling] Remangling error handling for the OldRemangler.
First pass at adding error handling to the OldRemangler.  Still pondering
assert() calls.

rdar://79725187
2021-09-06 17:49:09 +01:00
Alastair Houghton
145f2814a2 [Demangling][Tests] Fix tests after remangler initial error handling.
Fix the tests to work after the Remangler has been fixed to do error handling.

rdar://79725187
2021-09-06 17:49:09 +01:00
Alastair Houghton
e6ced29908 [Demangler] Fix incorrect assertions in OldRemangler and NodePrinter.
There can be, currently, up to eight child nodes for a FunctionType.
OldRemangler seemed to think there could only be three, while NodePrinter
plumped for six.

rdar://82252704
2021-08-27 11:24:19 +01:00
Alastair Houghton
0cd79c5243 [Test] Minor fixes to objc-getclass demangler test
Don't fail the test if the OS version is too old (but still log).

Also, explicitly link with the ObjC library.

rdar://82139957
2021-08-20 11:34:08 +01:00
Alastair Houghton
3fd65ddb7d [Demangler][Tests] Fix linker path to use target-sdk-name.
The swift library directory is named using the SDK name, not the ABI name;
this shows up on iphonesimulator builds, where the two are different.
2021-08-17 16:11:26 +01:00
Alastair Houghton
4b2e31654e [Demangler][Tests] Re-add getObjcClassByMangledName test.
This was reverted in ec3ccd72 because it broke the iOS simulator build.
2021-08-17 09:46:21 +01:00
Mishal Shah
34350e45cd Revert "[Demangler][Tests] Add an explicit test for getObjCClassByMangledName." 2021-08-16 14:00:39 -07:00
Alastair Houghton
8db56f09a3 [Demangler][Tests] Add an explicit test for getObjCClassByMangledName.
Added a special test for getObjCClassByMangledName; this needs testing
separately as it uses the DecodedMetadataBuilder, which doesn't get exercised
by the normal demangling tests.

Added all the test cases from rdar://63485806, rdar://63488139, rdar://63496478,
rdar://63410196 and rdar://68449341.  The test cases from rdar://63485806 are
disabled for now because the problem there is the error handling mechanism (or
lack thereof), rather than us not handling errors.

Fixes the remaining cases from

rdar://63488139
rdar://63496478
2021-08-04 16:21:32 +01:00
Alastair Houghton
f15c2a7848 Merge pull request #38429 from al45tair/problem/80602920
[Demangler] Fix NULL dereference on malformed mangled class name.
2021-07-28 14:18:36 +01:00
Alastair Houghton
c23d2f45c4 [Demangler] Fix NULL dereference on malformed mangled class name.
The (invalid) type name '__TJO' caused a NULL dereference.  Fix that
and add a test case.

rdar://80602920
2021-07-16 14:19:35 +01:00
Alastair Houghton
52ec3d195a Merge branch 'main' into problem/63678072 2021-07-07 07:15:22 +01:00
Alastair Houghton
da9803dddd Merge branch 'main' into problem/63410196 2021-07-06 15:35:31 +01:00
Augusto Noronha
ff7fdc5119 Merge pull request #38160 from augusto2112/mangle-empty-type-list
Mangle empty type lists on anonymous contexts.
2021-07-02 16:51:55 -03:00
Saleem Abdulrasool
e77d5a723a Update recursion-limit.swift
Use the `%diff` substitution to ensure that `--strip-trailing-cr` is used as appropriate to ignore line endings.  This should repair the Windows builders.
2021-07-02 08:17:33 -07:00
Augusto Noronha
9f69f55df0 Mangle an empty type list 2021-07-02 10:18:22 -03:00
Alastair Houghton
779b10daeb [Demangler] Fix OldRemangler's handling of Subscript nodes.
The Subscript node isn't laid-out the way the code in OldRemangler thinks,
which has the unfortunate result of causing crashes.

rdar://63410196
2021-07-02 11:40:20 +01:00
Alastair Houghton
8078cc0c73 Merge pull request #38079 from al45tair/problem/63485806
[Demangler] Fix the name of float vector types in OldDemangler.
2021-07-01 16:54:49 +01:00
Alastair Houghton
deccb339a0 Merge pull request #37998 from al45tair/problem/63678171
[Demangler] Fix OldRemangler to cope with Type nodes
2021-07-01 15:48:31 +01:00
Alastair Houghton
8f717d2c50 [Demangler] Prevent stack overflow by limiting recursion depth.
It's trivially easy to drive the remanglers, the type decoder and the node
printer into a situation where they will overflow the process's stack.  For the
compiler, this is fine (though not great), but for the runtime it's a no-no.

This changeset imposes recursion depth limits to prevent uncontrolled stack
overruns.

rdar://68449341
2021-07-01 11:11:59 +01:00
Alastair Houghton
226c36e861 Merge branch 'main' into problem/63678171 2021-06-25 11:36:55 +01:00
Alastair Houghton
d57cedd7d8 Merge branch 'main' into problem/63678072 2021-06-25 11:36:26 +01:00
Alastair Houghton
7cc10536cc [Demangler] Fix the name of float vector types in OldDemangler.
The OldDemangler was still spelling Builtin.Vec4xFPIEEE16 as
Builtin.Vec4xFloat16, which meant that feeding its output to the new
Remangler caused it to fail with "fatal error: unexpected builtin
vector type".

rdar://63485806
2021-06-24 14:39:25 +01:00
Alastair Houghton
4661deba27 [Demangler] Fix for crash in mangleSingleChildNode.
PartialApplyForwarders can apparently have no children in some cases,
so avoid calling mangleSingleChildNode() if that happens in order to avoid
a crash.

rdar://63678141
2021-06-21 15:51:35 +01:00
Alastair Houghton
35db37f941 [Demangler] Fix OldRemangler to cope with Type nodes in a couple of places.
The Demangler can wrap types in a Node::Kind::Type node; these need to be
handled by following the node's first child pointer.  Failing to do this led to
a crash or assertion failure in some cases.

rdar://63678171
2021-06-21 10:19:24 +01:00
Alastair Houghton
d70e93b92e [Demangler] Fix OldRemangler to cope with single argument functions.
The Demangler can sometimes output ArgumentTuples containing a single argument
without placing that argument inside a Tuple node.  OldRemangler failed to take
account of this and either crashed or failed with an assertion failure depending
on whether assertions were enabled or not.

rdar://63678072
2021-06-19 10:20:02 +01:00
Doug Gregor
4bcd74e86b Update mangling test for optional-printing change 2021-06-08 11:21:30 -07:00
Doug Gregor
58f49692ed Add mangling, metadata, and reflection support for "isolated" parameters.
Isolated parameters are part of function types. Encode them in function
type manglings and metadata, and ensure that they round-trip through
the various mangling and metadata facilities. This nails down the ABI
for isolated parameters.
2021-06-08 00:00:11 -07:00
Alastair Houghton
3d11fb97ab [SR-13466]: Fix demangling of optionals containing function types.
ImplFunctionType nodes inside optionals are wrapped in Type nodes,
which means that isSimpleType() needs to look through the Type node
when we're printing them, or we fail to wrap them with parentheses.

<rdar://67915116>
2021-06-04 20:56:51 +01:00
Doug Gregor
b814e225dd Implement (de-)mangling and type metadata for global actor function types.
Implement name mangling, type metadata, runtime demangling, etc. for
global-actor qualified function types. Ensure that the manglings
round-trip through the various subsystems.

Implements rdar://78269642.
2021-06-02 23:34:22 -07:00
Doug Gregor
b57a73ab42 [Concurrency ABI] Add standard substitutions for _Concurrency types.
Introduce a second level of standard substitutions to the mangling,
all of the form `Sc<character>`, and use it to provide standard
substitutions for most of the _Concurrency types.

This is a precursor to rdar://78269642 and a good mangling-size
optimization in its own right.
2021-06-01 17:15:02 -07:00
Richard Wei
fb66de6126 Unify mangling operators for async, @Sendable, @differentiable and @noDerivative.
Repurpose mangling operator `Y` as an umbrella operator that covers new attributes on function types. Free up operators `J`, `j`, and `k`.

```
async ::= 'Ya'                             // 'async' annotation on function types
sendable ::= 'Yb'                          // @Sendable on function types
throws ::= 'K'                             // 'throws' annotation on function types
differentiable ::= 'Yjf'                   // @differentiable(_forward) on function type
differentiable ::= 'Yjr'                   // @differentiable(reverse) on function type
differentiable ::= 'Yjd'                   // @differentiable on function type
differentiable ::= 'Yjl'                   // @differentiable(_linear) on function type
```

Resolves rdar://76299796.
2021-04-07 17:49:10 -07:00
Richard Wei
82886bf77a [AutoDiff] Fix mangling of '@noDerivative' in function types.
`@noDerivative` was not mangled in function types, and was resolved incorrectly when there's an ownership specifier. It is fixed by this patch with the following changes:

* Add `NoDerivative` demangle node represented by a `k` operator.
    ```
    list-type ::= type identifier? 'k'? 'z'? 'h'? 'n'? 'd'?  // type with optional label, '@noDerivative', inout convention, shared convention, owned convention, and variadic specifier
    ```
* Fix `NoDerivative`'s overflown offset in `ParameterTypeFlags` (`7` -> `6`).
* In type decoder and type resolver where attributed type nodes are processed, add support for nested attributed nodes, e.g. `inout @noDerivative T`.
* Add `TypeResolverContext::InoutFunctionInput` so that when we resolve an `inout @noDerivative T` parameter, the `@noDerivative T` checking logic won't get a `TypeResolverContext::None` set by the caller.

Resolves rdar://75916833.
2021-04-07 15:42:12 -07:00
Nate Chandler
3243def046 Revert "[IRGen] Mangling for async, non-constant partial_apply thunks."
This reverts commit efaaee3656.
2021-04-06 15:51:33 -07:00
Richard Wei
d997526948 Fix function differentiability kind metadata and mangling. (#36601)
* Move differentiability kinds from target function type metadata to trailing objects so that we don't exhaust all remaining bits of function type metadata.
  * Differentiability kind is now stored in a tail-allocated word when function type flags say it's differentiable, located immediately after the normal function type metadata's contents (with proper alignment in between).
  * Add new runtime function `swift_getFunctionTypeMetadataDifferentiable` which handles differentiable function types.
* Fix mangling of different differentiability kinds in function types. Mangle it like `ConcurrentFunctionType` so that we can drop special cases for escaping functions.
    ```
    function-signature ::= params-type params-type async? sendable? throws? differentiable? // results and parameters
    ...
    differentiable ::= 'jf'                    // @differentiable(_forward) on function type
    differentiable ::= 'jr'                    // @differentiable(reverse) on function type
    differentiable ::= 'jd'                    // @differentiable on function type
    differentiable ::= 'jl'                    // @differentiable(_linear) on function type
    ```

Resolves rdar://75240064.
2021-03-30 09:59:06 -07:00
Doug Gregor
52096a640e SE-0302: Rename ConcurrentValue/@concurrent to Sendable/@Sendable. 2021-03-18 23:48:21 -07:00
Nate Chandler
95a508a435 [Test] Mangling of second PAF for a function. 2021-03-15 13:37:38 -07:00
Arnold Schwaighofer
00f495f48c Mangling for suspend/await resume partial functions
We use the suffix 'TQ'index and 'TP'index.
2021-03-15 11:13:22 -07:00