averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity
119,824 Commits 623 Branches 2,949 Tags
9ed732f0ab5258dba0f2bbee0da6a53afa23fb06
Commit Graph

1073 Commits

Author SHA1 Message Date
Holly Borla
9ddb5eddc5 Merge pull request #29065 from hborla/subscript-error-diag 
[Diagnostics] Finish porting subscript errors
 2020-01-08 16:05:04 -08:00
Holly Borla
7e056671a3 [CSGen] Abstract checking for a nil literal in visitSubscriptExpr into a 
general isValidBaseOfMemberRef function.
 2020-01-08 13:36:32 -08:00
Holly Borla
42c73334f0 [CSGen] Diagnose subscripting a nil literal in CSGen. 2020-01-07 17:37:38 -08:00
Pavel Yaskevich
9a62701e95 [ConstraintSystem] Use new branch element and fix mismatch between ternary branches 2020-01-07 13:50:09 -08:00
Doug Gregor
61ac2534e7 [Type checker] Make coercePatternToType return the new Pattern. 
Rather than mutating the parameter pattern in place and separately
return whether an error occurred, return the new pattern or NULL if an
error occurred. While here, switch over to ContextualPattern for the
input.

And get rid of that infernal "goto".
 2020-01-03 17:27:55 -08:00
Doug Gregor
033f9c7927 [Type checker] Introduce "contextual patterns". 
Contextual pattern describes a particular pattern with enough
contextual information to determine its type. Use this to simplify
TypeChecker::typeCheckPattern()'s interface in a manner that will
admit request'ification.
 2020-01-03 15:41:21 -08:00
Doug Gregor
9c8351b206 [Type checker] Make typeCheckPattern() functional. 
Make TypeChecker::typeCheckPattern() return the computed type, rather
than returning an "error" flag. More importantly, make it functional,
so that it doesn't set the type it computes on the pattern.

Use UnresolvedType as a placeholder for types that need to be
inferred, rather than a null type. This allows us to produce
structural types involving types that need to be inferred.

Note that with this change as-is, we get a number of duplicated
diagnostics, because typeCheckPattern() will be called multiple times
for the same pattern and will emit some diagnostics each time. This
will be addressed in a subsequent commit.
 2020-01-03 11:25:05 -08:00
Slava Pestov
bdbe062aa2 Sema: Tweak SanitizeExpr handling of AutoClosureExprs 
Curry thunks create AutoClosureExprs with parameters, and we can't just
fold those away.

Also, remove an older AutoClosureExpr cleanup that seems to be
redundant.
 2019-12-19 23:51:53 -05:00
Pavel Yaskevich
8bcc192591 [Diagnostics] Diagnose inability to infer (complex) closure return type 2019-12-19 12:16:30 -08:00
Brent Royal-Gordon
6a8598a99c [NFC] Remove DeclNameRef staging calls 2019-12-11 00:55:18 -08:00
Brent Royal-Gordon
addbe3e5ed [NFC] Thread DeclNameRef through most of the compiler 
This huge commit contains as many of the mechanical changes as possible.
 2019-12-11 00:55:18 -08:00
Brent Royal-Gordon
63ec1cf5af Introduce a separate #filePath, remove -pound-file 
This makes the path behavior more first-class. The feature is now hidden behind an experimental flag, -enable-experimental-concise-pound-file.
 2019-12-04 16:35:13 -08:00
Pavel Yaskevich
5cacd1bb36 [ConstraintSystem] Fix situations when contextual base type can't be inferred 
It might be either impossible to infer the base because there is
no contextual information e.g. `_ = .foo` or there is something
else wrong in the expression which disconnects member reference
from its context.
 2019-12-03 12:07:16 -08:00
Hamish Knight
19e199e567 Use DefaultArgumentExpr for caller-side defaults (#28279) 
Use DefaultArgumentExpr for caller-side defaults
 2019-12-02 13:57:17 -08:00
Hamish Knight
7edbd9327e [CS] Remove an unused variable 2019-11-27 17:13:50 -08:00
Pavel Yaskevich
e3a4b4ffc9 [ConstraintSystem] Fix ConstraintGenerator to change phase to "constraint generation" and back 2019-11-21 00:08:58 -08:00
Hamish Knight
7e788b8ab9 [AST] Remove CallerDefaultArgumentExpr 
Now that we use DefaultArgumentExpr for both kinds
of default arguments, this is no longer needed.
 2019-11-20 15:07:33 -08:00
Slava Pestov
ef05accd31 Sema: Remove even more vestigial TypeChecker usages 2019-11-19 17:40:00 -05:00
Doug Gregor
2d915f60ab [Constraint solver] Remove expression from the constructor. 
Rather than setting up the constraint solver with a single expression
(that gets recorded for parents/depths), record each expression that
goes through constraint generation.
 2019-11-14 15:41:38 -08:00
Robert Widmann
f4d333d066 Sink a bunch of semantic options into TypeCheckerOptions 
Sink
- DebugConstraintSolver
- DebugConstraintSolverAttempt
- DebugConstraintSolverOnLines
- DebugGenericSignatures
- DebugForbidTypecheckPrefix
- SolverMemoryThreshold
- SolverBindingThreshold
- SolverShrinkUnsolvedThreshold
- SolverDisableShrink
- EnableOperatorDesignatedTypes
- DisableConstraintSolverPerformanceHacks
- SolverEnableOperatorDesignatedTypes
 2019-11-12 22:39:49 -08:00
Robert Widmann
8ff60abf6f Remove unused TypeCheckers 2019-11-12 11:33:13 -08:00
Robert Widmann
efb6117bd8 [NFC] Remove Diagnostic State From TypeChecker 
Push this map into ConstraintSystem and have the search and retrieval chain up the linked list of base constraint systems.
 2019-11-10 22:05:32 -08:00
Robert Widmann
ecb7b8c749 Make convertToType a utility 2019-11-10 13:39:34 -08:00
Robert Widmann
7bad9aacc3 Drop the TypeChecker out of ConstraintSystem 2019-11-10 13:26:47 -08:00
Robert Widmann
1123b1f897 Move constraint satisfiability utilities 2019-11-10 13:12:50 -08:00
Robert Widmann
63896c1fc5 Make more high-level type checking endpoints utility 2019-11-10 13:03:46 -08:00
Hamish Knight
18088b04f0 [AST] Consolidate Obj-C types on ASTContext 
This commit moves the getNSObjectType and
getObjCSelectorType methods from TypeChecker
onto ASTContext. In addition, it moves the
FOR_KNOWN_FOUNDATION_TYPES macro into a separate
file to define each of the Obj-C type decls
we want to have access to.
 2019-11-07 08:26:08 -08:00
Robert Widmann
e6dbfa393a Move Utilities back to TypeChecker 2019-11-06 15:20:46 -08:00
Robert Widmann
8fc054ae5e Remove references to TypeChecker from CSGen 2019-11-06 15:08:59 -08:00
Robert Widmann
c4a0585ba5 Make getObjectLiteralConstructorName a utility 2019-11-06 15:08:59 -08:00
Robert Widmann
51b17470e3 Move the diagnosing entrypoints for intrinsics 2019-11-06 15:08:59 -08:00
Robert Widmann
d9b03a56a9 Merge pull request #28104 from CodaFi/broken-declspec 
[NFC] Drop More Type Checkers
 2019-11-06 07:31:49 -08:00
Pavel Yaskevich
6d02fb7815 Merge pull request #28057 from xedin/assign-diags 
[Diagnostics] Port the rest of assignment diagnostics to the new framework
 2019-11-06 00:11:08 -08:00
Robert Widmann
e15eb472e1 Inline TypeChecker::getExceptionType 2019-11-05 22:52:28 -08:00
Robert Widmann
e804d6ed9a Make TypeChecker::getDefaultType a utility 2019-11-05 20:31:15 -08:00
Robert Widmann
332189e96f Remove TypeCheckers from Pattern resolution 2019-11-05 20:31:15 -08:00
Robert Widmann
c09d4173bb Remove some unused pointers 2019-11-05 20:30:11 -08:00
Robert Widmann
2b08d1b834 [NFC] ASTContext::getLazyResolver -> ASTContext::getLegacyGlobalTypeChecker 2019-11-05 14:44:41 -08:00
Pavel Yaskevich
bba785a7ac [ConstraintSystem] Detect and diagnose standalone nil literals early 2019-11-05 12:38:13 -08:00
Holly Borla
b1638ce1ab [CSGen] Add a tailored diagnostic for conditional casting from a nil literal, 
and diagnose in CSGen.
 2019-11-04 20:49:36 -08:00
Robert Widmann
4996858c4d Re-implement isInvalid for ValueDecls 2019-10-30 15:09:14 -07:00
Robert Widmann
118f68b1be Make getProtocol and getLiteralProtocol static utilities 2019-10-30 12:55:42 -07:00
Robert Widmann
929332e12a Make isAvailabilitySafeForConformance a utility 2019-10-30 12:55:42 -07:00
Robert Widmann
972e755e9b Give ConstraintSystem's outlet to the ASTContext 
Make it less tempting to ask for the type checker embedded into
ConstraintSystem by using the accessor to the ASTContext.
 2019-10-30 12:55:42 -07:00
Robert Widmann
b849e51768 Use operator bool to claw back some readability 2019-10-29 16:56:21 -07:00
Robert Widmann
3e1a61f425 [NFC] Fold The Tri-State In Optional<ProtocolConformanceRef> 
ProtocolConformanceRef already has an invalid state.  Drop all of the
uses of Optional<ProtocolConformanceRef> and just use
ProtocolConformanceRef::forInvalid() to represent it.  Mechanically
translate all of the callers and callsites to use this new
representation.
 2019-10-29 16:55:56 -07:00
Pavel Yaskevich
c4fee1d0c9 [ConstraintSystem] Use new condition element in constraint generation/diagnostics 2019-10-22 15:01:49 -07:00
Pavel Yaskevich
e33a3402cb [ConstraintSystem] Make contextual function type available for matchCallArguments 
Helps diagnostics to avoid digging this type out from locator.
 2019-10-16 10:19:25 -07:00
Slava Pestov
2e558f8c89 Merge pull request #27594 from slavapestov/circular-validation-cleanups-6 
Circular validation cleanups, part 6
 2019-10-12 00:59:21 -04:00
swift-ci
7d437ec4a8 Merge pull request #27629 from DougGregor/builder-refactoring-prelude 2019-10-11 15:35:11 -07:00