Doug Gregor
fd4bcdc007
Add fixed crasher for rdar://problem/30154791.
2017-05-11 09:31:58 -07:00
Doug Gregor
ecdc993881
[Type checker] Tolerate invalid expressions in the error-handling checker.
...
When errors occur in the processing of expressions, we can end up with
invalid ASTs where the application of an operator declared within a
type is missing its "self" argument. Tolerate such ASTs in the
error-handling checker.
2017-05-11 08:57:29 -07:00
Roman Levenstein
f860741b05
Update tests
2017-05-10 16:31:08 -07:00
Nate Cook
f030652cc9
Merge pull request #9462 from natecook1000/nc-dict-keys-compat
...
[stdlib] Provide Swift 3 compatible Dict.keys/values
2017-05-10 15:37:39 -05:00
Nate Cook
b71e2636c4
Update dictionary tests
2017-05-10 11:27:34 -05:00
Nate Cook
bdcf640b59
Updated tests for Dictionary.keys/values
2017-05-10 10:45:08 -05:00
practicalswift
f280b69153
[gardening] Remove "REQUIRES: asserts" from fixed crashers.
2017-05-09 20:46:35 +02:00
Slava Pestov
edb1e97a35
SIL: Remove uncurryLevel from SILDeclRef
...
All we need to store is whether the SILDeclRef directly
references the declaration, or if it references a curry
thunk, and we already have an isCurried bit for that.
2017-05-09 00:56:35 -07:00
swift-ci
6f0ddedfaf
Merge pull request #9219 from xedin/closure-arg-diag
2017-05-08 23:58:36 -07:00
Pavel Yaskevich
ddaccf88bb
[QoI] Properly diagnose closure parameter distructuring after SE-0110
...
Swift 3 supported limited argument destructuring when it comes to
declaring (trailing) closures. Such behavior has been changed by
SE-0110. This patch aims to provide better error message as well
as fix-it (if structure of the expected and actual arguments matches)
to make the migration easier and disambiguate some of the common
mistakes.
Resolves: SR-4738, SR-4745, rdar://problem/31892961.
2017-05-08 23:04:37 -07:00
swift-ci
adccb52a24
Merge pull request #9405 from practicalswift/gardening-20170508
2017-05-08 16:31:04 -07:00
Jordan Rose
01cb554387
Re-apply "Make all CF types Equatable and Hashable." ( #4568 )
...
Like NSObject, CFType has primitive operations CFEqual and CFHash,
so Swift should allow those types to show up in Hashable positions
(like dictionaries). The most general way to do this was to
introduce a new protocol, _CFObject, and then have the importer
automatically make all CF types conform to it.
This did require one additional change: the == implementation that
calls through to CFEqual is in a new CoreFoundation overlay, but the
conformance is in the underlying Clang module. Therefore, operator
lookup for conformances has been changed to look in the overlay for
an imported declaration (if there is one).
This re-applies 361ab62454f50b1e73dchttps://bugs.swift.org/browse/SR-2388
2017-05-08 14:05:11 -07:00
practicalswift
59cf379b17
[gardening] Remove "REQUIRES: asserts" from fixed crashers
2017-05-08 21:51:50 +02:00
practicalswift
eae685c601
[swiftc (34 vs. 5523)] Add crasher in swift::AbstractTypeParamDecl::getSuperclass(...)
...
Add test case for crash triggered in `swift::AbstractTypeParamDecl::getSuperclass(...)`.
Current number of unresolved compiler crashers: 34 (5523 resolved)
/cc @slavapestov - just wanted to let you know that this crasher caused an assertion failure for the assertion `genericEnv != nullptr && "Too much circularity"` added on 2017-03-30 by you in commit a79ef97cf7ff8ce52b/lib/AST/Decl.cpp (L2324)
2017-05-08 15:16:50 +02:00
Ben Cohen
f6f3ed0fe7
Add Collection constraints via protocol where clauses ( #9374 )
2017-05-07 08:55:48 -07:00
Slava Pestov
2fe863266c
AST: Fix crashes when name lookup finds declarations outside of a protocol or extension that's nested in another type
...
When performing a name lookup from inside of a protocol
or extension, skip directly to the source file context
when we are done visiting the protocol or extension.
Otherwise, if we have invalid code where the protocol
or extension is nested inside another type, we might
find a member whose type contains generic parameters
of the outer type; these parameters will not resolve,
since we do not model protocols or extensions nested
inside generic contexts (yet?).
This supercedes an earlier workaround for a similar
issue; the new workaround fixes more crashes.
This is needed to avoid crasher regressions with an
upcoming patch.
2017-05-07 03:01:47 -07:00
Slava Pestov
a21053d5d2
Add a regression test
2017-05-07 01:57:38 -07:00
Max Moiseev
178b9f0b44
[stdlib] Adding bounds check in a.subscript(Index) fast path
...
UnsafeBufferPoiunter subscript used in the fast path only checks bounds
in Debug mode, therefore extra checks are needed.
Addresses: <rdar://problem/31992473>
2017-05-05 15:26:24 -07:00
Graydon Hoare
badf215b82
Use .skip rather than .xfail on unknown-cause stdlib String test (rdar://31992473)
2017-05-05 11:06:45 -07:00
Maxim Moiseev
b93dd6602e
XFAILing the String test to fix the build
2017-05-05 10:38:50 -07:00
Michael Gottesman
77a85f8d2a
Merge pull request #9170 from gottesmm/strip-st-fix
...
[strip -ST] Disable runtime stack trace dumping on Darwin when asserts are disabled.
2017-05-04 18:25:00 -07:00
Michael Gottesman
6bc28ff1c9
[strip -ST] Disable runtime stack trace dumping on Darwin when asserts are disabled.
...
This commit disables runtime stack trace dumping via dladdr on Darwin when
asserts are disabled.
This stack trace dumping was added as a way to improve the ability to debug the
compiler for compiler developers. This is all well and good but having such a
feature always enabled prevents us from reducing the size of the swift standard
library by eliminating the swift nlist.
rdar://31372220
2017-05-04 16:46:26 -06:00
Ted Kremenek
cb7ad7d785
Merge pull request #9162 from phausler/safe_nsnumber
...
[Foundation] Implementation of SE-0170 for safer NSNumber bridging
2017-05-04 13:30:31 -07:00
Philippe Hausler
a9600338c8
[Foundation] Disable more NSNumber test failures due to incorrect float representations
2017-05-04 11:03:20 -07:00
swift-ci
f146e16de0
Merge pull request #9278 from practicalswift/gardening-20170504
2017-05-04 07:20:42 -07:00
practicalswift
2facbde995
[gardening] Remove no longer needed "REQUIRES: asserts"
2017-05-04 15:22:45 +02:00
swift-ci
8610e7a096
Merge pull request #9275 from DougGregor/type-witness-inference-validation
2017-05-04 01:29:52 -07:00
Doug Gregor
3dbfa9789f
[Associated type inference] Check solutions against full requirement signature
...
When we have a potential assignment of associated types to type
witnesses during associated type inference, check that set of type
witnesses against the requirements in the requirement signature, so
that we can reject any solutions that fail some of the protocol's
requirements.
This is most of rdar://problem/31830524 --- but gets thwarted by the
inability of associated type inference to work across multiple
protocols.
2017-05-04 00:21:52 -07:00
Slava Pestov
bf23ed2d18
Add a regression test
2017-05-03 22:31:52 -07:00
swift-ci
c7944cda31
Merge pull request #9240 from practicalswift/swiftc-28746-second-missing-second-type
2017-05-03 15:11:46 -07:00
Doug Gregor
f5c9ee346f
Merge pull request #9158 from natecook1000/nc-devert-dictionary
...
[stdlib] Dictionary/Set enhancements (redux)
2017-05-03 14:07:27 -07:00
practicalswift
7e00d9a6f4
[swiftc (41 vs. 5515)] Add crasher in swift::constraints::ConstraintSystem::addConstraintImpl
...
Add test case for crash triggered in `swift::constraints::ConstraintSystem::addConstraintImpl`.
Current number of unresolved compiler crashers: 41 (5515 resolved)
/cc @DougGregor - just wanted to let you know that this crasher caused an assertion failure for the assertion `second && "Missing second type"` added on 2016-10-20 by you in commit 7519d8306e0cb8418e/lib/Sema/CSSimplify.cpp (L4620)
2017-05-03 22:27:18 +02:00
Philippe Hausler
0011117a20
[Foundation] Work-around ambiguity of initializers by avoiding using bitPattern in literal cases that could be claimed as double values
2017-05-03 12:56:03 -07:00
practicalswift
dcbc2d198c
[swiftc (40 vs. 5515)] Add crasher in swift::Expr::walk(...)
...
Add test case for crash triggered in `swift::Expr::walk(...)`.
Current number of unresolved compiler crashers: 40 (5515 resolved)
/cc @DougGregor - just wanted to let you know that this crasher caused an assertion failure for the assertion `ty->getNominalOrBoundGenericNominal() || ty->is<DynamicSelfType>() || ty->isExistentialType() || ty->is<ArchetypeType>()` added on 2014-02-25 by you in commit 6a532e05c4806e2841f/lib/Sema/CSApply.cpp (L6984)
2017-05-03 21:33:51 +02:00
practicalswift
9e3dc062a3
[swiftc (39 vs. 5515)] Add crasher in swift::GenericEnvironment::mapTypeOutOfContext
...
Add test case for crash triggered in `swift::GenericEnvironment::mapTypeOutOfContext`.
Current number of unresolved compiler crashers: 39 (5515 resolved)
Stack trace:
```
0 0x00000000039d6c48 llvm::sys::PrintStackTrace(llvm::raw_ostream&) (/path/to/swift/bin/swift+0x39d6c48)
1 0x00000000039d7386 SignalHandler(int) (/path/to/swift/bin/swift+0x39d7386)
2 0x00007f89796d7390 __restore_rt (/lib/x86_64-linux-gnu/libpthread.so.0+0x11390)
3 0x000000000150311b swift::GenericEnvironment::mapTypeOutOfContext(swift::GenericEnvironment*, swift::Type) (/path/to/swift/bin/swift+0x150311b)
4 0x00000000013411c2 swift::TypeChecker::coercePatternToType(swift::Pattern*&, swift::DeclContext*, swift::Type, swift::OptionSet<swift::TypeResolutionFlags, unsigned int>, swift::GenericTypeResolver*, swift::TypeLoc) (/path/to/swift/bin/swift+0x13411c2)
5 0x00000000012fdd64 swift::TypeChecker::typeCheckBinding(swift::Pattern*&, swift::Expr*&, swift::DeclContext*, bool)::BindingListener::appliedSolution(swift::constraints::Solution&, swift::Expr*) (/path/to/swift/bin/swift+0x12fdd64)
6 0x00000000012f3999 swift::TypeChecker::typeCheckExpression(swift::Expr*&, swift::DeclContext*, swift::TypeLoc, swift::ContextualTypePurpose, swift::OptionSet<swift::TypeCheckExprFlags, unsigned int>, swift::ExprTypeCheckListener*, swift::constraints::ConstraintSystem*) (/path/to/swift/bin/swift+0x12f3999)
7 0x00000000012f78f1 swift::TypeChecker::typeCheckBinding(swift::Pattern*&, swift::Expr*&, swift::DeclContext*, bool) (/path/to/swift/bin/swift+0x12f78f1)
8 0x00000000012f7ab6 swift::TypeChecker::typeCheckPatternBinding(swift::PatternBindingDecl*, unsigned int, bool) (/path/to/swift/bin/swift+0x12f7ab6)
9 0x000000000130f0e8 validatePatternBindingEntries(swift::TypeChecker&, swift::PatternBindingDecl*) (/path/to/swift/bin/swift+0x130f0e8)
10 0x00000000013095c4 (anonymous namespace)::DeclChecker::visit(swift::Decl*) (/path/to/swift/bin/swift+0x13095c4)
11 0x000000000131990b (anonymous namespace)::DeclChecker::visitExtensionDecl(swift::ExtensionDecl*) (/path/to/swift/bin/swift+0x131990b)
12 0x000000000130954b (anonymous namespace)::DeclChecker::visit(swift::Decl*) (/path/to/swift/bin/swift+0x130954b)
13 0x0000000001309483 swift::TypeChecker::typeCheckDecl(swift::Decl*, bool) (/path/to/swift/bin/swift+0x1309483)
14 0x0000000001389255 swift::performTypeChecking(swift::SourceFile&, swift::TopLevelContext&, swift::OptionSet<swift::TypeCheckingFlags, unsigned int>, unsigned int, unsigned int) (/path/to/swift/bin/swift+0x1389255)
15 0x0000000000f82cb6 swift::CompilerInstance::performSema() (/path/to/swift/bin/swift+0xf82cb6)
16 0x00000000004aa1dd performCompile(std::unique_ptr<swift::CompilerInstance, std::default_delete<swift::CompilerInstance> >&, swift::CompilerInvocation&, llvm::ArrayRef<char const*>, int&, swift::FrontendObserver*, swift::UnifiedStatsReporter*) (/path/to/swift/bin/swift+0x4aa1dd)
17 0x00000000004a89f5 swift::performFrontend(llvm::ArrayRef<char const*>, char const*, void*, swift::FrontendObserver*) (/path/to/swift/bin/swift+0x4a89f5)
18 0x0000000000465567 main (/path/to/swift/bin/swift+0x465567)
19 0x00007f8977be8830 __libc_start_main /build/glibc-9tT8Do/glibc-2.23/csu/../csu/libc-start.c:325:0
20 0x0000000000462c09 _start (/path/to/swift/bin/swift+0x462c09)
```
2017-05-03 18:27:48 +02:00
practicalswift
2b097f0a07
[swiftc (38 vs. 5515)] Add crasher in swift::TypeChecker::substMemberTypeWithBase
...
Add test case for crash triggered in `swift::TypeChecker::substMemberTypeWithBase`.
Current number of unresolved compiler crashers: 38 (5515 resolved)
Stack trace:
```
0 0x00000000039d6c48 llvm::sys::PrintStackTrace(llvm::raw_ostream&) (/path/to/swift/bin/swift+0x39d6c48)
1 0x00000000039d7386 SignalHandler(int) (/path/to/swift/bin/swift+0x39d7386)
2 0x00007f88e1c0e390 __restore_rt (/lib/x86_64-linux-gnu/libpthread.so.0+0x11390)
3 0x000000000137952b swift::TypeChecker::substMemberTypeWithBase(swift::ModuleDecl*, swift::TypeDecl*, swift::Type) (/path/to/swift/bin/swift+0x137952b)
4 0x00000000013364d6 swift::CompleteGenericTypeResolver::resolveDependentMemberType(swift::Type, swift::DeclContext*, swift::SourceRange, swift::ComponentIdentTypeRepr*) (/path/to/swift/bin/swift+0x13364d6)
5 0x000000000137aecf resolveIdentTypeComponent(swift::TypeChecker&, swift::DeclContext*, llvm::ArrayRef<swift::ComponentIdentTypeRepr*>, swift::OptionSet<swift::TypeResolutionFlags, unsigned int>, bool, swift::GenericTypeResolver*, llvm::function_ref<bool (swift::TypeCheckRequest)>*) (/path/to/swift/bin/swift+0x137aecf)
6 0x000000000137a8b3 swift::TypeChecker::resolveIdentifierType(swift::DeclContext*, swift::IdentTypeRepr*, swift::OptionSet<swift::TypeResolutionFlags, unsigned int>, bool, swift::GenericTypeResolver*, llvm::function_ref<bool (swift::TypeCheckRequest)>*) (/path/to/swift/bin/swift+0x137a8b3)
7 0x000000000137bb07 (anonymous namespace)::TypeResolver::resolveType(swift::TypeRepr*, swift::OptionSet<swift::TypeResolutionFlags, unsigned int>) (/path/to/swift/bin/swift+0x137bb07)
8 0x000000000137ba0c swift::TypeChecker::resolveType(swift::TypeRepr*, swift::DeclContext*, swift::OptionSet<swift::TypeResolutionFlags, unsigned int>, swift::GenericTypeResolver*, llvm::function_ref<bool (swift::TypeCheckRequest)>*) (/path/to/swift/bin/swift+0x137ba0c)
9 0x0000000001379fd5 swift::TypeChecker::validateType(swift::TypeLoc&, swift::DeclContext*, swift::OptionSet<swift::TypeResolutionFlags, unsigned int>, swift::GenericTypeResolver*, llvm::function_ref<bool (swift::TypeCheckRequest)>*) (/path/to/swift/bin/swift+0x1379fd5)
10 0x00000000013378b6 checkGenericFuncSignature(swift::TypeChecker&, swift::GenericSignatureBuilder*, swift::AbstractFunctionDecl*, swift::GenericTypeResolver&) (/path/to/swift/bin/swift+0x13378b6)
11 0x0000000001337460 swift::TypeChecker::validateGenericFuncSignature(swift::AbstractFunctionDecl*) (/path/to/swift/bin/swift+0x1337460)
12 0x000000000131d3f5 (anonymous namespace)::DeclChecker::visitFuncDecl(swift::FuncDecl*) (/path/to/swift/bin/swift+0x131d3f5)
13 0x00000000013096a7 (anonymous namespace)::DeclChecker::visit(swift::Decl*) (/path/to/swift/bin/swift+0x13096a7)
14 0x000000000130b438 swift::TypeChecker::validateDecl(swift::ValueDecl*) (/path/to/swift/bin/swift+0x130b438)
15 0x000000000154abbc swift::DeclContext::lookupQualified(swift::Type, swift::DeclName, swift::NLOptions, swift::LazyResolver*, llvm::SmallVectorImpl<swift::ValueDecl*>&) const (/path/to/swift/bin/swift+0x154abbc)
16 0x000000000133c886 swift::TypeChecker::lookupMember(swift::DeclContext*, swift::Type, swift::DeclName, swift::OptionSet<swift::NameLookupFlags, unsigned int>)::$_1::operator()() const (/path/to/swift/bin/swift+0x133c886)
17 0x000000000133c737 swift::TypeChecker::lookupMember(swift::DeclContext*, swift::Type, swift::DeclName, swift::OptionSet<swift::NameLookupFlags, unsigned int>) (/path/to/swift/bin/swift+0x133c737)
18 0x0000000001381c00 diagnoseUnknownType(swift::TypeChecker&, swift::DeclContext*, swift::Type, swift::SourceRange, swift::ComponentIdentTypeRepr*, swift::OptionSet<swift::TypeResolutionFlags, unsigned int>, swift::OptionSet<swift::NameLookupFlags, unsigned int>, swift::GenericTypeResolver*, llvm::function_ref<bool (swift::TypeCheckRequest)>*) (/path/to/swift/bin/swift+0x1381c00)
19 0x000000000137b307 resolveIdentTypeComponent(swift::TypeChecker&, swift::DeclContext*, llvm::ArrayRef<swift::ComponentIdentTypeRepr*>, swift::OptionSet<swift::TypeResolutionFlags, unsigned int>, bool, swift::GenericTypeResolver*, llvm::function_ref<bool (swift::TypeCheckRequest)>*) (/path/to/swift/bin/swift+0x137b307)
20 0x000000000137a8b3 swift::TypeChecker::resolveIdentifierType(swift::DeclContext*, swift::IdentTypeRepr*, swift::OptionSet<swift::TypeResolutionFlags, unsigned int>, bool, swift::GenericTypeResolver*, llvm::function_ref<bool (swift::TypeCheckRequest)>*) (/path/to/swift/bin/swift+0x137a8b3)
21 0x000000000137bb07 (anonymous namespace)::TypeResolver::resolveType(swift::TypeRepr*, swift::OptionSet<swift::TypeResolutionFlags, unsigned int>) (/path/to/swift/bin/swift+0x137bb07)
22 0x000000000137ba0c swift::TypeChecker::resolveType(swift::TypeRepr*, swift::DeclContext*, swift::OptionSet<swift::TypeResolutionFlags, unsigned int>, swift::GenericTypeResolver*, llvm::function_ref<bool (swift::TypeCheckRequest)>*) (/path/to/swift/bin/swift+0x137ba0c)
23 0x0000000001379fd5 swift::TypeChecker::validateType(swift::TypeLoc&, swift::DeclContext*, swift::OptionSet<swift::TypeResolutionFlags, unsigned int>, swift::GenericTypeResolver*, llvm::function_ref<bool (swift::TypeCheckRequest)>*) (/path/to/swift/bin/swift+0x1379fd5)
24 0x000000000130b26a swift::TypeChecker::validateDecl(swift::ValueDecl*) (/path/to/swift/bin/swift+0x130b26a)
25 0x00000000013199bf (anonymous namespace)::DeclChecker::visitTypeAliasDecl(swift::TypeAliasDecl*) (/path/to/swift/bin/swift+0x13199bf)
26 0x000000000130955b (anonymous namespace)::DeclChecker::visit(swift::Decl*) (/path/to/swift/bin/swift+0x130955b)
27 0x000000000131990b (anonymous namespace)::DeclChecker::visitExtensionDecl(swift::ExtensionDecl*) (/path/to/swift/bin/swift+0x131990b)
28 0x000000000130954b (anonymous namespace)::DeclChecker::visit(swift::Decl*) (/path/to/swift/bin/swift+0x130954b)
29 0x0000000001309483 swift::TypeChecker::typeCheckDecl(swift::Decl*, bool) (/path/to/swift/bin/swift+0x1309483)
30 0x0000000001389255 swift::performTypeChecking(swift::SourceFile&, swift::TopLevelContext&, swift::OptionSet<swift::TypeCheckingFlags, unsigned int>, unsigned int, unsigned int) (/path/to/swift/bin/swift+0x1389255)
31 0x0000000000f82cb6 swift::CompilerInstance::performSema() (/path/to/swift/bin/swift+0xf82cb6)
32 0x00000000004aa1dd performCompile(std::unique_ptr<swift::CompilerInstance, std::default_delete<swift::CompilerInstance> >&, swift::CompilerInvocation&, llvm::ArrayRef<char const*>, int&, swift::FrontendObserver*, swift::UnifiedStatsReporter*) (/path/to/swift/bin/swift+0x4aa1dd)
33 0x00000000004a89f5 swift::performFrontend(llvm::ArrayRef<char const*>, char const*, void*, swift::FrontendObserver*) (/path/to/swift/bin/swift+0x4a89f5)
34 0x0000000000465567 main (/path/to/swift/bin/swift+0x465567)
35 0x00007f88e011f830 __libc_start_main /build/glibc-9tT8Do/glibc-2.23/csu/../csu/libc-start.c:325:0
36 0x0000000000462c09 _start (/path/to/swift/bin/swift+0x462c09)
```
2017-05-03 16:06:38 +02:00
Slava Pestov
b5721e8d8e
AST: Remove AnyObject protocol
2017-05-02 19:45:00 -07:00
Robert Widmann
ab9f2805a1
Merge pull request #9180 from CodaFi/cross-pollination
...
Improve multi-file enum diagnostics
2017-05-02 16:46:17 -04:00
Nate Cook
5aed293cde
[stdlib] Fix test for different hash layouts
2017-05-02 15:27:49 -05:00
Robert Widmann
5722984571
Rewrite flattening to be more effective with nested products
2017-05-02 16:09:24 -04:00
Philippe Hausler
d9ae358b05
Rename NSNumber bridge tests to be clear on what they do
2017-05-02 09:30:35 -07:00
Nate Cook
5da1ce032f
[stdlib] Fix order for Dictionary.keys/values tests
2017-05-02 09:48:22 -05:00
Slava Pestov
f3761c1c2e
Reflection: Update for subclass existentials and primitive AnyObject
2017-05-02 02:23:08 -07:00
Slava Pestov
4071346e89
Merge pull request #9173 from slavapestov/anyobject-removal-vol-1
...
AnyObject removal volume 1
2017-05-01 19:14:13 -07:00
Slava Pestov
0d4a0b7dc1
AST: Update ProtocolDecl::requiresClass() for primitive AnyObject
2017-05-01 16:43:51 -07:00
Bob Wilson
32ff6de1cb
Change REQUIRES arguments to work with recent LLVM versions
...
With more recent versions of LLVM (e.g., used with master-next) the
argument of REQUIRES is parsed as an expression. Do not use "rdar"
URLS for these since it confuses lit.
2017-05-01 15:15:22 -07:00
Nate Cook
2e2e4d9bda
Revert "Revert "[stdlib] Dictionary/Set enhancements""
...
This reverts commit 328ebe8567
2017-05-01 16:06:14 -05:00
Ben Cohen
43211b602a
[stdlib] De-gyb sorting ( #9135 )
...
* [stdlib] De-gyb sort algorithms
* [stdlib] Rename Sort.swift.gyb
* Update tests for de-gybbed sort
2017-04-30 18:11:27 -07:00
Arnold Schwaighofer
6c854c2532
[stdlib] Disable failing Lazy.swift.gyb test again
...
rdar://31897334
2017-04-30 15:33:42 -07:00
swift-ci
8fea2f7ac2
Merge pull request #9134 from airspeedswift/delete-dead-code
2017-04-30 08:26:38 -07:00
