Commit Graph

282 Commits

Author SHA1 Message Date
David Ungar
d16ae98e2a Review fixes:
Rename isThereAPrimaryInputWithAFilenameAt to isInputPrimary.
Remove spurious delayed_function_body_parsing.
Simply return type of getOutputFilenamesFromCommandLineOrFilelist.
2017-11-28 13:28:10 -08:00
David Ungar
b4681b154d Incorperate advice from review.
Change “have” routines to “has”.
Use more consistent casing.
Remove spurious “DelayedFunctionParsing” option.
Move debugFail routines to top lexical level.
Rename and reorder declaration of functions in FrontendArgsToOptionsConverter.
Move, reword, and doxygenate comments for some of those functions.
Fix casing on some more setUp* functions.
Return NoneAction instead of existing RequestedAction in FrontendArgsToOptionsConverter::determineRequestedAction.
Remove test names and put in FIXME’s.
Remove “Jordan” from comments & reword.
Reorder if-then arms of FrontendArgsToOptionsConverter::computeOutputFilenames for readability.
Test for empty string instead of equality with “”.
Use hasUnusedModuleDocOutputPath.
Remove optionality from return type of getOutputFilenamesFromCommandLineOrFilelist.
Rename isPrimaryInputAFileAt to isThereAPrimaryInputWithAFilenameAt.
Added a FIXME in doesActionProduceOutput to reflect that some actions actually do not produce output.
2017-11-28 09:21:35 -08:00
David Ungar
b37219f791 Break up ParseFrontendOptions and reorganize module and output files computations. 2017-11-27 20:52:25 -08:00
David Ungar
83ee8cb7f0 Merge pull request #12920 from davidungar/Move-input-conversion
Move input conversion
2017-11-27 17:13:48 -08:00
David Ungar
0b39a883c2 Fix capitalization of setUpForFileAt 2017-11-21 09:48:55 -08:00
Slava Pestov
076d5ee242 Frontend: Remove -delayed-function-body-parsing flag 2017-11-18 11:31:19 -05:00
Slava Pestov
957427fbfc Frontend: Rework delayed parsing mode a bit 2017-11-18 11:08:18 -05:00
David Ungar
3f3d784144 Factor code from tools & move input conversion. 2017-11-14 20:48:59 -08:00
Erik Eckstein
90c21be191 Unify the implementation of optimization mode in various option classes.
This commit is mostly refactoring.

*) Introduce a new OptimizationMode enum and use that in SILOptions and IRGenOptions
*) Allow the optimization mode also be specified for specific SILFunctions. This is not used in this commit yet and thus still a NFC.

Also, fixes a minor bug: we didn’t run mandatory IRGen passes for functions with @_semantics("optimize.sil.never")
2017-11-14 11:25:02 -08:00
Xi Ge
6af5d3c0bf libSyntax: rename KeepTokensInSourceFile to KeepSyntaxInfoInSourceFile. 2017-11-03 18:39:01 -07:00
David Ungar
7d637c856c Merge pull request #12335 from davidungar/primaryFilesMode-Inputs-rebased
NFC: First step (refactoring) towards speeding up compilation w/ >1 primary file
2017-10-10 12:55:55 -07:00
David Ungar
47ee930a50 git-clang-format'ed 2017-10-08 23:56:03 -07:00
David Ungar
c1821755de NFC: First step (refactoring) towards speeding up compilation by having multiple primary files: Creates new class, FrontendInputs, to encapsulate InputFilenames, InputBuffers, and PrimaryInput, which were formerly in FrontendOptions. Add new instance variable, Inputs, to FrontendOptions in order to hold FrontendInputs.
Encapsulate uses of the variables in FrontendInputs with intention-describing functions. Move some code that sets these variables into FrontendInputs and FrontendOptions classes.

Create new FrontendInputs class to encapsulate InputFilenames, InputBuffers and PrimaryInput, which were formerly in Frontend.

Includes one change in SwiftEditor.cpp to resolve a merge conflict.
2017-10-08 10:20:37 -07:00
Roman Levenstein
5e67f755e0 Remove the -sil-serialize-all option 2017-10-04 14:20:53 -07:00
David Ungar
4ca60fe6d5 Back off the WholeModule change to CompilerInstance::createSILModule()
(May be needed in this form for sil-opt.)
2017-09-22 16:51:49 -07:00
David Ungar
097dd71ffe Simple fixes per Jordan's comments:
- Use isWholeModuleCompilation in CompilerInstance::createSILModule
- Remove some unneeded timers
- Improve the comment in CompilerInstance::parseAndCheckTypes
- Remove needless const ref to an llvm::function_ref parameter in forEachSourceFileIn
- Remove "OfFile" from "finishTypeCheckingOfFile"
2017-09-21 20:18:34 -07:00
David Ungar
edac126f93 git-clang-format 2017-09-19 17:00:04 -07:00
David Ungar
42b04a8a9b Merged checkTypesWhileParsingMain into its caller. 2017-09-19 16:57:45 -07:00
David Ungar
fef5551fdb Added consts to implicitImports refs & fixed dangling new in computeDelayedParsingCallback.
# Conflicts:
#	lib/Frontend/Frontend.cpp
2017-09-19 16:57:45 -07:00
David Ungar
3d2484af28 git-clang-format
# Conflicts:
#	lib/Frontend/Frontend.cpp
2017-09-18 14:02:50 -07:00
David Ungar
0df6ade475 Emission of error_doing_code_completion up to caller 2017-09-18 14:01:58 -07:00
David Ungar
673af9be21 Moved forEachSourceFile out of module to Frontend.cpp 2017-09-18 14:01:57 -07:00
David Ungar
4653c92e25 Renamed finishTypeCheckingMainModule to finishTypeChecking
# Conflicts:
#	lib/Frontend/Frontend.cpp
2017-09-18 14:01:57 -07:00
David Ungar
0787be754b Renamed finishTypeChecking to finishTypeCheckingOfSourceFile
To free up that name
2017-09-18 14:01:12 -07:00
David Ungar
a75d0e8963 git-clang-format 2017-09-14 17:10:43 -07:00
David Ungar
83cbde8a8c Fix compilation bugs I introduced while rebasing 2017-09-14 17:08:23 -07:00
David Ungar
01c54fe13d git-clang-format 2017-09-14 16:58:06 -07:00
David Ungar
cb80010216 Jordan's comments
Use function_ref
Rename generateOutputForTheWholeModule
Constify createRELPFile
Rename typeCheckMainModule
Move shouldImportSwiftOnoneModule
Rename timer in performTypeChecking
2017-09-14 16:58:06 -07:00
David Ungar
ba536b1fc7 format 2017-09-14 16:58:06 -07:00
David Ungar
7b7c62917d Abstract forEachFileToTypeCheck
# Conflicts:
#	lib/Frontend/Frontend.cpp
2017-09-14 16:58:05 -07:00
David Ungar
8057dea43e Removed redundant predicate. 2017-09-14 16:56:32 -07:00
David Ungar
3839697201 format 2017-09-14 16:56:32 -07:00
David Ungar
da79632eaf Pull out parseAndCheckTypes
They were the only computations using PersistentState and DeclayedCB
2017-09-14 16:56:32 -07:00
David Ungar
7e2ae51f18 Discard redundant comment 2017-09-14 16:56:32 -07:00
David Ungar
e797092dbf Moved comment, removed & from a StringRef 2017-09-14 16:56:31 -07:00
David Ungar
51b4746271 Remove redundant early return. 2017-09-14 16:56:31 -07:00
David Ungar
37215e1bb0 Formatted 2017-09-14 16:56:31 -07:00
David Ungar
7ee32c2e09 Remove bogus comma 2017-09-14 16:56:31 -07:00
David Ungar
33aa6eb066 Change 'typeCheckEveryFileInMainModule' to 'typeCheckEveryFile'
# Conflicts:
#	lib/Frontend/Frontend.cpp
2017-09-14 16:56:31 -07:00
David Ungar
042800c6e1 Remove 'const' in 'const OptionSet'
# Conflicts:
#	lib/Frontend/Frontend.cpp
2017-09-14 16:55:21 -07:00
David Ungar
356f47c991 delete 'the' from 'parseAndTypeCheckTheMainFile' 2017-09-14 16:54:32 -07:00
David Ungar
a3b023b160 git-clang-formatted
# Conflicts:
#	lib/Frontend/Frontend.cpp
2017-09-14 16:54:32 -07:00
David Ungar
e800e57c80 Delete first 'a' from 'parseALibraryFile' 2017-09-14 16:53:17 -07:00
David Ungar
09df5d7ebb Change "createMainFileWithImportsAndAddToModule" to "addMainFileToModule" 2017-09-14 16:53:17 -07:00
David Ungar
0386e69f13 Make lifetime explicit for delayed parsing callback. 2017-09-14 16:53:17 -07:00
David Ungar
396def8fd0 Shorted "createREPLFileWithImports" 2017-09-14 16:53:17 -07:00
David Ungar
9b2faa03dd Shorten fillInModulesToImportFromImplicitImportModuleNames 2017-09-14 16:53:16 -07:00
David Ungar
add13798be Separated out the Onone module handling from stdlib handling
Also refactored the Onone module predicate. I believe there is no functional change, but I don't understand the correctness of what was there.
2017-09-14 16:53:16 -07:00
David Ungar
249718e1bd Consolidate performWholeModuleTypeChecking and finishTypeCheckingMainModule into typeCheckMainModule 2017-09-14 16:53:16 -07:00
David Ungar
266007bee3 Don't pass clangImporter 2017-09-14 16:53:16 -07:00