Commit Graph

15937 Commits

Author SHA1 Message Date
Joe Groff
50ccf825f2 AST: Try to reduce and canonicalize order of same-type constraints in mangling signature.
Not quite there yet, because of various problems in ArchetypeBuilder: it doesn't consistently pick representatives in same-type groups, doesn't always mark redundant equivalences it introduces, and improperly injects archetypes into concrete types.

Swift SVN r28254
2015-05-07 04:04:08 +00:00
Chris Willmore
cfd450391b Don't mutate defaultArgsOwner with getCallerDefaultArg() directly, so we
can make a more precise assertion that all default arguments have the
same owner.

<rdar://problem/20749423> Compiler crashed while building simple subclass code

Swift SVN r28251
2015-05-07 01:18:24 +00:00
Chris Lattner
ddddc88808 simplify some code.
Swift SVN r28249
2015-05-07 00:41:02 +00:00
Adrian Prantl
f18d802c19 Debug Info: Emit the error result argument.
If a function has an error result slot, emit debug info for an artificial
function argument "$error" with indirect storage that holds a pointer
to the error object address.

<rdar://problem/20736999> lldb needs to be able to locate the error return location when stepping out of a function

Swift SVN r28229
2015-05-07 00:29:40 +00:00
Doug Gregor
f2e66d1cd7 Break recursion when deserializing constrained protocol extensions.
When reading the generic parameters of a constrained protocol
extension, cross-refencing an associated type would perform name
lookup into the protocol extension itself, causing fatal recursion
during deserialization. Fixed by avoiding additional deserialization
when looking for an associated type. Fixes rdar://problem/20812303.

Swift SVN r28228
2015-05-06 23:56:58 +00:00
John McCall
36c605f7dc Remove ScalarToTupleExpr in favor of a flag on TupleShuffleExpr.
Also, implement in-place initialization through tuple shuffles.

Swift SVN r28227
2015-05-06 23:44:26 +00:00
Jordan Rose
660f8443cb [ClangImporter] Handle missing cases introduced in r28216.
Not sure how I missed this, sorry!

Swift SVN r28226
2015-05-06 23:38:32 +00:00
Chris Lattner
37f5452d15 require -> guard.
Swift SVN r28223
2015-05-06 22:53:38 +00:00
Doug Gregor
a99e995094 Validate an associated type before looking at its default definition.
No test case; this triggers on Basis and is extremely hard to minimize
outside of a large project. Fixes rdar://problem/20829839.

Swift SVN r28222
2015-05-06 22:52:35 +00:00
Joe Pamer
3b57cabae7 Consider default argument patterns, as they relate to actual arguments, when deciding on a specific overload to favor for a function application. Doing so addresses another class of exponential behavior bugs in the type checker (rdar://problem/19779591 and rdar://problem/20772053). There's still some work left to do, though - hence the change to Concatenate.swift, to work around rdar://problem/20789500.
Swift SVN r28221
2015-05-06 22:32:07 +00:00
Chris Lattner
ea52d4fbc7 fix <rdar://problem/20749592> Conditional Optional binding hides compiler error
Swift SVN r28220
2015-05-06 22:12:34 +00:00
Joe Groff
ab09922966 Runtime/IRGen: Replace the _SwiftNativeNS*Base +load hack with a compiler hack.
Rather than swizzle the superclass of these bridging classes at +load time, have the compiler set their ObjC runtime base classes, using a "@_swift_native_objc_runtime_base" attribute that tells the compiler to use a different implicit base class from SwiftObject. This lets the runtime shed its last lingering +loads, and should overall be more robust, since it doesn't rely on static initialization order or deprecated ObjC runtime calls.

Swift SVN r28219
2015-05-06 22:00:59 +00:00
Xi Ge
be33b9edb3 [InterfacePrinting] Avoid duplicating @autoclosure and @noescape when printing module interfaces.
rdar://20657950

Swift SVN r28217
2015-05-06 21:51:23 +00:00
Jordan Rose
cc346aaa75 [ClangImporter] Handle CF_RETURNS_[NOT_]RETAINED on parameters.
By declaring the parameter's retain count convention, we can avoid the
use of Unmanaged. (See test cases for more examples.)

The last piece of this puzzle is offering a sugared overload with multiple
return values (rdar://problem/20436785) but that will have to wait.

This requires changes to Clang; please update.

rdar://problem/20436757

Swift SVN r28216
2015-05-06 20:03:43 +00:00
Joe Groff
73dfea0ba0 ClangImporter: Import option sets as conforming to OptionSetType.
This is pretty much a simplification of the existing RawOptionSetType logic; now, instead of generating a bunch of implicit decls, we provide the minimum set of declarations from which the stdlib will be able to generate default implementations of everything else. The new imported declaration looks like this:

struct MyOptions: OptionSetType {
  let rawValue: UInt // or whatever raw type
  init(rawValue: UInt)

  static var A: MyOptions { return MyOptions(rawValue: 1) }
  static var B: MyOptions { return MyOptions(rawValue: 2) }
  /* etc. */
}

Still hidden behind a staging flag, until the stdlib implementation can land.

Swift SVN r28213
2015-05-06 19:45:52 +00:00
Chris Willmore
f3670d3a6f When adding '!' in fix-it, make sure that it doesn't fall into the
optional evaluation context that produced the optional.

<rdar://problem/20377684> Oscillating fixit for optional chain calling method that returns non-optional

Swift SVN r28212
2015-05-06 19:05:45 +00:00
Arnold Schwaighofer
f506d1e0aa Don't import stdlib_binary_only declarations as shared_external since we don't
link the body. Mark such declarations as public_external.

rdar://20829332

Swift SVN r28211
2015-05-06 18:11:39 +00:00
Joe Groff
c52a019f49 Quiet warnings about new KnownProtocolKind.
Swift SVN r28210
2015-05-06 17:17:31 +00:00
Doug Gregor
a924e06025 Don't require 'Self.' within the where clause of a constrained extension.
Within the where clause of a constrained (protocol) extension, allow
us to find associated types of that protocol and anything it inherits
via unqualified lookup, e.g.,

  extension SequenceType where Generator.Element : Equatable { }

rather than

  extension SequenceType where Self.Generator.Element : Equatable { }

Implements rdar://problem/20722467.

Swift SVN r28208
2015-05-06 17:05:28 +00:00
Doug Gregor
83d336e714 Stop using TupleTypeElts in the type checking for arg/param matching.
Instead, use a dedicated struct. NFC

Swift SVN r28207
2015-05-06 17:05:27 +00:00
Joe Groff
92cb2d1d05 Staging option for NS_OPTIONS importer changes.
NFC yet.

Swift SVN r28204
2015-05-06 16:48:59 +00:00
Adrian Prantl
301aae1492 Promote the "true"-Scope of a condition to an actual lexical scope.
<rdar://problem/20394204> Scoping of if/let declarations too broad

Swift SVN r28203
2015-05-06 16:40:11 +00:00
Chris Willmore
6263024a91 Coerce UnresolvedMemberExpr to its assigned type if it has an argument,
since the type might not match the return type of the function exactly
in that case (CSGen only emits a conversion constraint).

<rdar://problem/20087517> Crash when using .staticShorthand syntax with NSColor/UIColor factories

Swift SVN r28200
2015-05-06 08:25:05 +00:00
Enrico Granata
3386d89af4 When demangling as string type names that come from module names of the form __lldb_expr_<something> in a Swift program, hide the module
The __lldb_expr modules are special as in they are autogenerated by LLDB and meant to not be user-accessible, so showing them adds visual noise for no user benefit

I am open to the notion of adding a flag to swift-demangle to the same effect, but that seems much lower priority



Swift SVN r28195
2015-05-06 02:49:08 +00:00
Roman Levenstein
984fcef576 Produce an error for generic parameters of functions if those parameters are not used in function signature.
If a generic parameter is not referred to from a function signature, it can never be inferred and thus such a function can never be invoked.

We now produce the following error:

generic parameter 'T' is not used in function signature
func f8<T> (x: Int) {}

This commit takes Jordan't comments on r28181 into account:
- it produces a shorter error message
- it does not change the compiler_crashers_fixed test and add a new expected error instead

Swift SVN r28194
2015-05-06 02:20:39 +00:00
Roman Levenstein
a3a25000ff Revert "Produce an error for generic parameters of functions if those parameters are not used in function signature."
This reverts commit r28181. I'll change it according to Jordan's comments and re-commit.

Swift SVN r28193
2015-05-06 02:20:36 +00:00
Joe Groff
bbf2e6dd4b Revert "IRGen: Use acquire semantics to load the inline "once" predicate."
This reverts commit r28178. We should do what dispatch_once does in C.

Swift SVN r28192
2015-05-06 01:29:18 +00:00
Joe Groff
e7547adabd AST: Initial work to canonicalize generic signatures for mangling.
Currently GenericSignature::getCanonicalSignature isn't able to canonicalize the set of requirements due to fragile dependencies on generic signatures matching AllArchetypes order of their originating GenericParamLists. However, we shouldn't let that stop us from getting the mangling right, so implement a "getCanonicalManglingSignature" that builds the true canonical signature by feeding it into an ArchetypeBuilder and shedding unnecessary constraints. For now, just handle conformance and base class constraints; still to do are same-type constraints.

Swift SVN r28191
2015-05-06 01:29:15 +00:00
Joe Groff
898f8c5c94 Add a staging option for interface type mangling.
NFC yet.

Swift SVN r28190
2015-05-06 01:29:10 +00:00
Manman Ren
e94aae06da [Function Attribute] add target-cpu and target-features sets if they're non-null.
All llvm::Functions created during IRGen will have target-cpu and target-features
attributes if they are non-null.

Update testing cases to expect the attribute in function definition.
Add testing case function-target-features.swift to verify target-cpu and
target-features.

rdar://20772331


Swift SVN r28186
2015-05-05 23:19:48 +00:00
Dmitri Hrybenko
0453656f31 Adapt to Foundation API modernization: NSRectEdge is now an enum
This commit adds the initializers requested in rdar://20169260.

Swift SVN r28185
2015-05-05 22:50:59 +00:00
Roman Levenstein
ebe3fddbe6 Produce an error for generic parameters of functions if those parameters are not used in function signature.
If a generic parameter is not referred to from a function signature, it can never be inferred and thus such a function can never be invoked.

We now produce the following error:

There is no way to infer the generic parameter 'T' if it is not used in function signature
func f8<T> (x: Int) {}
             ^

Swift SVN r28181
2015-05-05 21:02:11 +00:00
Jordan Rose
88c9ab591f Make sure we validate the synthesized accessors for NSManaged properties.
(as well as those for lazy properties, which seem to be working already)

This fixes a problem with @NSManaged properties being declared in an
extension in a generated file you're not supposed to modify, which
unfortunately is exactly how Xcode's generating them these days.

rdar://problem/20821582

Swift SVN r28180
2015-05-05 20:02:12 +00:00
Jordan Rose
edf1958f86 Sema: ParamDecls never get accessors.
No functionality change; they wouldn't have ever hit either of the cases
later either.

Swift SVN r28179
2015-05-05 20:02:09 +00:00
Joe Groff
8e4c83fcac IRGen: Use acquire semantics to load the inline "once" predicate.
This is free on x86_64, and saves us from relying on unspoken architectural assumptions on ARM.

Swift SVN r28178
2015-05-05 19:51:39 +00:00
Ben Langmuir
e603126dc0 Factor out copying code completion results from one sink to another
We'll need to be able to do this in the client once we expose caching.

Swift SVN r28176
2015-05-05 19:02:17 +00:00
Ben Langmuir
c40100af66 Factor use of the CodeCompletion sys::Cache into get() and set() methods
Now get() and set() manage determining whether the results are stale,
and getResults() can just rely on that.

Also drive-by fix a data race where we were inserting our results sink
into the cache before it was finished being modified.

Swift SVN r28175
2015-05-05 19:02:16 +00:00
Ben Langmuir
563cd0acf0 Lift the code completion cache interface into the header
The only part that's hidden is the sys::Cache itself now.

Swift SVN r28174
2015-05-05 19:02:15 +00:00
Ben Langmuir
e39fb7224e Expose a libIDE function to lookup the completions for a module
We'll need this in order to move code completion result caching into the
client.

Swift SVN r28173
2015-05-05 19:02:13 +00:00
Michael Gottesman
96634b4be6 Add a SILBuilder::emitDestroyAddr API that returns a pointer union and use it to implement SILBuilder::emitDestroyAddrAndFold.
Now on SILBuilder, destroy_addr has an API that matches the APIs for
strong_release and release_value.

Done at Chris's request.

Swift SVN r28170
2015-05-05 17:23:11 +00:00
Doug Gregor
834b1f0bab Remove code I didn't mean to commit in r28167.
Swift SVN r28169
2015-05-05 17:12:30 +00:00
Joe Groff
220dc2c722 IRGen: Make the target OnceDone predicate value 32-bit-safe.
Thanks John.

Swift SVN r28168
2015-05-05 16:44:13 +00:00
Doug Gregor
6e114e3cfe Reinstate r26814: Allow 'var' parameters in @objc methods.
'var' parameters affect the definition of the method itself, not its
signature. Fixes rdar://problem/20543054.

Swift SVN r28167
2015-05-05 16:34:09 +00:00
Joe Groff
7b2a6e5e8d IRGen: Emit the "done" check for Builtin.once inline.
This matches how dispatch_once works in C, dramatically cutting the cost of a global accessor by avoiding the runtime call in the hot path and giving the global a unique branch for the CPU to predict away. For now, only do this for Darwin; non-ObjC platforms don't necessarily expose their "done" value as ABI like ours do.

While we're here, change "once" to take a thin function pointer. We don't ever emit global initializers with context dependencies, and this simplifies the runtime glue between swift_once and dispatch_once/std::call_once a bit.

Swift SVN r28166
2015-05-05 15:35:57 +00:00
Chris Lattner
6a5009e0ce implement <rdar://problem/17013042> T! <-> T? conversions should not produce a diamond
Two pieces to this: 
 - Peephole OptionalEvaluationExpr(InjectOptionalExpr(BindOptionalExpr(X))) to  bitcast x to the result type. 
 - Enhance OptionalEvaluationExpr to delete the failure block if not needed.  

This is the same as r28150, but it includes a fix for the case when a non-address-only type
is initializing a contextally-provided-and-addressible buffer, tested by the new 
testContextualInitOfNonAddrOnlyType testcase.



Swift SVN r28153
2015-05-05 05:39:17 +00:00
Chris Lattner
90385937f2 remove some dead code, change the text of a theoretically dead diagnostic in case it ever comes up.
Swift SVN r28152
2015-05-05 05:20:40 +00:00
Chris Lattner
9eb115fadf revert r28150, the perftestsuite isn't happy.
Swift SVN r28151
2015-05-05 05:16:23 +00:00
Chris Lattner
1ffe86b327 implement <rdar://problem/17013042> T! <-> T? conversions should not produce a diamond
Two pieces to this:
 - Peephole OptionalEvaluationExpr(InjectOptionalExpr(BindOptionalExpr(X))) to 
   bitcast x to the result type.
 - Enhance OptionalEvaluationExpr to delete the failure block if not needed.

This is the same as r28111, except that we finalize the initialization in the
address-only case.  A reduced testcase for the specific issue is added to
optional-casts.swift.



Swift SVN r28150
2015-05-05 05:01:22 +00:00
Adrian Prantl
2aff7e78d7 Debug Info: Mangle the AST type instead of the SIL type for local variables
and function arguments.

<rdar://problem/20565180> Debug info should not expose ImplFunctionType

Swift SVN r28148
2015-05-05 03:50:28 +00:00
Manman Ren
ac15eedafb [Bitcode Driver] we allow -parse-stdlib in BackendJobAction.
Testing case will be checked in soon.

rdar://20796819


Swift SVN r28146
2015-05-05 02:36:54 +00:00