4f13dedc93
Add and enable an AccessEnforcementWMO pass.
...
Remove dynamic access checks for global variables and and class properties that
have been proven by earlier analysis never to conflict with nested access.
This only applies "-O -enforce-exclusivity=checked" builds. By default, it is
currently NFC.
These are the most important improvements:
RecursiveOwnedParameter -93.7% **15.75x**
ReversedArray -89.1% **9.17x**
ReversedDictionary -81.0% **5.28x**
ArrayInClass -74.3% **3.89x**
Ary3 -71.7% **3.54x**
Random -66.2% **2.96x**
StringWalk -63.5% **2.74x**
LevenshteinDistance -55.4% **2.24x**
Voronoi -50.0% **2.00x**
HashTest -47.7% **1.91x**
Richards -46.7% **1.88x**
NopDeinit -44.8% **1.81x**
Rectangles -41.3% **1.70x**
MultiFileTogether -33.1% **1.50x**
MultiFileSeparate -32.8% **1.49x**
SetIntersect_OfObjects -26.5% **1.36x**
Ary2 -22.7% **1.29x**
Prims -21.9% **1.28x**
PrimsSplit -21.8% **1.28x**
SetExclusiveOr_OfObjects -19.4% **1.24x**
ObjectAllocation -18.6% **1.23x**
DropFirstAnySeqCRangeIterLazy -17.2% **1.21x**
DropFirstAnySeqCRangeIter -17.2% **1.21x**
Dictionary4OfObjects -16.5% **1.20x**
SetUnion_OfObjects -15.3% **1.18x**
DropWhileCountableRangeLazy -15.3% **1.18x**
CharIndexing_[*]_Backwards -14.6% **1.17x**
(all 17 variants of CharIndexing are -14%, 1.17x)
CharIteration_[*]_Backwards -14.3% **1.17x**
(all 17 variants of CharIteration take 14%, 1.17x)
RGBHistogramOfObjects -14.2% **1.17x**
DeltaBlue -13.5% **1.16x**
CharacterPropertiesPrecomputed -12.4% **1.14x**
DictionarySwapOfObjects -9.9% **1.11x**
ClassArrayGetter -9.8% **1.11x**
DictionaryGroupOfObjects -7.9% **1.09x**
DictionaryRemoveOfObjects -7.2% **1.08x**
Dictionary4OfObjectsLegacy -6.8% **1.07x**
Havlak -6.4% **1.07x**
COWTree -6.2% **1.07x**
Radix2CooleyTukeyf -5.6% **1.06x**
2018-06-29 17:56:56 -07:00
628052810e
Simplify AccessEnforcementOpts by leaving access markers in place.
...
The extra cost of deterministically deleting instructions is unnecessary. In the
long term, we'll want to verify that access markers exist after all SIL
passes. So just change their enforcement level rather than removing them.
2018-05-24 22:18:24 -07:00
0aa2eae2e7
AccessEnforcementOpts high-level comments.
2018-05-24 22:18:24 -07:00
0d3cf75c71
Fix AccessEnforcementOpts in debug builds.
2018-05-24 14:36:19 -07:00
c5475c9442
AccessEnforcementOpts test cases.
2018-05-24 00:27:00 -07:00
df1b9b404e
Rework AccessEnforcementOpts SparseSet.
...
This makes the intention more clear and sets up
a new optimization to merge access scopes.
2018-05-23 09:23:39 -07:00
8d67ce18d0
Teach AccessEnforcementOpts to eliminate checks.
...
Previously, it only folded begin/end access into a single runtime
operation. When all accessed for a uniquely identified storage object
have been folded, then they can all be removed.
Reworked the design of the pass so this falls out naturally just by
updating AccessedStorageAnalysis.
2018-05-23 09:23:39 -07:00
7fc2d6267b
Rename findAccessedStorageOrigin() to findAccessedStorageNonNested().
2018-05-15 12:29:19 -07:00
495d5aecf6
[exclusivity] Add an access marker folding pass.
...
Use AccessedStorageAnalysis to find access markers with no nested conflicts.
This optimization analyzes the scope of each access to determine
whether it contains a potentially conflicting access. If not, then it
can be demoted to an instantaneous check, which still catches
conflicts on any enclosing outer scope.
This removes up to half of the runtime calls associated with
exclusivity checking.
2018-05-15 12:29:19 -07:00
Andrew Trick