Alex Hoppen
e538a5ed61
[SourceKit] Merge RenameLoc and RenameLocation
...
It’s easier to understand the code if we don’t have these two nearly, but not quite, identical types.
2023-12-06 14:33:14 -08:00
Alex Hoppen
a710111001
[SourceKit] Support building sourcekitd without building swift-syntax
...
This allows building sourcekitd and swift-refactor with `SWIFT_BUILD_SWIFT_SYNTAX=NO`. In these builds, the `relatedidents` and `find-syntactic-rename-ranges` requests will always return an error.
2023-12-04 19:14:01 -08:00
Alex Hoppen
bc5cc43a06
Don’t include <vector> in IDEBridging.h
2023-11-28 14:04:37 -08:00
Alex Hoppen
d224549030
[SourceKit] Don’t use C++ to Swift interop to run NameMatcher
2023-11-20 11:30:18 -08:00
Alex Hoppen
8fd025625b
[SourceKit] Use NameMatcher that is rewritten in Swift for syntactic rename
2023-11-17 09:30:04 -08:00
Alex Hoppen
1047328b63
[SourceKit] Lowercase members of ResolvedLoc
...
This type will get exposed to Swift and the members should be lowercase so that they read nicely in Swift.
2023-11-16 16:05:08 -08:00
Alex Hoppen
899368037c
[SourceKit] Return results from rename using return values instead of consumers
...
This makes it a lot easier to follow the code.
2023-11-16 16:05:08 -08:00
Alex Hoppen
ec267e2c08
[SourceKit] Hide RenameRangeDetailCollector as an implementation detail
...
The usage becomes a lot clearer if there’s just a top-level function that returns the details for the syntactic rename ranges.
2023-11-16 16:05:08 -08:00
Alex Hoppen
a0313e3005
[SourceKit] Merge Renamer and RenameRangeDetailCollector
...
With `TextReplacementsRenamer` gone, `RenameRangeDetailCollector` was the only remaining subclass of `Renamer`.
2023-11-16 16:05:08 -08:00
Alex Hoppen
bfad46d524
[SourceKit] Remove the -syntactic-rename option from swift-refactor
...
With the local refactoring being removed, all production refactoring paths return a set of ranges to rename and don’t apply edits to the file. Thus, the `syntactic-rename` action also doesn’t make sense anymore.
2023-11-16 16:05:08 -08:00
Alex Hoppen
ba06b5c075
[SourceKit] Replace UnresolvedLoc by SourceLoc
...
`UnresolvedLoc` was just a wrapper around `SourceLoc` and isn’t needed anymore.
2023-11-16 16:05:08 -08:00
Alex Hoppen
b3ab9bffd5
[SourceKit] Remove UnresolvedLoc.ResolveArgLocs
...
AFAICT we can just infer whether to resolve arguments based on the presence of arguments. We don’t need the information to be passed in.
2023-11-16 16:05:07 -08:00
Alex Hoppen
d095d0a186
[SourceKit] Remove newName from RenameLoc
...
We should (and do) have one new name for the entire rename operation, not a separate new name for different positions at which the renamed symbol occurs.
2023-11-16 16:05:07 -08:00
Alex Hoppen
ada3076628
[SourceKit] Share implemention of local rename and related idents
...
Local rename and related identifiers were sufficiently similar that we can implement related identifiers in terms of local rename.
2023-11-16 16:05:07 -08:00
Alex Hoppen
55b3404660
[Refactoring] Move syntactic rename to its own file
2023-09-26 20:14:22 -07:00
