Commit Graph

1066 Commits

Author SHA1 Message Date
swift-ci
ecf1e10e5a Merge pull request #1844 from danra/patch-39
Merge pull request #${ghprbPullId} from ${ghprbPullAuthorLogin}/${ghprbSourceBranch} requested by ${ghprbTriggerAuthorLogin}
2016-03-24 17:33:26 -07:00
danra
978e851a0e Add constexpr version of maximum to algorithm
Add the constexpr version of max which is only available in std since c++14.
Besides being a logical addition next to the already implemented constexpr version of min, there are actually other files, even in Swift/Basic itself, which re-implement this functionality, such as PrefixMap.h. Once this is implemented here, the functionality can be re-used in those other locations, instead of re-implemented each time.
2016-03-25 00:58:09 +02:00
danra
653b282682 Fix includes order 2016-03-25 00:49:03 +02:00
Dan Raviv
9942cfc6a2 Add missing word in DiverseListImpl comment 2016-03-25 00:42:59 +02:00
John McCall
0ffb7278bc Only use metadata patterns for generic types; perform other
initialization in-place on demand.  Initialize parent metadata
references correctly on struct and enum metadata.

Also includes several minor improvements related to relative
pointers that I was using before deciding to simply switch the
parent reference to an absolute reference to get better access
patterns.

Includes a fix since the earlier commit to make enum metadata
writable if they have an unfilled payload size.  This didn't show
up on Darwin because "constant" is currently unenforced there in
global data containing relocations.

This patch requires an associated LLDB change which is being
submitted in parallel.
2016-03-24 15:10:31 -07:00
Michael Ilseman
76f01b6473 Merge remote-tracking branch 'origin' into import-as-member 2016-03-24 12:46:13 -07:00
Michael Ilseman
8759905351 Merge remote-tracking branch 'origin' into import-as-member 2016-03-24 11:37:36 -07:00
danra
21b0c52ad6 Use auto instead of repeating explicit class names 2016-03-24 20:09:06 +02:00
danra
b41ccbd58a Add missing period in end of DiverseStack comment (NFC) 2016-03-24 19:41:42 +02:00
Dmitri Gribenko
7907b4b0de Merge pull request #1828 from danra/patch-25
Make nodeToString brief comment clearer (NFC)
2016-03-24 10:24:41 -07:00
danra
9ff4ee43a5 Use auto instead of repeating explicit class names 2016-03-24 18:18:51 +02:00
danra
25bda30cfd Fix DiverseListImpl comment grammar 2016-03-24 18:12:32 +02:00
danra
9cb3e763cd operator!= DRY 2016-03-24 18:07:59 +02:00
danra
2b1d4a763d Remove redundant else 2016-03-24 18:05:06 +02:00
danra
a8cbd1d190 Fix includes order - 3rd-party should follow local 2016-03-24 17:36:45 +02:00
danra
eb4930c5e1 Add missing period in comment 2016-03-24 17:34:48 +02:00
danra
6d14912cfa Compact getEnd implementation 2016-03-24 16:38:30 +02:00
danra
21f21e395b isInvalid methods DRY 2016-03-24 16:32:02 +02:00
danra
5f5786a725 Remove extra spaces in empty-body ctors
Currently some empty-body ctors in the file have a space, some don't. Canonized it.
2016-03-24 16:27:13 +02:00
danra
87fcb1bbb3 operator!= DRY 2016-03-24 16:18:35 +02:00
danra
b494ff93d0 Remove superfluous semicolon in comment (NFC) 2016-03-24 13:34:56 +02:00
danra
4f209a4098 Make nodeToString brief comment clearer (NFC)
IIUC this transforms a node representation of a demangled name to the equivalent string representation. It creates the string itself, and doesn't get the string as a parameter to write into. To me "transform in" was confusing, I think the natural language to use is "transform to".
2016-03-24 12:36:06 +02:00
rjmccall
ea0d95ba5d Merge pull request #1808 from danra/patch-18
static_assert that ClusteredBitVector::ChunkType is unsigned instead of just commenting as much.
2016-03-24 00:28:07 -07:00
John McCall
abba7f0c8b Revert "Only use metadata patterns for generic types; perform other"
This reverts commit 41efb3d4d3.
LLDB has too many tendrils into our metadata.
2016-03-23 20:26:43 -07:00
Chris Lattner
c153c3ab7d Merge pull request #1810 from danra/patch-20
[gardening] Improved comments (NFC)
2016-03-23 17:41:36 -07:00
Chris Lattner
9070697cce Merge pull request #1813 from danra/patch-22
Remove redundant parentheses (NFC)
2016-03-23 17:39:48 -07:00
danra
0623e12452 Add missing commas to multi-line enums
Some of the multi-line enums in the file currently have trailing commas after the last defined value, some don't.
2016-03-24 02:14:17 +02:00
John McCall
41efb3d4d3 Only use metadata patterns for generic types; perform other
initialization in-place on demand.  Initialize parent metadata
references correctly on struct and enum metadata.

Also includes several minor improvements related to relative
pointers that I was using before deciding to simply switch the
parent reference to an absolute reference to get better access
patterns.
2016-03-23 17:04:04 -07:00
Michael Ilseman
47e73ad4f1 Merge branch 'master' of github.com:apple/swift into import-as-member 2016-03-23 17:01:47 -07:00
danra
891dea4f70 Fix comment typo (NFC) 2016-03-24 00:45:02 +02:00
danra
fec14bfb9f Remove redundant parentheses (NFC) 2016-03-23 23:58:08 +02:00
danra
3ba34602e2 move copy-append before move-append overload
This is consistent with the usual convention of having copy methods before move methods (which is also used in this file in previous methods).
2016-03-23 23:54:57 +02:00
danra
7988864ab1 [gardening] Improved comments (NFC) 2016-03-23 23:39:37 +02:00
danra
98776388d4 Compact getCapacityInBits implementation (NFC) 2016-03-23 22:50:34 +02:00
danra
8134bfd55d static_assert ChunkType is unsigned 2016-03-23 22:26:16 +02:00
Michael Ilseman
d7581d1b36 Merge commit 'a31edf53d0580efe47f4e9ef89dccc4429c056e8' into import-as-member 2016-03-23 13:05:57 -07:00
Dan Raviv
29d76f3b68 Canonize swift header files headers and footers
- Added missing ifdef guard in PointerIntEnum header
- Consistent naming convention for ifdef guards
- Consistent 'end namespace swift'
- Consistent single EOL at end of header files
2016-03-23 09:04:12 +02:00
Doug Gregor
593932741c Remove historical flags -enable-omit-needless-words/-enable-infer-default-arguments/-enable-swift-name-lookup-tables.
NFC; all of these options are always-on now and we no longer have a
way to turn them off.
2016-03-22 17:04:19 -07:00
Michael Gottesman
f79a741a7d Merge pull request #1779 from danra/patch-5
Minor comment fixes
2016-03-22 14:38:13 -07:00
Chris Lattner
74c7d4164c Merge pull request #1794 from danra/patch-16
[gardening] Minor comment fix
2016-03-22 14:18:38 -07:00
Chris Lattner
09fb7226d7 Merge pull request #1793 from danra/patch-15
Add missing comment after .h file #endif
2016-03-22 14:18:10 -07:00
Chris Lattner
0ac95f1ae0 Merge pull request #1784 from danra/patch-10
Added missing 'const' to iterator comp. operators
2016-03-22 14:14:22 -07:00
danra
f63f165b54 [gardening] Minor comment fix 2016-03-22 23:09:06 +02:00
Dan Raviv
24113705fe [gardening] Minor comment fixes 2016-03-22 23:06:33 +02:00
danra
5eed1f748b Add missing comment after .h file #endif 2016-03-22 22:59:57 +02:00
Michael Gottesman
b094e776b5 Merge pull request #1785 from danra/patch-11
[gardening] Add missing comments
2016-03-22 13:44:24 -07:00
danra
890ff9c9c8 [gardening] Fix comments style 2016-03-22 22:39:30 +02:00
danra
f1e68696c9 Add missing comment after .h file #endif 2016-03-22 22:37:30 +02:00
danra
8aa1260622 Improve template typenames consistency
Rename BlotMapVector's template typenames: MapTy -> MapT and VectorTy -> VectorT. This is consistent both with BlotMapVector's other template typename KeyT and ValueT, and with SmallBlotMapVector's MapT and VectorT template typenames.
2016-03-22 22:26:34 +02:00
danra
d6bb90253c [gardening] Add missing comments 2016-03-22 22:17:19 +02:00