4 Commits

Author	SHA1	Message	Date
Nathan Hawes	f64a19bbbe	[syntax-coloring] Relax the requirement that the reported affected range extends to line boundaries ... The editor is now assumed to handle affected ranges that don't fall on line boundaries.	2017-09-14 21:34:22 -07:00
Nathan Hawes	6b9690ac5c	[syntax-coloring] Rework the syntax map to use offset+length rather than start/end line+column and simplify the delta logic ... This patch changes the syntax map data structure it uses to be offset based rather than line/col based in order to avoid calling getLineAndColumn for the start and end offset of every token. This removes the 30% of time spent in getLineAndColumn for this request in large files (rdar://problem/28965123). The logic for returning the affected range and the token ranges to highlight following an edit also made several assumptions that no longer hold. This patch changes it to compare the syntax maps from before and after the edit, find the first mismtaching tokens from the start and end of the syntax maps and return the tokens in that range (adjusted to line boundaries). This fixes syntax highlighting issues with interpolated multi-line strings (rdar://problem/32148117) and block comments. With the above changes the per-keystroke time spent for syntax highlighting (with sematic info disabled) dropped from ~80ms to just under 50ms for a 12KLOC file.	2017-09-14 21:34:21 -07:00
Nathan Hawes	e5426ecfa5	Revert "[SyntaxColor] Improve highligting of multiline strings" ... This reverts commit 86d0fc37bc. This was causing a performance regression. Resolves rdar://problem/32434045	2017-05-26 16:46:03 -07:00
Nathan Hawes	56fb4a5d9f	[SyntaxColor] Improve highligting of multiline strings ... Multiline strings (and multiline tokens in general) were not well supported by the existing highlighting logic. Edits on one line can make tokens appear/disappear on previous and later lines, which broke assumptions in the existing logic, and left odd ranges of source unhighlighted or out of date. This patch accounts for these changes, and also changes unterminated multiline (and regular strings) to still be highlighted as strings, so the rest of the file doesn't look like plain text. Resolves rdar://problem/32148117.	2017-05-22 16:53:32 -07:00