mirror of
https://github.com/apple/swift.git
synced 2025-12-14 20:36:38 +01:00
da07ff577c
PrintAsClang is supposed to emit declarations in the same order regardless of the compiler’s internal state, but we have repeatedly found that our current criteria are inadequate, resulting in non-functionality-affecting changes to generated header content. Add a diagnostic that’s emitted when this happens soliciting a bug report. Since there *should* be no cases where the compiler fails to order declarations, this diagnostic is never actually emitted. Instead, we test this change by enabling `-verify` on nearly all PrintAsClang tests to make sure they are unaffected. This did demonstrate a missing criterion that only mattered in C++ mode: extensions that varied only in their generic signature were not sorted stably. Add a sort criterion for this.
98 lines
3.9 KiB
Swift
98 lines
3.9 KiB
Swift
// RUN: %empty-directory(%t)
|
|
|
|
// RUN: %target-swift-frontend %s -enable-library-evolution -module-name Enums -clang-header-expose-decls=all-public -typecheck -verify -emit-clang-header-path %t/enums.h
|
|
// RUN: %FileCheck --check-prefixes=CHECK,OLD_CASE %s < %t/enums.h
|
|
|
|
// RUN: %target-swift-frontend %s -enable-library-evolution -D NEW_CASE -module-name Enums -clang-header-expose-decls=all-public -typecheck -verify -emit-clang-header-path %t/enums_new_case.h
|
|
// RUN: %FileCheck --check-prefixes=CHECK,NEW_CASE %s < %t/enums_new_case.h
|
|
|
|
// RUN: %check-interop-cxx-header-in-clang(%t/enums.h -Wno-unused-private-field -Wno-unused-function -DSWIFT_CXX_INTEROP_HIDE_STL_OVERLAY)
|
|
// RUN: %check-interop-cxx-header-in-clang(%t/enums_new_case.h -Wno-unused-private-field -Wno-unused-function -DSWIFT_CXX_INTEROP_HIDE_STL_OVERLAY)
|
|
|
|
public enum Foo {
|
|
case a(Double)
|
|
#if NEW_CASE
|
|
case b(Int)
|
|
#endif
|
|
}
|
|
|
|
public func makeFoo(_ x: Int) -> Foo {
|
|
#if NEW_CASE
|
|
if x >= 0 {
|
|
return .b(x)
|
|
} else {
|
|
return .a(Double(x))
|
|
}
|
|
#else
|
|
return .a(Double(x))
|
|
#endif
|
|
}
|
|
|
|
public func printFoo(_ x: Foo) {
|
|
print(x)
|
|
}
|
|
|
|
public enum Empty {
|
|
|
|
}
|
|
|
|
// CHECK: // Tags for resilient enum Empty
|
|
// CHECK-NEXT: extern "C" {
|
|
// CHECK-NEXT: }
|
|
// CHECK-EMPTY:
|
|
// CHECK-NEXT: } // namespace _impl
|
|
// CHECK-EMPTY:
|
|
// CHECK-NEXT: class SWIFT_SYMBOL("s:5Enums5EmptyO") Empty final {
|
|
// CHECK: enum class cases {
|
|
// CHECK-NEXT: unknownDefault
|
|
// CHECK-NEXT: };
|
|
// CHECK: inline const static struct _impl_unknownDefault { // impl struct for case unknownDefault
|
|
// CHECK-NEXT: SWIFT_INLINE_THUNK constexpr operator cases() const {
|
|
// CHECK-NEXT: return cases::unknownDefault;
|
|
// CHECK-NEXT: }
|
|
// CHECK-NEXT: } unknownDefault;
|
|
// CHECK-NEXT: SWIFT_INLINE_THUNK bool isUnknownDefault() const;
|
|
// CHECK: SWIFT_INLINE_THUNK operator cases() const {
|
|
// CHECK-NEXT: return cases::unknownDefault;
|
|
// CHECK-NEXT: }
|
|
// CHECK: // Tags for resilient enum Foo
|
|
// CHECK-NEXT: extern "C" {
|
|
// CHECK-NEXT: extern unsigned $s5Enums3FooO1ayACSdcACmFWC;
|
|
// NEW_CASE-NEXT: extern unsigned $s5Enums3FooO1byACSicACmFWC;
|
|
// CHECK-NEXT: }
|
|
// CHECK-EMPTY:
|
|
// CHECK-NEXT: } // namespace _impl
|
|
// CHECK-EMPTY:
|
|
// CHECK-NEXT: class SWIFT_SYMBOL("s:5Enums3FooO") Foo final {
|
|
// CHECK-NEXT: public:
|
|
// CHECK: enum class cases {
|
|
// CHECK-NEXT: a SWIFT_SYMBOL("s:5Enums3FooO1ayACSdcACmF"),
|
|
// NEW_CASE-NEXT: b SWIFT_SYMBOL("s:5Enums3FooO1byACSicACmF"),
|
|
// CHECK-NEXT: unknownDefault
|
|
// CHECK-NEXT: }
|
|
// CHECK: inline const static struct _impl_unknownDefault { // impl struct for case unknownDefault
|
|
// CHECK-NEXT: SWIFT_INLINE_THUNK constexpr operator cases() const {
|
|
// CHECK-NEXT: return cases::unknownDefault;
|
|
// CHECK-NEXT: }
|
|
// CHECK-NEXT: } unknownDefault;
|
|
// CHECK-NEXT: SWIFT_INLINE_THUNK bool isUnknownDefault() const;
|
|
// CHECK-EMPTY:
|
|
// CHECK: SWIFT_INLINE_THUNK operator cases() const {
|
|
// CHECK-NEXT: auto tag = _getEnumTag();
|
|
// CHECK-NEXT: if (tag == _impl::$s5Enums3FooO1ayACSdcACmFWC) return cases::a;
|
|
// NEW_CASE-NEXT: if (tag == _impl::$s5Enums3FooO1byACSicACmFWC) return cases::b;
|
|
// CHECK-NEXT: return cases::unknownDefault;
|
|
// CHECK-NEXT: }
|
|
// CHECK: SWIFT_INLINE_THUNK Foo Foo::_impl_a::operator()(double val) const {
|
|
// CHECK-NEXT: auto result = Foo::_make();
|
|
// CHECK-NEXT: memcpy(result._getOpaquePointer(), &val, sizeof(val));
|
|
// CHECK-NEXT: result._destructiveInjectEnumTag(_impl::$s5Enums3FooO1ayACSdcACmFWC);
|
|
// CHECK-NEXT: return result;
|
|
// CHECK-NEXT: }
|
|
// NEW_CASE: SWIFT_INLINE_THUNK Foo Foo::_impl_b::operator()(swift::Int val) const {
|
|
// NEW_CASE-NEXT: auto result = Foo::_make();
|
|
// NEW_CASE-NEXT: memcpy(result._getOpaquePointer(), &val, sizeof(val));
|
|
// NEW_CASE-NEXT: result._destructiveInjectEnumTag(_impl::$s5Enums3FooO1byACSicACmFWC);
|
|
// NEW_CASE-NEXT: return result;
|
|
// NEW_CASE-NEXT: }
|